Skip to content

Conversation

@notyashhh
Copy link
Member

@notyashhh notyashhh commented Aug 26, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@notyashhh notyashhh self-assigned this Aug 26, 2025
@notyashhh notyashhh changed the title [MCP] Added Fuzzy Search Support [MCP] Improved User Interaction to resolve Codegen Inputs Aug 29, 2025
@notyashhh notyashhh changed the title [MCP] Improved User Interaction to resolve Codegen Inputs [MCP] Improved UI to resolve Codegen Inputs Aug 29, 2025
@notyashhh notyashhh changed the title [MCP] Improved UI to resolve Codegen Inputs [MCP] Improved UI to resolve Codegen Inputs (Fuzzy Search) Aug 29, 2025
@notyashhh notyashhh changed the title [MCP] Improved UI to resolve Codegen Inputs (Fuzzy Search) [MCP] Improved UI for modular inputs for CodeGen (Fuzzy Search) Aug 29, 2025
@notyashhh notyashhh changed the title [MCP] Improved UI for modular inputs for CodeGen (Fuzzy Search) [MCP] Modular inputs for CodeGen (Fuzzy Search) Aug 29, 2025
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

@notyashhh notyashhh changed the title [MCP] Modular inputs for CodeGen (Fuzzy Search) [MCP] Modular inputs for CodeGen Sep 20, 2025
@notyashhh notyashhh changed the title [MCP] Modular inputs for CodeGen [MCP] Modular inputs + Enhanced Quality Tests Sep 22, 2025
@isra-fel isra-fel self-assigned this Oct 2, 2025
@isra-fel
Copy link
Member

isra-fel commented Oct 3, 2025

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create an assets folder and move private static assets there (ideal-module and readme template).
Keep the resourcesService as is

@isra-fel
Copy link
Member

isra-fel commented Oct 8, 2025

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@notyashhh notyashhh requested review from Copilot and isra-fel October 8, 2025 11:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces modular inputs and enhanced quality tests for the MCP server, transitioning from a single comprehensive workflow to a more structured, tool-based approach that separates concerns and improves testability.

Key Changes:

  • Refactored the monolithic partner module workflow into discrete, composable MCP tools
  • Implemented structured logging with daily file rotation and JSON output support
  • Added help-driven parameter filtering for examples and tests to ensure only documented parameters are used

Reviewed Changes

Copilot reviewed 36 out of 37 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tools/Mcp/test/vscode/mcpprompt.md Removed legacy monolithic workflow prompt in favor of modular approach
tools/Mcp/src/types.ts Added resourceSchema interface for new resource handling capabilities
tools/Mcp/src/specs/specs.json Updated tool definitions, removed greeting prompt, added new modular tools
tools/Mcp/src/specs/responses.json Updated response templates to use file-based content loading
tools/Mcp/src/services/utils.ts Enhanced with structured logging, improved error handling, and new utility functions
tools/Mcp/src/services/toolsService.ts Added comprehensive logging and new tool implementations
tools/Mcp/src/services/resourcesService.ts New service for handling MCP resources
tools/Mcp/src/services/logger.ts New structured logging system with file rotation and JSON support
tools/Mcp/src/index.ts Updated to use new logging system
tools/Mcp/src/assets/*.md New instruction templates for example and test generation
tools/Mcp/src/assets/ideal-modules/Databricks/* Added reference examples and tests for quality benchmarking
tools/Mcp/src/CodegenServer.ts Added resource support and enhanced error handling with logging
Comments suppressed due to low confidence (1)

tools/Mcp/src/services/logger.ts:1

  • Inconsistent path construction compared to getIdealModuleExamplePaths() which uses 'src/ideal-modules'. Should use consistent path structure.
/*

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM with one question

@notyashhh notyashhh requested a review from isra-fel October 15, 2025 17:15
@isra-fel isra-fel enabled auto-merge (squash) October 15, 2025 22:31
@isra-fel isra-fel merged commit 94c8b5c into dev/mcp-server Oct 15, 2025
12 checks passed
@isra-fel isra-fel deleted the yash/mcp-server2 branch October 15, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants