Skip to content

Update labels for breaking change notifications #28635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update labels for breaking change notifications #28635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/script/PrLabeled.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ $CommentDict = @{
‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.
"@
"Breaking Change Release" = @"
"Contains Breaking Change" = @"
To the author of the pull request,
This PR was labeled "Breaking Change Release" because it contains breaking changes.
This PR was labeled "Contains Breaking Change" because breaking changes are detected by the static analysis pipeline.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This PR was labeled "Contains Breaking Change" because breaking changes are detected by the static analysis pipeline.
This PR was labeled "Contains Breaking Change" because breaking changes have been detected by the static analysis pipeline.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: this wording may sound more natural?

- According to our [policy](https://eng.ms/docs/cloud-ai-platform/azure-core/azure-management-and-platforms/control-plane-bburns/azure-cli-tools-azure-cli-powershell-and-terraform/azure-cli-tools/devguide/azps/breaking-change/breaking-changes-policy), breaking changes can only take place during major release and they must be preannounced.
- Please follow our [guide](https://eng.ms/docs/cloud-ai-platform/azure-core/azure-management-and-platforms/control-plane-bburns/azure-cli-tools-azure-cli-powershell-and-terraform/azure-cli-tools/devguide/azps/breaking-change/breaking-changes-process) on the detailed steps.
- [ ] **Required**: Please fill in the [task](https://msazure.visualstudio.com/One/_workitems/create/Task?templateId=030c9f4f-a13e-4393-9b87-ae6fd458692b&ownerId=5439f061-9499-4da9-8c5a-659bd6db3188) below to facilitate our contact,you will receive notifications related to breaking changes.
Expand Down