[PS] Migrate DnsResolver module to autorest v4#28695
Open
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Pan-Qi
added
Contains Breaking Change
|
To the author of the pull request, |
Contributor
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request migrates the DnsResolver module from AutoRest v3 to AutoRest v4, introducing new features available in the updated code generator. The changes primarily involve regenerated help documentation, breaking change exception tracking, and minor namespace updates.
Changes:
- Upgraded help documentation with new parameter sets and corrected SYNOPSIS descriptions across all cmdlets
- Added breaking change exceptions CSV file to track API compatibility issues introduced by the migration
- Updated module manifest dependencies and metadata
- Modified namespace references from
Api20230701Previewto simplified model namespaces
Reviewed changes
Copilot reviewed 188 out of 188 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/DnsResolver/DnsResolver/ChangeLog.md | Added entry documenting AutoRest v4 upgrade |
| src/DnsResolver/DnsResolver/Az.DnsResolver.psd1 | Updated Az.Accounts dependency, generation date, and formatting |
| tools/StaticAnalysis/Exceptions/Az.DnsResolver/BreakingChangeIssues.csv | New file tracking 82 breaking changes from AutoRest migration |
| src/DnsResolver/DnsResolver/help/*.md | Updated SYNOPSIS from "Creates/Updates" to "Create/Update" and added new parameter sets |
| src/DnsResolver/DnsResolver.Autorest/docs/*.md | Similar help updates with parameter set additions |
| src/DnsResolver/DnsResolver.sln | Updated project GUID |
| src/DnsResolver/DnsResolver.Autorest/generate-info.json | Updated generation ID |
| src/DnsResolver/DnsResolver.Autorest/custom/csharp/*.cs | Updated namespace from Api20230701Preview to simplified Models |
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
Thanks @JoyerJin, I am on the private resolver team and will re-record the tests for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preannouncement PR:
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.