-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[Storage] support Geo SLA and OR SLA #28696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Geo SLA (Service Level Agreement) and Object Replication (OR) SLA features to Azure Storage accounts. It introduces new parameters for enabling Blob Geo Priority Replication on storage accounts and priority replication for object replication policies, providing enhanced geo-replication with service level agreements to improve recovery time objectives (RTO).
Key changes include:
- Added
EnableBlobGeoPriorityReplicationparameter to storage account creation and modification cmdlets - Added
EnablePriorityReplicationparameter to object replication policy configuration - Updated documentation and help files to reflect new parameters and functionality
Reviewed Changes
Copilot reviewed 52 out of 88 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| SetAzureStorageAccount.cs | Added EnableBlobGeoPriorityReplication parameter and logic for setting geo priority replication status |
| NewAzureStorageAccount.cs | Added EnableBlobGeoPriorityReplication parameter for new storage account creation |
| SetAzStorageObjectReplicationPolicy.cs | Added EnablePriorityReplication parameter for object replication policy configuration |
| PSStorageAccount.cs | Added GeoPriorityReplicationStatus property and wrapper class |
| PSObjectReplicationPolicy.cs | Added PriorityReplication property and wrapper class |
| Storage.Management.format.ps1xml | Updated table formatting to display Metrics and PriorityReplication columns |
| Help documentation files | Updated cmdlet help documentation with new parameters and examples |
| ChangeLog.md | Added release notes for the new features |
| Test files | Updated API version references in test session recordings |
isra-fel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one minor comment
Co-authored-by: Yeming Liu <[email protected]>
|
We have get approval from Alex Wang for this API change GA release in PSH. |
isra-fel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but please resolve the conflicts
resolved |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.