Skip to content

Conversation

@kamboj-prjwl
Copy link
Member

@kamboj-prjwl kamboj-prjwl commented Nov 17, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copilot AI review requested due to automatic review settings November 17, 2025 06:53
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure Network module's NetworkSecurityPerimeter.Autorest component, specifically targeting the 2025-03-01 API version release. The changes consist primarily of regenerated test recording files and test environment configuration updates.

Key Changes:

  • API version update from 2025-01-01 to 2025-03-01 across all test recordings
  • Test environment configuration refresh with new randomized resource names (from tklmb prefix to tgtdq prefix)
  • Addition of a breaking change exception for the New-AzApplicationGatewayFirewallPolicyManagedRuleOverride cmdlet

Reviewed Changes

Copilot reviewed 73 out of 272 changed files in this pull request and generated no comments.

File Description
tools/StaticAnalysis/Exceptions/Az.Network/BreakingChangeIssues.csv Adds exception for 'Sensitivity' parameter validation set change in firewall policy cmdlet
src/Network/NetworkSecurityPerimeter.Autorest/test/localEnv.json Updates test environment variables with new random string prefix and resource names
src/Network/NetworkSecurityPerimeter.Autorest/test/env.json Updates test environment variables (identical changes to localEnv.json)
src/Network/NetworkSecurityPerimeter.Autorest/test/*.Recording.json (multiple files) Regenerated test recordings with updated API version (2025-03-01), new resource names, timestamps, and correlation IDs
Files not reviewed (1)
  • src/Network/Network/Properties/Resources.Designer.cs: Language not supported

@notyashhh
Copy link
Member

Is this pr "DO NOT SQUASH"? @kamboj-prjwl

cc: @VeryEarly

@notyashhh
Copy link
Member

/azp run

@notyashhh notyashhh self-assigned this Nov 18, 2025
@notyashhh notyashhh added this to the Az 15.1.0 (12/02/2025) milestone Nov 18, 2025
@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@kamboj-prjwl
Copy link
Member Author

kamboj-prjwl commented Nov 18, 2025

Is this pr "DO NOT SQUASH"? @kamboj-prjwl

cc: @VeryEarly

We can apply DO NOT SQAUSH as done for previous releases also. Ref: #28692, #28558

@notyashhh notyashhh added the Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. label Nov 19, 2025
@github-actions
Copy link

‼️ Do NOT use squash to merge this pull request. All the commits must be merged to the target branch.
‼️ Enable "Allow merge commits" in the pull request settings. Select "Merge Commits" to merge the PR. Then go back to settings and disable the option.

@notyashhh
Copy link
Member

@kamboj-prjwl / @baoqihuang0326 please resolve the conflicts

@notyashhh
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@notyashhh
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

notyashhh
notyashhh previously approved these changes Nov 25, 2025
YanaXu
YanaXu previously approved these changes Nov 25, 2025
@notyashhh notyashhh dismissed stale reviews from YanaXu and themself November 25, 2025 07:26

waiting

@notyashhh notyashhh merged commit 0b4b996 into main Nov 25, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants