[dataprotection] Rename blob containers for item level restore #28904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
IannGeorges
requested review from
YanaXu and
hiaga
and removed request for
Copilot
Copilot finished reviewing on behalf of
IannGeorges
November 19, 2025 20:17
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
hiaga
reviewed
Nov 21, 2025
| ``` yaml | ||
| # it's the same options as command line options, just drop the double-dash! | ||
| commit: ebdacd9571bc8a5faad5b8d418c70c3b6b7c2965 | ||
| require: |
Member
There was a problem hiding this comment.
did we also need to update to the latest commit here. it's good to refresh to latest
|
|
||
| $PSBoundParameters.Add("EncryptionSetting", $encryptionSettings) | ||
|
|
||
| Write-Host "Entering Az.DataProtection.Internal\New-AzDataProtectionBackupVault line 175" |
Member
There was a problem hiding this comment.
remove/ modify this line, assuming this was only needed for debugging
| } | ||
| else | ||
| { | ||
| Write-Host "[Ianna] - we have added the identity type" |
| $hasCmkInfrastructureEncryption = $PSBoundParameters.Remove("CmkInfrastructureEncryption") | ||
|
|
||
| if (-not $hasCmkEncryptionState -and -not $hasCmkIdentityType -and -not $hasCmkUserAssignedIdentityId -and -not $hasCmkEncryptionKeyUri) { | ||
| Write-Host "Entering Az.DataProtection.Internal\New-AzDataProtectionBackupVault line 160" |
| { | ||
| if($PSBoundParameters.ContainsKey("IdentityType") -eq $false) | ||
| $identityTypeValue = "SystemAssigned" | ||
| if ($PSBoundParameters.ContainsKey("IdentityType")) |
Member
There was a problem hiding this comment.
do we need custom logic here? can we directly set the appropriate parameters to the generated command. try update the generated command to previous parameters so that will minimize the code changes here and easy to leverage
| [-EncryptionSetting <IEncryptionSettings>] [-Identity <IDppIdentityDetails>] | ||
| [-ImmutabilityState <ImmutabilityState>] [-NoWait] [-ResourceGuardOperationRequest <String[]>] | ||
| [-SoftDeleteRetentionDurationInDay <Double>] [-SoftDeleteState <SoftDeleteState>] [-Tag <Hashtable>] | ||
| [-Confirm] [-WhatIf] [<CommonParameters>] |
Member
There was a problem hiding this comment.
this looks like a breaking change in identity parameters. please revert/ fix
| ```yaml | ||
| Type: System.String | ||
| Parameter Sets: (All) | ||
| Parameter Sets: UpdateExpanded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.