Skip to content

Conversation

@arjun-d-patel
Copy link

Description

PS cmdlet design: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1532

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms
Copy link
Contributor

Please fix the failed static analysis issues.

@isra-fel
Copy link
Member

isra-fel commented Jan 5, 2026

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

isra-fel commented Jan 6, 2026

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@vidai-msft
Copy link
Contributor

@arjun-d-patel Our static analysis detected not all the required file changes in Network SDK are submitted in this PR. Please upload them all including those that are not related to your changes in the SDK.

@github-actions
Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@arjun-d-patel
Copy link
Author

@arjun-d-patel Our static analysis detected not all the required file changes in Network SDK are submitted in this PR. Please upload them all including those that are not related to your changes in the SDK.

Hi @vidai-msft, I didn't upload all of them because those were unrelated to my change. I am waiting on the target branch owner to upload all the sdk generated files so I can just rebase from that branch. But besides those SDK changes (assuming they will be corrected) can you review the other file changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants