Populate console close on cmd issue fix to all modules #29029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Comment on lines
+1
to
+7
| param( | ||
| [Parameter(Mandatory=$true)] | ||
| [string]$autorestVersion, | ||
|
|
||
| [Parameter(Mandatory=$true)] | ||
| [string]$changeLogEntry | ||
| ) |
There was a problem hiding this comment.
The script header is missing the shebang line and synopsis documentation. According to PowerShell cross-platform guidelines, all scripts should begin with #!/usr/bin/env pwsh and include a .SYNOPSIS section describing the script's purpose.
| if ($index -ge 0) { | ||
| $before = $cl[0..$index] | ||
| $after = $cl[($index+1)..($cl.Length-1)] | ||
| $new = $before + $changeLogEntry + "" + $after |
There was a problem hiding this comment.
The empty string \"\" concatenation is unclear. This should be replaced with an explicit array element to improve readability, such as adding a blank line element to the array.
Suggested change
| $new = $before + $changeLogEntry + "" + $after | |
| $new = $before + @($changeLogEntry, "") + $after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Populate console close on cmd issue fix to all modules.
Autorest Upgrade - 4.0.752
Please check storage module do not have changelog.md file before and created within this PR
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.