Skip to content

Populate console close on cmd issue fix 1 #29042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pan-Qi wants to merge 1 commit into from
Closed

Populate console close on cmd issue fix 1 #29042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 1 addition & 2 deletions generated/ADDomainServices/ADDomainServices.Autorest/exports/Get-AzADDomainService.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,7 @@ begin {

$context = Get-AzContext
if (-not $context -and -not $testPlayback) {
Write-Error "No Azure login detected. Please run 'Connect-AzAccount' to log in."
exit
throw "No Azure login detected. Please run 'Connect-AzAccount' to log in."
}

if ($null -eq [Microsoft.WindowsAzure.Commands.Utilities.Common.AzurePSCmdlet]::PowerShellVersion) {
Expand Down
3 changes: 1 addition & 2 deletions generated/ADDomainServices/ADDomainServices.Autorest/exports/New-AzADDomainService.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,8 +315,7 @@ begin {

$context = Get-AzContext
if (-not $context -and -not $testPlayback) {
Write-Error "No Azure login detected. Please run 'Connect-AzAccount' to log in."
exit
throw "No Azure login detected. Please run 'Connect-AzAccount' to log in."
}

if ($null -eq [Microsoft.WindowsAzure.Commands.Utilities.Common.AzurePSCmdlet]::PowerShellVersion) {
Expand Down
12 changes: 4 additions & 8 deletions generated/ADDomainServices/ADDomainServices.Autorest/exports/ProxyCmdletDefinitions.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,7 @@ begin {

$context = Get-AzContext
if (-not $context -and -not $testPlayback) {
Write-Error "No Azure login detected. Please run 'Connect-AzAccount' to log in."
exit
throw "No Azure login detected. Please run 'Connect-AzAccount' to log in."
}

if ($null -eq [Microsoft.WindowsAzure.Commands.Utilities.Common.AzurePSCmdlet]::PowerShellVersion) {
Expand Down Expand Up @@ -370,8 +369,7 @@ begin {

$context = Get-AzContext
if (-not $context -and -not $testPlayback) {
Write-Error "No Azure login detected. Please run 'Connect-AzAccount' to log in."
exit
throw "No Azure login detected. Please run 'Connect-AzAccount' to log in."
}

if ($null -eq [Microsoft.WindowsAzure.Commands.Utilities.Common.AzurePSCmdlet]::PowerShellVersion) {
Expand Down Expand Up @@ -784,8 +782,7 @@ begin {

$context = Get-AzContext
if (-not $context -and -not $testPlayback) {
Write-Error "No Azure login detected. Please run 'Connect-AzAccount' to log in."
exit
throw "No Azure login detected. Please run 'Connect-AzAccount' to log in."
}

if ($null -eq [Microsoft.WindowsAzure.Commands.Utilities.Common.AzurePSCmdlet]::PowerShellVersion) {
Expand Down Expand Up @@ -1172,8 +1169,7 @@ begin {

$context = Get-AzContext
if (-not $context -and -not $testPlayback) {
Write-Error "No Azure login detected. Please run 'Connect-AzAccount' to log in."
exit
throw "No Azure login detected. Please run 'Connect-AzAccount' to log in."
}

if ($null -eq [Microsoft.WindowsAzure.Commands.Utilities.Common.AzurePSCmdlet]::PowerShellVersion) {
Expand Down
3 changes: 1 addition & 2 deletions generated/ADDomainServices/ADDomainServices.Autorest/exports/Remove-AzADDomainService.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,7 @@ begin {

$context = Get-AzContext
if (-not $context -and -not $testPlayback) {
Write-Error "No Azure login detected. Please run 'Connect-AzAccount' to log in."
exit
throw "No Azure login detected. Please run 'Connect-AzAccount' to log in."
}

if ($null -eq [Microsoft.WindowsAzure.Commands.Utilities.Common.AzurePSCmdlet]::PowerShellVersion) {
Expand Down
3 changes: 1 addition & 2 deletions generated/ADDomainServices/ADDomainServices.Autorest/exports/Update-AzADDomainService.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,8 +343,7 @@ begin {

$context = Get-AzContext
if (-not $context -and -not $testPlayback) {
Write-Error "No Azure login detected. Please run 'Connect-AzAccount' to log in."
exit
throw "No Azure login detected. Please run 'Connect-AzAccount' to log in."
}

if ($null -eq [Microsoft.WindowsAzure.Commands.Utilities.Common.AzurePSCmdlet]::PowerShellVersion) {
Expand Down
48 changes: 27 additions & 21 deletions generated/ADDomainServices/ADDomainServices.Autorest/generated/api/Models/DomainService.cs
View file
Open in desktop

Large diffs are not rendered by default.

22 changes: 14 additions & 8 deletions ...DDomainServices/ADDomainServices.Autorest/generated/api/Models/DomainServiceProperties.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,28 +119,34 @@ public partial class DomainServiceProperties :
Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IDomainSecuritySettings Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IDomainServicePropertiesInternal.DomainSecuritySetting { get => (this._domainSecuritySetting = this._domainSecuritySetting ?? new Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.DomainSecuritySettings()); set { {_domainSecuritySetting = value;} } }

/// <summary>Internal Acessors for LdapSettingCertificateNotAfter</summary>
global::System.DateTime? Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IDomainServicePropertiesInternal.LdapSettingCertificateNotAfter { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.ILdapsSettingsInternal)LdapsSetting).CertificateNotAfter; set => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.ILdapsSettingsInternal)LdapsSetting).CertificateNotAfter = value; }
global::System.DateTime? Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IDomainServicePropertiesInternal.LdapSettingCertificateNotAfter { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.ILdapsSettingsInternal)LdapsSetting).CertificateNotAfter; set => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.ILdapsSettingsInternal)LdapsSetting).CertificateNotAfter = value ?? default(global::System.DateTime); }

/// <summary>Internal Acessors for LdapSettingCertificateThumbprint</summary>
string Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IDomainServicePropertiesInternal.LdapSettingCertificateThumbprint { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.ILdapsSettingsInternal)LdapsSetting).CertificateThumbprint; set => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.ILdapsSettingsInternal)LdapsSetting).CertificateThumbprint = value; }
string Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IDomainServicePropertiesInternal.LdapSettingCertificateThumbprint { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.ILdapsSettingsInternal)LdapsSetting).CertificateThumbprint; set => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.ILdapsSettingsInternal)LdapsSetting).CertificateThumbprint = value ?? null; }

/// <summary>Internal Acessors for LdapSettingPublicCertificate</summary>
string Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IDomainServicePropertiesInternal.LdapSettingPublicCertificate { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.ILdapsSettingsInternal)LdapsSetting).PublicCertificate; set => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.ILdapsSettingsInternal)LdapsSetting).PublicCertificate = value; }
string Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IDomainServicePropertiesInternal.LdapSettingPublicCertificate { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.ILdapsSettingsInternal)LdapsSetting).PublicCertificate; set => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.ILdapsSettingsInternal)LdapsSetting).PublicCertificate = value ?? null; }

/// <summary>Internal Acessors for LdapsSetting</summary>
Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.ILdapsSettings Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IDomainServicePropertiesInternal.LdapsSetting { get => (this._ldapsSetting = this._ldapsSetting ?? new Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.LdapsSettings()); set { {_ldapsSetting = value;} } }

/// <summary>Internal Acessors for MigrationProgressCompletionPercentage</summary>
double? Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IDomainServicePropertiesInternal.MigrationProgressCompletionPercentage { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).MigrationProgressCompletionPercentage; set => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).MigrationProgressCompletionPercentage = value ?? default(double); }

/// <summary>Internal Acessors for MigrationProgressMessage</summary>
string Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IDomainServicePropertiesInternal.MigrationProgressMessage { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).MigrationProgressMessage; set => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).MigrationProgressMessage = value ?? null; }

/// <summary>Internal Acessors for MigrationProperty</summary>
Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationProperties Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IDomainServicePropertiesInternal.MigrationProperty { get => (this._migrationProperty = this._migrationProperty ?? new Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.MigrationProperties()); set { {_migrationProperty = value;} } }

/// <summary>Internal Acessors for MigrationPropertyMigrationProgress</summary>
Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationProgress Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IDomainServicePropertiesInternal.MigrationPropertyMigrationProgress { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).MigrationProgress; set => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).MigrationProgress = value; }
Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationProgress Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IDomainServicePropertiesInternal.MigrationPropertyMigrationProgress { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).MigrationProgress; set => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).MigrationProgress = value ?? null /* model class */; }

/// <summary>Internal Acessors for MigrationPropertyOldSubnetId</summary>
string Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IDomainServicePropertiesInternal.MigrationPropertyOldSubnetId { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).OldSubnetId; set => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).OldSubnetId = value; }
string Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IDomainServicePropertiesInternal.MigrationPropertyOldSubnetId { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).OldSubnetId; set => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).OldSubnetId = value ?? null; }

/// <summary>Internal Acessors for MigrationPropertyOldVnetSiteId</summary>
string Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IDomainServicePropertiesInternal.MigrationPropertyOldVnetSiteId { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).OldVnetSiteId; set => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).OldVnetSiteId = value; }
string Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IDomainServicePropertiesInternal.MigrationPropertyOldVnetSiteId { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).OldVnetSiteId; set => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).OldVnetSiteId = value ?? null; }

/// <summary>Internal Acessors for NotificationSetting</summary>
Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.INotificationSettings Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IDomainServicePropertiesInternal.NotificationSetting { get => (this._notificationSetting = this._notificationSetting ?? new Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.NotificationSettings()); set { {_notificationSetting = value;} } }
Expand All @@ -162,11 +168,11 @@ public partial class DomainServiceProperties :

/// <summary>Completion Percentage</summary>
[Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Origin(Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.PropertyOrigin.Inlined)]
public double? MigrationProgressCompletionPercentage { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).MigrationProgressCompletionPercentage; set => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).MigrationProgressCompletionPercentage = value ?? default(double); }
public double? MigrationProgressCompletionPercentage { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).MigrationProgressCompletionPercentage; }

/// <summary>Progress Message</summary>
[Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Origin(Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.PropertyOrigin.Inlined)]
public string MigrationProgressMessage { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).MigrationProgressMessage; set => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).MigrationProgressMessage = value ?? null; }
public string MigrationProgressMessage { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal)MigrationProperty).MigrationProgressMessage; }

/// <summary>Backing field for <see cref="MigrationProperty" /> property.</summary>
private Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationProperties _migrationProperty;
Expand Down
10 changes: 8 additions & 2 deletions ...ed/ADDomainServices/ADDomainServices.Autorest/generated/api/Models/MigrationProperties.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ public partial class MigrationProperties :
/// <summary>Internal Acessors for MigrationProgress</summary>
Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationProgress Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal.MigrationProgress { get => (this._migrationProgress = this._migrationProgress ?? new Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.MigrationProgress()); set { {_migrationProgress = value;} } }

/// <summary>Internal Acessors for MigrationProgressCompletionPercentage</summary>
double? Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal.MigrationProgressCompletionPercentage { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationProgressInternal)MigrationProgress).CompletionPercentage; set => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationProgressInternal)MigrationProgress).CompletionPercentage = value ?? default(double); }

/// <summary>Internal Acessors for MigrationProgressMessage</summary>
string Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal.MigrationProgressMessage { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationProgressInternal)MigrationProgress).ProgressMessage; set => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationProgressInternal)MigrationProgress).ProgressMessage = value ?? null; }

/// <summary>Internal Acessors for OldSubnetId</summary>
string Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationPropertiesInternal.OldSubnetId { get => this._oldSubnetId; set { {_oldSubnetId = value;} } }

Expand All @@ -31,11 +37,11 @@ public partial class MigrationProperties :

/// <summary>Completion Percentage</summary>
[Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Origin(Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.PropertyOrigin.Inlined)]
public double? MigrationProgressCompletionPercentage { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationProgressInternal)MigrationProgress).CompletionPercentage; set => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationProgressInternal)MigrationProgress).CompletionPercentage = value ?? default(double); }
public double? MigrationProgressCompletionPercentage { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationProgressInternal)MigrationProgress).CompletionPercentage; }

/// <summary>Progress Message</summary>
[Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Origin(Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.PropertyOrigin.Inlined)]
public string MigrationProgressMessage { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationProgressInternal)MigrationProgress).ProgressMessage; set => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationProgressInternal)MigrationProgress).ProgressMessage = value ?? null; }
public string MigrationProgressMessage { get => ((Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IMigrationProgressInternal)MigrationProgress).ProgressMessage; }

/// <summary>Backing field for <see cref="OldSubnetId" /> property.</summary>
private string _oldSubnetId;
Expand Down
33 changes: 1 addition & 32 deletions ...rvices/ADDomainServices.Autorest/generated/cmdlets/NewAzADDomainService_CreateExpanded.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,6 @@ public partial class NewAzADDomainService_CreateExpanded : global::System.Manage
/// <summary>A dictionary to carry over additional data for pipeline.</summary>
private global::System.Collections.Generic.Dictionary<global::System.String,global::System.Object> _extensibleParameters = new System.Collections.Generic.Dictionary<string, object>();

/// <summary>A buffer to record first returned object in response.</summary>
private object _firstResponse = null;

/// <summary>
/// A flag to tell whether it is the first returned object in a call. Zero means no response yet. One means 1 returned object.
/// Two means multiple returned objects in response.
/// </summary>
private int _responseSize = 0;

/// <summary>when specified, runs this cmdlet as a PowerShell job</summary>
[global::System.Management.Automation.Parameter(Mandatory = false, HelpMessage = "Run the command as a job")]
[global::Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Category(global::Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.ParameterCategory.Runtime)]
Expand Down Expand Up @@ -552,11 +543,6 @@ public Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Cmdlets.NewAzADDomain
/// <summary>Performs clean-up after the command execution</summary>
protected override void EndProcessing()
{
if (1 ==_responseSize)
{
// Flush buffer
WriteObject(_firstResponse);
}
var telemetryInfo = Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Module.Instance.GetTelemetryInfo?.Invoke(__correlationId);
if (telemetryInfo != null)
{
Expand Down Expand Up @@ -872,24 +858,7 @@ protected override void StopProcessing()
// onOk - response for 200 / application/json
// (await response) // should be Microsoft.Azure.PowerShell.Cmdlets.ADDomainServices.Models.IDomainService
var result = (await response);
if (null != result)
{
if (0 == _responseSize)
{
_firstResponse = result;
_responseSize = 1;
}
else
{
if (1 ==_responseSize)
{
// Flush buffer
WriteObject(_firstResponse.AddMultipleTypeNameIntoPSObject());
}
WriteObject(result.AddMultipleTypeNameIntoPSObject());
_responseSize = 2;
}
}
WriteObject(result, false);
}
}
}
Expand Down
Loading
Loading