[Az.SignalR] PR Reopen_Migrate Autorest Generation v3 to v4#29050
Open
JiaSeng-v wants to merge 13 commits intoAzure:mainfrom
Open
[Az.SignalR] PR Reopen_Migrate Autorest Generation v3 to v4#29050JiaSeng-v wants to merge 13 commits intoAzure:mainfrom
JiaSeng-v wants to merge 13 commits intoAzure:mainfrom
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request migrates the Az.SignalR module from AutoRest generation v3 to v4, which is a significant infrastructure upgrade. The migration introduces breaking changes in type signatures and parameter handling for WebPubSub cmdlets.
Changes:
- Migrated AutoRest-generated code from v3 to v4 framework
- Updated 79 breaking changes documented in exception file for backwards compatibility tracking
- Added new cmdlets: Update-AzWebPubSubHub and Update-AzWebPubSubCustomDomain
- Updated help documentation for all affected cmdlets with cleaner parameter descriptions
- Modified test files to reflect new parameter naming (e.g.,
-IdentityType SystemAssignedto-EnableSystemAssignedIdentity $true)
Reviewed changes
Copilot reviewed 123 out of 128 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/StaticAnalysis/Exceptions/Az.SignalR/BreakingChangeIssues.csv | Documents 79 breaking changes from AutoRest v3 to v4 migration |
| src/SignalR/SignalR/ChangeLog.md | Adds changelog entry with link to breaking changes documentation |
| src/SignalR/SignalR/help/*.md | Updates help documentation for all WebPubSub cmdlets with cleaner parameter syntax |
| src/SignalR/SignalR.Autorest/test/*.ps1 | Updates tests to use new parameter patterns |
| src/SignalR/SignalR.Autorest/test/env.json | Updates test environment subscription and tenant IDs |
| src/SignalR/SignalR.Autorest/examples/*.md | Adds examples for new Update cmdlets |
| src/SignalR/SignalR/Az.SignalR.psd1 | Updates module manifest with new cmdlets and generation date |
| src/SignalR/SignalR.sln | Updates solution file structure for AutoRest v4 |
| mydomain wps.manual-test.dev.signalr.azure.com Succeeded | ||
| ``` | ||
|
|
||
| Update a custom domian. No newline at end of file |
There was a problem hiding this comment.
Typo in the documentation: "domian" should be "domain".
| mydomain wps.manual-test.dev.signalr.azure.com Succeeded | ||
| ``` | ||
|
|
||
| Update a custom domian. |
There was a problem hiding this comment.
Typo in the documentation: "domian" should be "domain".
JiaSeng-v
added
Contains Breaking Change
|
To the author of the pull request, |
JiaSeng-v
force-pushed
the
jiaseng/main/SignalR-v4
branch
from
b5b722b to
60ad598
Compare
Y-Sindo
reviewed
Jan 20, 2026
|
|
||
| [Parameter()] | ||
| [ArgumentCompleter([Microsoft.Azure.PowerShell.Cmdlets.WebPubSub.Support.ManagedIdentityType])] | ||
| # [ArgumentCompleter([Microsoft.Azure.PowerShell.Cmdlets.WebPubSub.Support.ManagedIdentityType])] |
Member
There was a problem hiding this comment.
Just curious, why is this ArgumentCompleter commented out, but it still appears in the generated doc?
Y-Sindo
approved these changes
Jan 20, 2026
Contributor
|
This PR LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preannouncement PR: #29080
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.