Skip to content

Conversation

@santoshgh317
Copy link

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

bzpiyush and others added 5 commits December 23, 2025 10:27
…eation (#29004)

Co-authored-by: Piyush Mishra <piyushmishra@microsoft.com>
Co-authored-by: Santosh Lokarapu <v-slokar@microsoft.com>
…etwork-2025-05-01-sync

Sync branch with main
Co-authored-by: Karthik Gumpu (from Dev Box) <karthikgumpu@microsoft.com>
Copilot AI review requested due to automatic review settings January 22, 2026 07:11
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the Network Security Perimeter module to use API version 2025-05-01 (from 2025-03-01). The changes include API version updates across configuration files, regenerated test recordings with new test data, a version bump in the assembly info, and addition of an IpVersionType property to the PSPrivateEndpoint model.

Changes:

  • API version updated from 2025-03-01 to 2025-05-01 across all UX JSON files and README
  • Test environment files and recordings regenerated with new test data and timestamps
  • Assembly version bumped from 7.23.0 to 7.24.1
  • Added IpVersionType property to PSPrivateEndpoint model

Reviewed changes

Copilot reviewed 37 out of 203 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
README.md Updated API specification reference to commit b6d0dc8ef749d50348f0e27f5eee38ac3e5469d0 for 2025-05-01 API version
UX/*.json Updated apiVersion from 2025-03-01 to 2025-05-01 across all resource type definitions
test/env.json, test/localEnv.json Regenerated test environment with new resource names and random string "t7qc8"
test/*.Recording.json Regenerated test recordings with new API version URLs and 2026-01-21 timestamps
Properties/AssemblyInfo.cs Version bump from 7.23.0 to 7.24.1
Models/PSPrivateEndpoint.cs Added IpVersionType string property
generate-info.json Updated generation ID

# readme.azure.noprofile.md is the common configuration file
# - ../../../../tools/SwaggerCI/readme.azure.noprofile.md
- $(this-folder)/../../readme.azure.noprofile.md
commit: main
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README.md uses 'commit: main' to reference the API specification, but according to the coding guidelines for AutoRest README.md files, you should always use a specific commit hash instead of a branch name to ensure reproducible builds and prevent breaking changes when the specification repository evolves.

Copilot generated this review using guidance from repository custom instructions.
@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copilot AI review requested due to automatic review settings January 22, 2026 12:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@vidai-msft vidai-msft added the Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. label Jan 22, 2026
@github-actions
Copy link

‼️ Do NOT use squash to merge this pull request. All the commits must be merged to the target branch.
‼️ Enable "Allow merge commits" in the pull request settings. Select "Merge Commits" to merge the PR. Then go back to settings and disable the option.

@vidai-msft
Copy link
Contributor

@santoshgh317 Network release branch has new commits merges. Could you please double check if the generated SDK is expected?

@vidai-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants