Skip to content

[dataprotection]fix default rule name for blob policy #29171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IannGeorges wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[dataprotection]fix default rule name for blob policy #29171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DataProtection/DataProtection.Autorest/custom/manifests/AzureBlob.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
}
],
"isDefault": true,
"name": "Default",
"name": "Default_OperationalStore",
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The retention rule name "Default_OperationalStore" is inconsistent with its sourceDataStore type "VaultStore" (line 75). According to the naming convention observed in test recordings and other manifest files, retention rules should follow this pattern:

  • When sourceDataStore is "OperationalStore", the name should be "Default_OperationalStore"
  • When sourceDataStore is "VaultStore", the name should be "Default"

Since this retention rule has sourceDataStore set to "VaultStore", the name should remain "Default", not "Default_OperationalStore". This change introduces a bug where the rule name doesn't match the actual datastore type being used.

Suggested change
"name": "Default_OperationalStore",
"name": "Default",

Copilot uses AI. Check for mistakes.
"objectType": "AzureRetentionRule"
}
],
Expand Down
Loading