Add Trusted Launch security type support to New-AzMigrateServerReplication#29201
Open
shreyasmalims wants to merge 2 commits intoAzure:mainfrom
Open
Add Trusted Launch security type support to New-AzMigrateServerReplication#29201shreyasmalims wants to merge 2 commits intoAzure:mainfrom
shreyasmalims wants to merge 2 commits intoAzure:mainfrom
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for Trusted Launch security type to the New-AzMigrateServerReplication cmdlet in the Azure Migrate module. The feature enables users to configure Azure VMs with enhanced security capabilities during migration, including TPM and Secure Boot settings.
Changes:
- Added two new parameters (
TargetSecurityTypeandTargetVMSecureBootEnabled) to specify VM security configuration - Implemented logic to automatically enable TPM and default Secure Boot to "true" when TrustedLaunch is selected
- Added validation to prevent using Secure Boot with non-TrustedLaunch security types
src/Migrate/Migrate.Autorest/custom/New-AzMigrateServerReplication.ps1
Outdated
Show resolved
Hide resolved
src/Migrate/Migrate.Autorest/custom/New-AzMigrateServerReplication.ps1
Outdated
Show resolved
Hide resolved
src/Migrate/Migrate.Autorest/custom/New-AzMigrateServerReplication.ps1
Outdated
Show resolved
Hide resolved
src/Migrate/Migrate.Autorest/custom/New-AzMigrateServerReplication.ps1
Outdated
Show resolved
Hide resolved
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Collaborator
|
@shreyasmalims please update the changelog and consider whether new examples are needed for generating a new doc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Trusted Launch security type for Azure Migrate server replication.
Changes made:
TargetSecurityTypeparameter to specify security type for Azure VM (Standard or TrustedLaunch)TargetVMSecureBootEnabledparameter to control secure boot on target VMAz.Computemodule import that was redundantDesign decisions:
TargetSecurityTypeis set to "TrustedLaunch" without explicitly settingTargetVMSecureBootEnabled, secure boot is automatically enabled (defaults to "true")This implementation is based on the changes from AsrOneSdk/azure-powershell PR #37 which was never merged.
ChangeLog:
Checklist
CONTRIBUTING.mdand reviewed the following information:generationbranch.ChangeLog.mdfile(s) appropriatelyChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch.ChangeLog.mdif no new release is required, such as fixing test case only.