Skip to content

[FileShare] Add Az.FileShare module first preview release#29208

Open
blueww wants to merge 4 commits intoAzure:mainfrom
wastoresh:MFS-new2
Open

[FileShare] Add Az.FileShare module first preview release#29208
blueww wants to merge 4 commits intoAzure:mainfrom
wastoresh:MFS-new2

Conversation

@blueww
Copy link
Member

@blueww blueww commented Feb 26, 2026

Description

PSH Design review : https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1536
PR to update typespec: Azure/azure-rest-api-specs#40789

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copilot AI review requested due to automatic review settings February 26, 2026 09:14
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@blueww blueww marked this pull request as draft February 26, 2026 09:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request introduces the Az.FileShare module as a first preview release. It is an AutoRest-generated PowerShell module for managing Azure File Shares and their snapshots through the Microsoft.FileShares resource provider.

Changes:

  • Added new Az.FileShare module with complete AutoRest-generated structure
  • Included cmdlets for file share management (CRUD operations), snapshot management, and utility functions
  • Added comprehensive help documentation with examples for all cmdlets
  • Configured module mapping and integration with Az PowerShell build system

Reviewed changes

Copilot reviewed 75 out of 75 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
tools/CreateMappings_rules.json Added FileShare module mapping entry
src/FileShare/FileShare/ChangeLog.md Module changelog documenting first preview release
src/FileShare/FileShare/Az.FileShare.psd1 Module manifest with metadata and exported cmdlets
src/FileShare/FileShare/Properties/AssemblyInfo.cs Assembly information with version 0.1.0
src/FileShare/FileShare/FileShare.csproj Project file for module build configuration
src/FileShare/FileShare/help/*.md Help documentation for 12 cmdlets (Get, New, Update, Remove, Test operations)
src/FileShare/FileShare.Autorest/* AutoRest-generated module structure including custom, test, examples, and docs folders
src/FileShare/FileShare.Autorest/tsp-location.yaml TypeSpec location configuration with commit hash reference
src/FileShare/FileShare.Autorest/README.md Module overview and development instructions

@blueww blueww force-pushed the MFS-new2 branch 2 times, most recently from 5e38a9a to aa4e2d0 Compare February 26, 2026 09:32
Copilot AI review requested due to automatic review settings February 26, 2026 09:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 75 out of 75 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings March 2, 2026 03:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 75 out of 75 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (6)

src/FileShare/FileShare.Autorest/test/loadEnv.ps1:1

  • Line 27 ignores $envFilePath and always loads from (Join-Path $PSScriptRoot $envFile), which breaks the fallback path logic in lines 20–24. Load from $envFilePath (and use it consistently) so playback/live can find env.json regardless of location.
    src/FileShare/FileShare.Autorest/utils/Unprotect-SecureString.ps1:1
  • This utility converts SecureString to plaintext and returns it, which can easily leak secrets via pipeline/out-default, transcript logs, or crash dumps. If this is only needed for tests, move it under the test folder (non-packaged) or otherwise ensure it is not shipped/exported; if it must ship, add strong guardrails (e.g., explicit -Force/-AsPlainText switch, warning, and avoid returning plaintext by default).
    src/FileShare/FileShare.Autorest/tsp-location.yaml:1
  • The repo points to a personal fork (blueww/azure-rest-api-specs). For a preview release, generation metadata should generally reference the canonical upstream repo (e.g., Azure/azure-rest-api-specs) so others can reproduce generation without depending on a fork.
    src/FileShare/FileShare/ChangeLog.md:1
  • This changelog doesn't follow the template described at the top of the file (dated release header like ## YYYY.MM.DD - Version X.Y.Z) and leaves ## Upcoming Release empty. Please either move the entry under ## Upcoming Release (past tense) or format the release section per the required convention so release tooling/parsing stays consistent.
    src/FileShare/FileShare.Autorest/test/Get-AzFileShare.Tests.ps1:1
  • All newly added Pester tests are currently skipped and only assert that a NotImplementedException isn't thrown, which provides no functional coverage. Add at least basic playback-mode tests that invoke the cmdlets with recorded responses and validate key properties, then remove -skip so CI can catch regressions.
    src/FileShare/FileShare.Autorest/how-to.md:1
  • Correct spelling of 'Supresses' to 'Suppresses'.

@blueww blueww marked this pull request as ready for review March 2, 2026 06:15
Copilot AI review requested due to automatic review settings March 2, 2026 06:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 76 out of 76 changed files in this pull request and generated 14 comments.

@blueww
Copy link
Member Author

blueww commented Mar 3, 2026

@NoriZC
Would you please help to review this PR?
This new preview module target release on 4/7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants