[set-status] Trigger on both old and new names (#36653)

Author: mikeharder

.github/package.json

@@ -43,6 +43,7 @@
     "format:check": "prettier . --check",
     "format:check:ci": "prettier . --check --log-level debug",
     "test": "vitest",
-    "test:ci": "vitest run --coverage --reporter=verbose"
+    "test:ci": "vitest run --coverage --reporter=verbose",
+    "validate": "npm run lint && npm run format:check && npm run test:ci"
   }
 }

.github/workflows/avocado-status.yaml

@@ -15,7 +15,8 @@ on:
       - labeled
       - unlabeled
   workflow_run:
-    workflows: ["Swagger Avocado - Analyze Code"]
+    # Trigger on both old and new names, to handle the rename more gracefully
+    workflows: ["Swagger Avocado - Analyze Code", "[TEST-IGNORE] Swagger Avocado - Analyze Code"]
     types: [completed]
 
 permissions:

.github/workflows/breaking-change-cross-version-status.yaml

@@ -15,7 +15,12 @@ on:
       - labeled
       - unlabeled
   workflow_run:
-    workflows: ["Breaking Change(Cross-Version) - Analyze Code"]
+    # Trigger on both old and new names, to handle the rename more gracefully
+    workflows:
+      [
+        "Breaking Change(Cross-Version) - Analyze Code",
+        "[TEST-IGNORE] Breaking Change(Cross-Version) - Analyze Code",
+      ]
     types: [completed]
 
 permissions:

.github/workflows/breaking-change-status.yaml

@@ -15,7 +15,12 @@ on:
       - labeled
       - unlabeled
   workflow_run:
-    workflows: ["Swagger BreakingChange - Analyze Code"]
+    # Trigger on both old and new names, to handle the rename more gracefully
+    workflows:
+      [
+        "Swagger BreakingChange - Analyze Code",
+        "[TEST-IGNORE] Swagger BreakingChange - Analyze Code",
+      ]
     types: [completed]
 
 permissions:

.github/workflows/lintdiff-status.yaml

@@ -15,7 +15,8 @@ on:
       - labeled
       - unlabeled
   workflow_run:
-    workflows: ["Swagger LintDiff - Analyze Code"]
+    # Trigger on both old and new names, to handle the rename more gracefully
+    workflows: ["Swagger LintDiff - Analyze Code", "[TEST-IGNORE] Swagger LintDiff - Analyze Code"]
     types: [completed]
 
 permissions:

.github/workflows/src/set-status.js

@@ -7,6 +7,7 @@ import {
   CommitStatusState,
   PER_PAGE_MAX,
 } from "../../shared/src/github.js";
+import { byDate, invert } from "../../shared/src/sort.js";
 import { extractInputs } from "./context.js";
 
 // TODO: Add tests
@@ -138,17 +139,23 @@ export async function setStatusImpl({
   });
 
   const targetRuns = workflowRuns
-    .filter((wf) => wf.name == monitoredWorkflowName)
+    .filter(
+      (wf) =>
+        // Match both old and new names, to handle the rename more gracefully
+        wf.name === monitoredWorkflowName || wf.name === `[TEST-IGNORE] ${monitoredWorkflowName}`,
+    )
     // Sort by "updated_at" descending
-    .sort((a, b) => new Date(b.updated_at).getTime() - new Date(a.updated_at).getTime());
+    .sort(invert(byDate((r) => r.updated_at)));
 
   // Sorted by "updated_at" descending, so most recent run is at index 0.
   // If "targetRuns.length === 0", run will be "undefined", which the following
   // code must handle.
   const run = targetRuns[0];
 
   if (!run) {
-    console.log(`No workflow runs found for '${monitoredWorkflowName}'.`);
+    console.log(
+      `No workflow runs found for '${monitoredWorkflowName}' or '[TEST-IGNORE] ${monitoredWorkflowName}'.`,
+    );
   }
 
   if (run) {
@@ -219,7 +226,8 @@ export async function setStatusImpl({
     });
   } else {
     core.info(
-      `No workflow runs found for '${monitoredWorkflowName}'. Setting status to ${CommitStatusState.PENDING} for required status: ${requiredStatusName}.`,
+      `No workflow runs found for '${monitoredWorkflowName}' or '[TEST-IGNORE] ${monitoredWorkflowName}'.` +
+        ` Setting status to ${CommitStatusState.PENDING} for required status: ${requiredStatusName}.`,
     );
     // Run was not found (not started), or not completed
     await github.rest.repos.createCommitStatus({

.github/workflows/swagger-modelvalidation-status.yaml

@@ -15,7 +15,12 @@ on:
       - labeled
       - unlabeled
   workflow_run:
-    workflows: ["Swagger ModelValidation - Analyze Code"]
+    # Trigger on both old and new names, to handle the rename more gracefully
+    workflows:
+      [
+        "Swagger ModelValidation - Analyze Code",
+        "[TEST-IGNORE] Swagger ModelValidation - Analyze Code",
+      ]
     types: [completed]
 
 permissions:

.github/workflows/swagger-semanticvalidation-status.yaml

@@ -15,7 +15,12 @@ on:
       - labeled
       - unlabeled
   workflow_run:
-    workflows: ["Swagger SemanticValidation - Analyze Code"]
+    # Trigger on both old and new names, to handle the rename more gracefully
+    workflows:
+      [
+        "Swagger SemanticValidation - Analyze Code",
+        "[TEST-IGNORE] Swagger SemanticValidation - Analyze Code",
+      ]
     types: [completed]
 
 permissions: