Skip to content

Microsoft.ProviderHub: Add new API version 2021-06-01-preview #14650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 14, 2021
Merged

Microsoft.ProviderHub: Add new API version 2021-06-01-preview #14650

merged 9 commits into from
Jul 14, 2021

Conversation

diwudd
Copy link
Contributor

@diwudd diwudd commented Jun 2, 2021 •
edited
Loading

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service

  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @diwudd Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 2, 2021 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️LintDiff: 26 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L3837
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L3861
    ⚠️ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options. Property name: origin
    Location: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L3814
    ⚠️ R2018 - XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options. Property name: actionType
    Location: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L3830
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
    Location: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L2488
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction
    Location: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L3810
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
    Location: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L4359
    ⚠️ R4021 - DescriptionAndTitleMissing 'ProvisioningState' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L2199
    ⚠️ R4021 - DescriptionAndTitleMissing 'expeditedRollout' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L2497
    ⚠️ R4021 - DescriptionAndTitleMissing 'LocalizedOperationDisplayDefinition' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    Location: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L3647


    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L2373
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L2637
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L3541
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L3627
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L4143
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L4595
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L4831
    ⚠️ R2017 - PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Skus_CreateOrUpdate' Request Model: 'ResourceTypeSku' Response Model: 'SkuResource'
    Location: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L1326
    ⚠️ R2017 - PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Skus_CreateOrUpdateNestedResourceTypeFirst' Request Model: 'ResourceTypeSku' Response Model: 'SkuResource'
    Location: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L1478
    ⚠️ R2017 - PutRequestResponseScheme A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Skus_CreateOrUpdateNestedResourceTypeSecond' Request Model: 'ResourceTypeSku' Response Model: 'SkuResource'
    Location: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L1639
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 14 Errors, 8 Warnings failed [Detail]
    The following breaking changes are detected by comparison with the latest stable version:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'contents' renamed or removed?
    New: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L3860:7
    Old: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L3587:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'name' renamed or removed?
    Old: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L3530:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'isDataAction' renamed or removed?
    Old: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L3530:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'origin' renamed or removed?
    Old: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L3530:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'display' renamed or removed?
    Old: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L3530:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'actionType' renamed or removed?
    Old: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L3530:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'properties' renamed or removed?
    Old: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L3530:7
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L789:13
    Old: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L789:13
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L806:13
    Old: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L806:13
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L3861:9
    Old: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L3574:9


    The following breaking changes are detected by comparison with latest preview version:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'contents' renamed or removed?
    New: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L3860:7
    Old: Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#L3594:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'name' renamed or removed?
    Old: Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#L3537:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'isDataAction' renamed or removed?
    Old: Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#L3537:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'origin' renamed or removed?
    Old: Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#L3537:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'display' renamed or removed?
    Old: Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#L3537:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'actionType' renamed or removed?
    Old: Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#L3537:7
    ❌ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'properties' renamed or removed?
    Old: Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#L3537:7
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L789:13
    Old: Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#L789:13
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L806:13
    Old: Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#L806:13
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#L3861:9
    Old: Microsoft.ProviderHub/preview/2021-05-01-preview/providerhub.json#L3581:9
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️❌[Staging] SDK Track2 Validation: 1 Errors, 6 Warnings failed [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ❌ AutorestCore/Exception "readme":"providerhub/resource-manager/readme.md",
    "tag":"package-2021-06-01-preview",
    "details":"Error: Plugin pre-namer reported failure."
    ⚠️ Modeler/MissingType "readme":"providerhub/resource-manager/readme.md",
    "tag":"package-2021-06-01-preview",
    "details":"The schema 'ResourceProviderManagement-resourceAccessRolesItem' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#/components/schemas/ResourceProviderManagement-resourceAccessRolesItem"
    ⚠️ Modeler/MissingType "readme":"providerhub/resource-manager/readme.md",
    "tag":"package-2021-06-01-preview",
    "details":"The schema 'ResourceProviderManifestProperties-metadata' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#/components/schemas/ResourceProviderManifestProperties-metadata"
    ⚠️ Modeler/MissingType "readme":"providerhub/resource-manager/readme.md",
    "tag":"package-2021-06-01-preview",
    "details":"The schema 'ResourceType-metadata' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#/components/schemas/ResourceType-metadata"
    ⚠️ Modeler/MissingType "readme":"providerhub/resource-manager/readme.md",
    "tag":"package-2021-06-01-preview",
    "details":"The schema 'ResourceProviderManifest-metadata' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#/components/schemas/ResourceProviderManifest-metadata"
    ⚠️ Modeler/MissingType "readme":"providerhub/resource-manager/readme.md",
    "tag":"package-2021-06-01-preview",
    "details":"The schema 'OperationsDefinition-properties' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#/components/schemas/OperationsDefinition-properties"
    ⚠️ Modeler/MissingType "readme":"providerhub/resource-manager/readme.md",
    "tag":"package-2021-06-01-preview",
    "details":"The schema 'LocalizedOperationDefinition-properties' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json#/components/schemas/LocalizedOperationDefinition-properties"
    💬 AutorestCore/Exception "readme":"providerhub/resource-manager/readme.md",
    "tag":"package-2021-06-01-preview",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"
    💬 AutorestCore/Exception "readme":"providerhub/resource-manager/readme.md",
    "tag":"package-2021-06-01-preview",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"
    💬 AutorestCore/Exception "readme":"providerhub/resource-manager/readme.md",
    "tag":"package-2021-06-01-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️❌[Staging] Lint(RPaaS): 2 Errors, 0 Warnings failed [Detail]
    Rule Message
    ❌ R4031 - Rpaas_ResourceProvisioningState [RPaaS] The resource NotificationRegistration is defined without 'provisioningState' in properties bag, consider adding the provisioningState for it.
    Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L3467
    ❌ R4031 - Rpaas_ResourceProvisioningState [RPaaS] The resource SkuResource is defined without 'provisioningState' in properties bag, consider adding the provisioningState for it.
    Location: Microsoft.ProviderHub/stable/2020-11-20/providerhub.json#L4532
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 2, 2021 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go - providerhub/mgmt/2020-11-20/providerhub - v55.3.0
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c45182f. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
warn	No package detected after generation
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c45182f. SDK Automation 14.0.0 
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-07-14 01:50:29 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-providerhub"
cmderr	[generate.py] 2021-07-14 01:50:29 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-07-14 01:50:29 INFO autorest --version=3.1.3 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/providerhub/azure-resourcemanager-providerhub --java.namespace=com.azure.resourcemanager.providerhub   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/providerhub/resource-manager/readme.md
cmderr	[generate.py] 2021-07-14 01:51:04 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-07-14 01:51:04 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-07-14 01:51:04 INFO [POM][Skip] pom already has module azure-resourcemanager-providerhub
cmderr	[generate.py] 2021-07-14 01:51:04 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-07-14 01:51:04 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-07-14 01:51:04 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-providerhub [View full logs]  [Release SDK Changes] 
      cmderr	[Inst] 2021-07-14 01:52:43 DEBUG Got artifact_id: azure-resourcemanager-providerhub
cmderr	[Inst] 2021-07-14 01:52:43 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-07-14 01:52:43 DEBUG Got artifact: azure-resourcemanager-providerhub-1.0.0-beta.1.jar
cmderr	[Inst] 2021-07-14 01:52:43 DEBUG Match jar package: azure-resourcemanager-providerhub-1.0.0-beta.1.jar
cmderr	[Inst] 2021-07-14 01:52:43 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14650/azure-sdk-for-java/azure-resourcemanager-providerhub/azure-resourcemanager-providerhub-1.0.0-beta.1.jar\" -o azure-resourcemanager-providerhub-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-providerhub -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-providerhub-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c45182f. SDK Automation 14.0.0 
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️providerhub/mgmt/2020-11-20/providerhub [View full logs]  [Release SDK Changes] 
      info	[Changelog] This is a new package
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c45182f. SDK Automation 14.0.0 
      warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/providerhub/resource-manager/readme.md
warn	No file changes detected after generation
warn	No package detected after generation
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    This was referenced Jun 2, 2021
    Closed
    Closed
    @diwudd diwudd marked this pull request as ready for review June 3, 2021 18:18
    @sanjaiganesh
    Copy link
    Contributor 

    "/subscriptions/{subscriptionId}/providers/Microsoft.ProviderHub/providerRegistrations/{providerNamespace}/resourceActions/{resourceActionName}/getResource": {

    /listResources ?

    Refers to: specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json:2139 in c079edd. [](commit_id = c079edd, deletion_comment = False)

    @sanjaiganesh
    Copy link
    Contributor

    sanjaiganesh commented Jun 3, 2021 •
    edited
    Loading 

    "/subscriptions/{subscriptionId}/providers/Microsoft.ProviderHub/providerRegistrations/{providerNamespace}/resourceActions/{resourceActionName}/getResource": {

    /resourceOperations/default/getResource?

    In reply to: 854133036

    Refers to: specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json:2139 in 925a247. [](commit_id = 925a247, deletion_comment = False)

    @sanjaiganesh
    Copy link
    Contributor 

    "/subscriptions/{subscriptionId}/providers/Microsoft.ProviderHub/providerRegistrations/{providerNamespace}/resourceActions/{resourceActionName}/getResources": {

    /resourceOperations/default/listResources?

    Refers to: specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json:2194 in c079edd. [](commit_id = c079edd, deletion_comment = False)

    @sanjaiganesh
    Copy link
    Contributor 

    "/subscriptions/{subscriptionId}/providers/Microsoft.ProviderHub/providerRegistrations/{providerNamespace}/resourceActions/{resourceActionName}/getResources": {

    remove {resourceActionName} parameter

    In reply to: 854261751

    Refers to: specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json:2194 in 925a247. [](commit_id = 925a247, deletion_comment = False)

    @sanjaiganesh
    Copy link
    Contributor 

              "$ref": "#/definitions/ResourceManagementEntity"

    Take a different payload for list call, including OData filter that current LIST call for cross partition query takes.

    Refers to: specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json:2219 in c079edd. [](commit_id = c079edd, deletion_comment = False)

    @sanjaiganesh
    Copy link
    Contributor 

              "$ref": "#/definitions/ResourceManagementEntity"

    check ARG list call that is similar to this.
    $ref": "#/definitions/QueryRequest"

    POST providers/Microsoft.ResourceGraph/resources

    In reply to: 854262122

    Refers to: specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json:2219 in 925a247. [](commit_id = 925a247, deletion_comment = False)

    @sanjaiganesh
    Copy link
    Contributor 

    "/subscriptions/{subscriptionId}/providers/Microsoft.ProviderHub/providerRegistrations/{providerNamespace}/resourceActions/{resourceActionName}/getResources": {

    consdier moving under /ResourceTypeRegistrations/ as John suggested, as it will allow ARM to RBAC the user based on the Role. This is useful with multi-registration model

    Refers to: specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json:2194 in c079edd. [](commit_id = c079edd, deletion_comment = False)

    @sanjaiganesh
    Copy link
    Contributor 

          }

    I suppose cascade deletion implicit here.

    Refers to: specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json:5000 in c079edd. [](commit_id = c079edd, deletion_comment = False)

    @sanjaiganesh
    Copy link
    Contributor 

              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ProxyResource"

    it could be tracked resource as well.

    Refers to: specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json:2176 in c079edd. [](commit_id = c079edd, deletion_comment = False)

    @sanjaiganesh
    Copy link
    Contributor 

              "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ProxyResource"

    use TrackedResource definition, unless it has location as required property in the v2 definition

    In reply to: 854264300

    Refers to: specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json:2176 in 925a247. [](commit_id = 925a247, deletion_comment = False)

    @sanjaiganesh
    Copy link
    Contributor

    sanjaiganesh commented Jun 4, 2021 •
    edited
    Loading 

        "x-ms-long-running-operation": false

    nit - remove.

    Refers to: specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json:2191 in 925a247. [](commit_id = 925a247, deletion_comment = False)

    @sanjaiganesh
    Copy link
    Contributor 

        "x-ms-long-running-operation": false

    nit - remove

    Refers to: specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json:2246 in c079edd. [](commit_id = c079edd, deletion_comment = False)

    @sanjaiganesh
    Copy link
    Contributor 

            }

    no response body for 202

    Refers to: specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json:2287 in c079edd. [](commit_id = c079edd, deletion_comment = False)

    @sanjaiganesh
    Copy link
    Contributor 

          "202": {

    is it always async ?

    Refers to: specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json:2283 in c079edd. [](commit_id = c079edd, deletion_comment = False)

    @sanjaiganesh
    Copy link
    Contributor 

              "$ref": "#/definitions/ResourceManagementAction"

    should this take a an option to invoke UserRP extensions ?
    Since UserRP may have buisiness logic that they would like to invoke

    Refers to: specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json:2274 in c079edd. [](commit_id = c079edd, deletion_comment = False)

    @sanjaiganesh
    Copy link
    Contributor 

            "$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/ProxyResource"

    same here. it may not always be proxy

    Refers to: specification/providerhub/resource-manager/Microsoft.ProviderHub/preview/2021-06-01-preview/providerhub.json:5010 in c079edd. [](commit_id = c079edd, deletion_comment = False)

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 21, 2021
    This was referenced Jun 21, 2021
    Closed
    Closed
    @diwudd
    Copy link
    Contributor Author

    diwudd commented Jun 21, 2021 via email

    @diwudd
    Copy link
    Contributor Author

    diwudd commented Jun 22, 2021 via email

    @ghost
    Copy link

    ghost commented Jul 11, 2021

    Hi, @diwudd. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

    @ghost ghost added the no-recent-activity label Jul 11, 2021
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jul 12, 2021
    @diwudd
    Copy link
    Contributor Author

    diwudd commented Jul 12, 2021 via email

    @weidongxu-microsoft
    Copy link
    Member

    You need to pass ARM review.

    @diwudd
    Copy link
    Contributor Author

    diwudd commented Jul 13, 2021 via email

    @RamyasreeChakka RamyasreeChakka added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 13, 2021
    @RamyasreeChakka
    Copy link
    Member

    @diwudd - Changed LGTM. Signed off from ARM side.

    @diwudd
    Copy link
    Contributor Author

    diwudd commented Jul 13, 2021 via email

    @RamyasreeChakka
    Copy link
    Member

    @diwudd Di Wu FTE - Changed LGTM. Signed off from ARM side.

    @diwudd - Please work with your PR assignee for merge. I don't have permissions.

    @diwudd
    Copy link
    Contributor Author

    diwudd commented Jul 13, 2021 via email

    @weidongxu-microsoft weidongxu-microsoft merged commit c45182f into Azure:master Jul 14, 2021
    This was referenced Jul 14, 2021
    Closed
    Closed
    Closed
    @laxmankumar12 laxmankumar12 mentioned this pull request Jul 15, 2021
    Merged
    26 tasks
    @hjhhh3000vitae hjhhh3000vitae mentioned this pull request Sep 1, 2021
    Merged
    25 tasks
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

    +1 more reviewer

    @RamyasreeChakka RamyasreeChakka RamyasreeChakka left review comments

    Reviewers whose approvals may not affect merge requirements
    Assignees

    @weidongxu-microsoft weidongxu-microsoft

    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @diwudd @sanjaiganesh @weidongxu-microsoft @RamyasreeChakka @JeffreyRichter @shenshengkafei