Skip to content

[DataFactory] GitHub bring your own app swagger update for ADF/Synapse ARM only #14690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 29, 2021
Merged

[DataFactory] GitHub bring your own app swagger update for ADF/Synapse ARM only #14690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
81bf882
consolidate github byoa changes to one commit
jmcallister-msft Jul 19, 2021
43cbce4
consolidate BYOA commits to one
jmcallister-msft Jul 28, 2021
bc7bc8f
Revert "consolidate BYOA commits to one"
jmcallister-msft Jul 28, 2021
bd07eb8
Merge branch 'master' of https://github.com/jmcallister-msft/azure-re…
jmcallister-msft Jul 28, 2021
12a6f75
remove duplicate client secret
jmcallister-msft Jul 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...ion/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5012,6 +5012,14 @@
"hostName": {
"description": "GitHub Enterprise host name. For example: https://github.mydomain.com",
"type": "string"
},
"clientId": {
"description": "GitHub bring your own app client id.",
"type": "string"
},
"clientSecret": {
"$ref": "#/definitions/GitHubClientSecret",
"description": "GitHub bring your own app client secret information."
}
}
},
Expand Down
22 changes: 22 additions & 0 deletions ...tion/synapse/resource-manager/Microsoft.Synapse/preview/2019-06-01-preview/workspace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1050,6 +1050,20 @@
}
}
},
"GitHubClientSecret": {
"description": "Client secret information for factory's bring your own app repository configuration",
"type": "object",
"properties": {
"byoaSecretAkvUrl": {
"description": "Bring your own app client secret AKV URL",
"type": "string"
},
"byoaSecretName": {
"description": "Bring your own app client secret name in AKV",
"type": "string"
}
}
},
"WorkspaceRepositoryConfiguration": {
"description": "Git integration settings",
"type": "object",
Expand Down Expand Up @@ -1090,6 +1104,14 @@
"description": "The VSTS tenant ID",
"type": "string",
"format": "uuid"
},
"clientId": {
"description": "GitHub bring your own app client id",
"type": "string"
},
"clientSecret": {
"$ref": "#/definitions/GitHubClientSecret",
"description": "GitHub bring your own app client secret information."
}
}
},
Expand Down