Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
7e0f275
Add June21 Swagger Api version, Updated Readme files
HimanshuChhabra Aug 12, 2021
bcc34d8
adding abort and hnson migration swagger API
HimanshuChhabra Aug 12, 2021
cd00304
swagger: marking requesttype as required parameter for hns onmigration
HimanshuChhabra Aug 12, 2021
0e97cb8
Added new PublicNetworkAccess property to swagger spec
HimanshuChhabra Aug 12, 2021
8f56578
Add enableNfsV3RootSquash and enableNfsV3AllSquash to June21 swagger
HimanshuChhabra Aug 12, 2021
6de3994
Add Account Level VLW Swagger changes and example
HimanshuChhabra Aug 12, 2021
f1badd9
Update Blob Inventory Api comment to include AccessTierInferred and Tags
HimanshuChhabra Aug 12, 2021
b4148fa
Rename HnsOn to hierarchical namespace
HimanshuChhabra Aug 12, 2021
847c109
[Swagger] [June21] Added defaultToOAuthAuthentication to swagger spec
HimanshuChhabra Aug 12, 2021
25376ca
Update Spell check custom words list. Correct incorrect spellings
HimanshuChhabra Aug 12, 2021
fc726c4
Add missing refrences to PublicNetworkAccess Examples
HimanshuChhabra Aug 12, 2021
7adc973
Add required type:object, Add default return type for hns migration apis
HimanshuChhabra Aug 12, 2021
e9c931c
Prettier tool update to storage.json
HimanshuChhabra Aug 12, 2021
c2d7d76
Add update account with immutability policy example
HimanshuChhabra Aug 12, 2021
e45d622
Merge branch 'main' into june21swagger2
HimanshuChhabra Aug 27, 2021
9ea84fe
Removed StorageFileDataSmbShareOwner as Server side does not support it
HimanshuChhabra Aug 27, 2021
b0b8143
Merge branch 'june21swagger2' of https://github.com/HimanshuChhabra/a…
HimanshuChhabra Aug 27, 2021
c9e2ce7
Add AllowProtectedAppendWritesAll feature changes with example
HimanshuChhabra Sep 8, 2021
b5d8fa3
Updated enum values and description for PublicNetworkAccess
HimanshuChhabra Sep 9, 2021
6755cb0
Merge branch 'main' into june21swagger2
HimanshuChhabra Sep 9, 2021
445fc20
Add type:object to ProtectedAppendWritesHistory ; Spellcheck
HimanshuChhabra Sep 14, 2021
68fb003
Merge branch 'june21swagger2' of https://github.com/HimanshuChhabra/a…
HimanshuChhabra Sep 14, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,9 @@
"x-ms-examples": {
"GetContainers": {
"$ref": "./examples/BlobContainersGet.json"
},
"GetBlobContainersGetWithAllowProtectedAppendWritesAll": {
"$ref": "./examples/BlobContainersGetWithAllowProtectedAppendWritesAll.json"
}
},
"description": "Gets properties of a specified container. ",
Expand Down Expand Up @@ -401,6 +404,9 @@
"x-ms-examples": {
"SetLegalHoldContainers": {
"$ref": "./examples/BlobContainersSetLegalHold.json"
},
"SetLegalHoldContainersWithAllowProtectedAppendWritesAll": {
"$ref": "./examples/BlobContainersSetLegalHoldAllowProtectedAppendWritesAll.json"
}
},
"description": "Sets legal hold tags. Setting the same tag results in an idempotent operation. SetLegalHold follows an append pattern and does not clear out the existing tags that are not specified in the request.",
Expand Down Expand Up @@ -497,6 +503,9 @@
"x-ms-examples": {
"CreateOrUpdateImmutabilityPolicy": {
"$ref": "./examples/BlobContainersPutImmutabilityPolicy.json"
},
"CreateOrUpdateImmutabilityPolicyWithAllowProtectedAppendWritesAll": {
"$ref": "./examples/BlobContainersPutImmutabilityPolicyAllowProtectedAppendWritesAll.json"
}
},
"description": "Creates or updates an unlocked immutability policy. ETag in If-Match is honored if given but not required for this operation.",
Expand Down Expand Up @@ -1042,7 +1051,11 @@
},
"allowProtectedAppendWrites": {
"type": "boolean",
"description": "This property can only be changed for unlocked time-based retention policies. When enabled, new blocks can be written to an append blob while maintaining immutability protection and compliance. Only new blocks can be added and any existing blocks cannot be modified or deleted. This property cannot be changed with ExtendImmutabilityPolicy API"
"description": "This property can only be changed for unlocked time-based retention policies. When enabled, new blocks can be written to an append blob while maintaining immutability protection and compliance. Only new blocks can be added and any existing blocks cannot be modified or deleted. This property cannot be changed with ExtendImmutabilityPolicy API."
},
"allowProtectedAppendWritesAll": {
"type": "boolean",
"description": "This property can only be changed for unlocked time-based retention policies. When enabled, new blocks can be written to both 'Appened and Bock Blobs' while maintaining immutability protection and compliance. Only new blocks can be added and any existing blocks cannot be modified or deleted. This property cannot be changed with ExtendImmutabilityPolicy API. The 'allowProtectedAppendWrites' and 'allowProtectedAppendWritesAll' properties are mutually exclusive."
Copy link
Member

@blueww blueww Sep 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Optional ) We should change the "name": "parameters", to "name": "immutabilityPolicy", on line 532 and 750 in blob.json.

Not sure if ARM team will have concern for this change as it's breaking, but if not change, the API parameter name looks not right.

If not change, the generated SDK will has the parameter name for input immutabilityPolicy as "parameters", which doesn't make sense.
Before adding "allowProtectedAppendWritesAll", this issue not appear in SDK, since immutabilityPolicy only has 2 properties can be input (immutabilityPeriodSinceCreationInDays, allowProtectedAppendWrites), the Set/extend immutabilityPolicy API will have the 2 immutabilityPolicy properties just as the API paramters (see link); but after adding one more property "allowProtectedAppendWritesAll", the Set/extend immutabilityPolicy API will have the whole immutabilityPolicy as parameter, and the API to create immutabilityPolicy object has wrong parameter name (use name "parameters" for immutabilityPolicy parameter ).

The .net SDK API with current swagger (See "ImmutabilityPolicy parameters = default(ImmutabilityPolicy) ")

public static ImmutabilityPolicy CreateOrUpdateImmutabilityPolicy(this IBlobContainersOperations operations, string resourceGroupName, string accountName, string containerName, ImmutabilityPolicy parameters = default(ImmutabilityPolicy), string ifMatch = default(string))

The .net SDK API after change "name": "parameters", to "name": "immutabilityPolicy" in swagger: (See "ImmutabilityPolicy immutabilityPolicy = default(ImmutabilityPolicy)")

public static ImmutabilityPolicy CreateOrUpdateImmutabilityPolicy(this IBlobContainersOperations operations, string resourceGroupName, string accountName, string containerName, ImmutabilityPolicy immutabilityPolicy = default(ImmutabilityPolicy), string ifMatch = default(string))

}
},
"description": "The properties of an ImmutabilityPolicy of a blob container."
Expand Down Expand Up @@ -1157,6 +1170,14 @@
"type": "string",
"readOnly": true,
"description": "Returns the User Principal Name of the user who updated the ImmutabilityPolicy."
},
"allowProtectedAppendWrites": {
"type": "boolean",
"description": "This property can only be changed for unlocked time-based retention policies. When enabled, new blocks can be written to an append blob while maintaining immutability protection and compliance. Only new blocks can be added and any existing blocks cannot be modified or deleted. This property cannot be changed with ExtendImmutabilityPolicy API."
},
"allowProtectedAppendWritesAll": {
"type": "boolean",
"description": "This property can only be changed for unlocked time-based retention policies. When enabled, new blocks can be written to both 'Appened and Bock Blobs' while maintaining immutability protection and compliance. Only new blocks can be added and any existing blocks cannot be modified or deleted. This property cannot be changed with ExtendImmutabilityPolicy API. The 'allowProtectedAppendWrites' and 'allowProtectedAppendWritesAll' properties are mutually exclusive."
}
},
"description": "An update history of the ImmutabilityPolicy of a blob container."
Expand All @@ -1174,6 +1195,11 @@
"$ref": "#/definitions/TagProperty"
},
"description": "The list of LegalHold tags of a blob container."
},
"protectedAppendWritesHistory": {
"type": "object",
"$ref": "#/definitions/ProtectedAppendWritesHistory",
"description": "Protected append blob writes history."
}
},
"description": "The LegalHold property of a blob container."
Expand Down Expand Up @@ -1209,6 +1235,21 @@
},
"description": "A tag of the LegalHold of a blob container."
},
"ProtectedAppendWritesHistory": {
"properties": {
"allowProtectedAppendWritesAll": {
"type": "boolean",
"description": "When enabled, new blocks can be written to both 'Appened and Bock Blobs' while maintaining legal hold protection and compliance. Only new blocks can be added and any existing blocks cannot be modified or deleted."
},
"timestamp": {
"type": "string",
"format": "date-time",
"readOnly": true,
"description": "Returns the date and time the tag was added."
}
},
"description": "Protected append writes history setting for the blob container with Legal holds."
},
"LegalHold": {
"properties": {
"hasLegalHold": {
Expand All @@ -1224,6 +1265,10 @@
"minLength": 3
},
"description": "Each tag should be 3 to 23 alphanumeric characters and is normalized to lower case at SRP."
},
"allowProtectedAppendWritesAll": {
"type": "boolean",
"description": "When enabled, new blocks can be written to both 'Appened and Bock Blobs' while maintaining legal hold protection and compliance. Only new blocks can be added and any existing blocks cannot be modified or deleted."
}
},
"required": [
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
{
"parameters": {
"subscriptionId": "{subscription-id}",
"resourceGroupName": "res9871",
"accountName": "sto6217",
"containerName": "container1634",
"api-version": "2021-06-01",
"monitor": "true"
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/{subscription-id}/resourceGroups/res9871/providers/Microsoft.Storage/storageAccounts/sto6217/blobServices/default/containers/container1634",
"name": "container1634",
"type": "Microsoft.Storage/storageAccounts/blobServices/containers",
"etag": "\"0x8D592D74CC20EBA\"",
"properties": {
"publicAccess": "None",
"leaseStatus": "Unlocked",
"leaseState": "Available",
"lastModifiedTime": "2018-03-26T05:06:14Z",
"immutabilityPolicy": {
"etag": "\"8d592d74cb3011a\"",
"properties": {
"immutabilityPeriodSinceCreationInDays": 100,
"allowProtectedAppendWritesAll": true,
"state": "Locked"
},
"updateHistory": [
{
"update": "put",
"immutabilityPeriodSinceCreationInDays": 3,
"allowProtectedAppendWritesAll": true,
"timestamp": "2018-03-26T05:06:11.431403Z",
"objectIdentifier": "ce7cd28a-fc25-4bf1-8fb9-e1b9833ffd4b",
"tenantId": "72f988bf-86f1-41af-91ab-2d7cd011db47"
},
{
"update": "lock",
"immutabilityPeriodSinceCreationInDays": 3,
"allowProtectedAppendWritesAll": true,
"timestamp": "2018-03-26T05:06:13.0907641Z",
"objectIdentifier": "ce7cd28a-fc25-4bf1-8fb9-e1b9833ffd4b",
"tenantId": "72f988bf-86f1-41af-91ab-2d7cd011db47"
},
{
"update": "extend",
"immutabilityPeriodSinceCreationInDays": 100,
"allowProtectedAppendWritesAll": true,
"timestamp": "2018-03-26T05:06:14.7097716Z",
"objectIdentifier": "ce7cd28a-fc25-4bf1-8fb9-e1b9833ffd4b",
"tenantId": "72f988bf-86f1-41af-91ab-2d7cd011db47"
}
]
},
"legalHold": {
"hasLegalHold": true,
"protectedAppendWritesHistory": {
"allowProtectedAppendWritesAll": true,
"timestamp": "2021-09-01T01:58:44.5044483Z"
},
"tags": [
{
"tag": "tag1",
"timestamp": "2018-03-26T05:06:09.6964643Z",
"objectIdentifier": "ce7cd28a-fc25-4bf1-8fb9-e1b9833ffd4b",
"tenantId": "72f988bf-86f1-41af-91ab-2d7cd011db47"
},
{
"tag": "tag2",
"timestamp": "2018-03-26T05:06:09.6964643Z",
"objectIdentifier": "ce7cd28a-fc25-4bf1-8fb9-e1b9833ffd4b",
"tenantId": "72f988bf-86f1-41af-91ab-2d7cd011db47"
},
{
"tag": "tag3",
"timestamp": "2018-03-26T05:06:09.6964643Z",
"objectIdentifier": "ce7cd28a-fc25-4bf1-8fb9-e1b9833ffd4b",
"tenantId": "72f988bf-86f1-41af-91ab-2d7cd011db47"
}
]
},
"hasImmutabilityPolicy": true,
"hasLegalHold": true
}
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
{
"parameters": {
"subscriptionId": "{subscription-id}",
"resourceGroupName": "res1782",
"accountName": "sto7069",
"containerName": "container6397",
"immutabilityPolicyName": "default",
"api-version": "2021-06-01",
"monitor": "true",
"parameters": {
"properties": {
"immutabilityPeriodSinceCreationInDays": 3,
"allowProtectedAppendWritesAll": true
}
}
},
"responses": {
"200": {
"body": {
"id": "/subscriptions/{subscription-id}/resourceGroups/res1782/providers/Microsoft.Storage/storageAccounts/sto7069/blobServices/default/containers/container6397/immutabilityPolicies/default",
"name": "default",
"type": "Microsoft.Storage/storageAccounts/blobServices/containers/immutabilityPolicies",
"etag": "\"8d59f830cb130e5\"",
"properties": {
"immutabilityPeriodSinceCreationInDays": 3,
"allowProtectedAppendWritesAll": true,
"state": "Unlocked"
}
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
{
"parameters": {
"subscriptionId": "{subscription-id}",
"resourceGroupName": "res4303",
"accountName": "sto7280",
"containerName": "container8723",
"api-version": "2021-06-01",
"monitor": "true",
"LegalHold": {
"tags": [
"tag1",
"tag2",
"tag3"
],
"allowProtectedAppendWritesAll": true
}
},
"responses": {
"200": {
"body": {
"hasLegalHold": true,
"tags": [
"tag1",
"tag2",
"tag3"
],
"allowProtectedAppendWritesAll": true
}
}
}
}