[Hub Generated] Review request for Microsoft.CostManagement to add version stable/2021-10-01 #15953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…021-01-01 to version 2021-10-01
…rs.apiVersionParameter.description' has incompatible values - apiVersionParamaDecrip should be same for all the json files
|
Hi, @mitagarg Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
|
|
|
Hi @mitagarg, Your PR has some issues. Please fix the CI sequentially by following the order of
|
added 5 commits
September 7, 2021 23:16
handeeeadiguzel
suggested changes
Sep 10, 2021
...t-management/resource-manager/Microsoft.CostManagement/stable/2021-10-01/costmanagement.json
Show resolved
Hide resolved
handeeeadiguzel
approved these changes
Sep 13, 2021
mitagarg
removed
the
NotReadyForReview
JeffreyRichter
added
the
Approved-BreakingChange
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
basma-msft
approved these changes
Sep 22, 2021
JeffreyRichter
removed
the
Approved-BreakingChange
|
approve for python breaking change. |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @mitagarg your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
|
Turns out this isn't actually an API change, just a consolidation of existing API versions into one new API version, so ARM signoff isn't needed. Removed the WaitForARMFeedback label accordingly. |
mentat9
removed
the
WaitForARMFeedback
ArcturusZhang
approved these changes
Sep 28, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Oct 1, 2021
jovannikolov-msft
pushed a commit
to jovannikolov-msft/azure-rest-api-specs
that referenced
this pull request
Dec 1, 2021
…rsion stable/2021-10-01 (Azure#15953) * Adds base for updating Microsoft.CostManagement from version stable/2021-01-01 to version 2021-10-01 * Updates readme * Updates API version in new specs and examples * Added costmanagement.json, examples from 2020-06-01, chnaged readme.md for 2021-10-01 * 1: Deprecate expand forf Dimension 2: Fix linter exception: .parameters.apiVersionParameter.description' has incompatible values - apiVersionParamaDecrip should be same for all the json files * supress r4011, r3023, r4018 * supress R4011, R3023, R4018 * Supress R3018 - EnumInsteadOfBoolean * Linter Warning: UniqueXmsExample * Linter - Fixing - Missing Description/Title * Supress R4037 and R4009 * Linter - Fix MisingTypeObject for exports and costmanagement * removed R3023 from costmanagement.generatedetailedcostreport.json from redme.md file * Added type:object for autorest exception and added back the supress R3023 * MissingTypeObject ForecastDataSet for costmanagement * removed R4011, R3023, R4018 * added back R4011, R3023, R4018 * updating the version in the examples * removing exampls with expand * adding the expand chnage and examples back in, as this was breaking chnage Co-authored-by: Mita Garg <[email protected]>
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
…rsion stable/2021-10-01 (Azure#15953) * Adds base for updating Microsoft.CostManagement from version stable/2021-01-01 to version 2021-10-01 * Updates readme * Updates API version in new specs and examples * Added costmanagement.json, examples from 2020-06-01, chnaged readme.md for 2021-10-01 * 1: Deprecate expand forf Dimension 2: Fix linter exception: .parameters.apiVersionParameter.description' has incompatible values - apiVersionParamaDecrip should be same for all the json files * supress r4011, r3023, r4018 * supress R4011, R3023, R4018 * Supress R3018 - EnumInsteadOfBoolean * Linter Warning: UniqueXmsExample * Linter - Fixing - Missing Description/Title * Supress R4037 and R4009 * Linter - Fix MisingTypeObject for exports and costmanagement * removed R3023 from costmanagement.generatedetailedcostreport.json from redme.md file * Added type:object for autorest exception and added back the supress R3023 * MissingTypeObject ForecastDataSet for costmanagement * removed R4011, R3023, R4018 * added back R4011, R3023, R4018 * updating the version in the examples * removing exampls with expand * adding the expand chnage and examples back in, as this was breaking chnage Co-authored-by: Mita Garg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.