Skip to content

[NetAppFiles] Apply s360 fix to operations result #16270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 1, 2021
Merged

[NetAppFiles] Apply s360 fix to operations result #16270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
be9a9cd
Apply s360 fix to operations resutl
audunn Oct 4, 2021
2ff0405
Fix apiversion in example
audunn Oct 5, 2021
7ad9b29
Fix validation warning and errors
audunn Oct 5, 2021
7a92c23
Add missing encryptDCConnections propety to AcitiveDirectory
audunn Oct 6, 2021
295bb9f
fix api version
audunn Oct 6, 2021
ba040aa
fix througntputmips
audunn Oct 8, 2021
8074a1b
Clarify description throughputMibps
audunn Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../netapp/resource-manager/Microsoft.NetApp/stable/2021-04-01/examples/Accounts_Update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"subscriptionId": "D633CC2E-722B-4AE1-B636-BBD9E4C60ED9",
"resourceGroupName": "myRG",
"accountName": "account1",
"api-version": "2020-11-01",
"api-version": "2021-04-01",
"body": {
"tags": {
"Tag1": "Value1"
Expand Down
31 changes: 30 additions & 1 deletion specification/netapp/resource-manager/Microsoft.NetApp/stable/2021-04-01/netapp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2836,6 +2836,13 @@
"items": {
"$ref": "#/definitions/MetricSpecification"
}
},
"logSpecifications": {
"description": "Log specification of operation.",
"type": "array",
"items": {
"$ref": "#/definitions/LogSpecification"
}
}
}
},
Expand Down Expand Up @@ -2884,6 +2891,10 @@
"type": "string",
"description": "The internal metric name."
},
"enableRegionalMdmAccount": {
"description": "Whether or not the service is using regional MDM accounts.",
"type": "boolean"
},
"sourceMdmAccount": {
"type": "string",
"description": "The source MDM account."
Expand Down Expand Up @@ -2914,6 +2925,24 @@
"resourceIdDimensionNameOverride": {
"type": "string",
"description": "Account Resource Id."
},
"isInternal": {
"description": "Whether the metric is internal.",
"type": "boolean"
}
}
},
"LogSpecification": {
"description": "Log Definition of a single resource metric.",
"type": "object",
"properties": {
"name": {
"description": "Name of log specification.",
"type": "string"
},
"displayName": {
"description": "Display name of log specification.",
"type": "string"
}
}
},
Expand Down Expand Up @@ -3846,7 +3875,7 @@
},
"volumeType": {
"type": "string",
"description": "What type of volume is this",
"description": "What type of volume is this. For destination volumes in Cross Region Replication, set type to DataProtection",
"example": "DataProtection"
},
"dataProtection": {
Expand Down
2 changes: 1 addition & 1 deletion .../netapp/resource-manager/Microsoft.NetApp/stable/2021-06-01/examples/Accounts_Update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"subscriptionId": "D633CC2E-722B-4AE1-B636-BBD9E4C60ED9",
"resourceGroupName": "myRG",
"accountName": "account1",
"api-version": "2020-11-01",
"api-version": "2021-06-01",
"body": {
"tags": {
"Tag1": "Value1"
Expand Down
20 changes: 7 additions & 13 deletions specification/netapp/resource-manager/Microsoft.NetApp/stable/2021-06-01/netapp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2918,6 +2918,7 @@
}
},
"logSpecifications": {
"description": "Log specification of operation.",
"type": "array",
"items": {
"$ref": "#/definitions/LogSpecification"
Expand Down Expand Up @@ -3016,9 +3017,11 @@
"type": "object",
"properties": {
"name": {
"description": "Name of log specification.",
"type": "string"
},
"displayName": {
"description": "Display name of log specification.",
"type": "string"
}
}
Expand Down Expand Up @@ -3184,11 +3187,6 @@
"description": "SubscriptionQuotaItem Properties",
"type": "object",
"properties": {
"name": {
"type": "string",
"readOnly": true,
"description": "Quota Item name"
},
"current": {
"description": "The current quota value.",
"readOnly": true,
Expand Down Expand Up @@ -4089,12 +4087,10 @@
"default": false
},
"throughputMibps": {
"title": "Maximum throughput in Mibps that can be achieved by this volume",
"title": "Maximum throughput in Mibps that can be achieved by this volume and this will be accepted as input only for manual qosType volume",
"type": "number",
"default": 0.0,
"example": 128.22,
"maximum": 4500,
"minimum": 0
"example": 128.22
},
"encryptionKeySource": {
"description": "Encryption Key Source. Possible values are: 'Microsoft.NetApp'",
Expand Down Expand Up @@ -4463,11 +4459,9 @@
}
},
"throughputMibps": {
"title": "Maximum throughput in Mibps that can be achieved by this volume",
"title": "Maximum throughput in Mibps that can be achieved by this volume and this will be accepted as input only for manual qosType volume",
"type": "number",
"example": 128.22,
"maximum": 4500,
"minimum": 1
"example": 128.22
},
"dataProtection": {
"title": "DataProtection",
Expand Down