-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Dev powerbidedicated microsoft.power b idedicated 2021 01 01 #16840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev powerbidedicated microsoft.power b idedicated 2021 01 01 #16840
Conversation
Hi, @cfurmanczyk Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L678 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.PowerBIDedicated' doesn't match the namespace. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L40 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.PowerBIDedicated' doesn't match the namespace. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L269 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.PowerBIDedicated' doesn't match the namespace. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L319 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.PowerBIDedicated' doesn't match the namespace. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L369 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.PowerBIDedicated' doesn't match the namespace. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L411 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.PowerBIDedicated' doesn't match the namespace. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L450 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.PowerBIDedicated' doesn't match the namespace. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L483 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.PowerBIDedicated' doesn't match the namespace. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L532 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.PowerBIDedicated' doesn't match the namespace. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L568 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.PowerBIDedicated' doesn't match the namespace. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/autoScaleVCores.json#L40 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.PowerBIDedicated' doesn't match the namespace. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/autoScaleVCores.json#L248 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'Microsoft.PowerBIDedicated' doesn't match the namespace. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/autoScaleVCores.json#L290 |
R4009 - RequiredReadOnlySystemData |
The property systemData in the response of operation:'Capacities_GetDetails' is not read only. Please add the readonly for the systemData. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L41 |
R4009 - RequiredReadOnlySystemData |
The property systemData in the response of operation:'AutoScaleVCores_Get' is not read only. Please add the readonly for the systemData. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/autoScaleVCores.json#L41 |
R4009 - RequiredReadOnlySystemData |
The property systemData in the response of operation:'Capacities_Create' is not read only. Please add the readonly for the systemData. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L88 |
R4009 - RequiredReadOnlySystemData |
The property systemData in the response of operation:'AutoScaleVCores_Create' is not read only. Please add the readonly for the systemData. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/autoScaleVCores.json#L88 |
R4009 - RequiredReadOnlySystemData |
The property systemData in the response of operation:'Capacities_Update' is not read only. Please add the readonly for the systemData. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L202 |
R4009 - RequiredReadOnlySystemData |
The property systemData in the response of operation:'AutoScaleVCores_Update' is not read only. Please add the readonly for the systemData. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/autoScaleVCores.json#L191 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.PowerBIDedicated/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L532 |
R4037 - MissingTypeObject |
The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L622 |
R4037 - MissingTypeObject |
The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L649 |
R4037 - MissingTypeObject |
The schema 'error' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L973 |
R4037 - MissingTypeObject |
The schema 'error' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L973 |
Based on the response model schema, operation 'Capacities_ListSkus' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L451 |
|
Based on the response model schema, operation 'Capacities_ListSkusForCapacity' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L484 |
|
Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L1010 |
|
The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L7 |
|
The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation. Location: Microsoft.PowerBIdedicated/stable/2021-01-01/autoScaleVCores.json#L7 |
|
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get details of a capacity Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L153 |
|
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get details of a capacity Location: Microsoft.PowerBIdedicated/stable/2021-01-01/powerbidedicated.json#L322 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
Hi @cfurmanczyk, Your PR has some issues. Please fix the CI sequentially by following the order of
|
NewApiVersionRequired reason: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved from ARM side.
@cfurmanczyk , please fix ModelValidation failures. @ArcturusZhang , can you have a look at the potential breaking change to GO SDK? |
@raych1 ModelValidation failures fixed. |
…dedicated 2021 01 01 (#2168) Create to sync Azure/azure-rest-api-specs#16840 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/powerbidedicated?expand=1)
…6840) * Apply PowerBIDedicated correctness fixes to 2021-01-01 * Move PowerBIDedicated properties to new definitions * Keep ErrorResponse inline with documented expectation * Update for ModelValidation failures * cleanup operations example
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.