[Hub Generated] Review request for Microsoft.Insights to add version stable/2021-08-01 #17174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @avjerafi Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version has a different format than the previous one. New: Microsoft.Insights/stable/2021-08-01/scheduledQueryRule_API.json#L354:9 Old: Microsoft.Insights/stable/2021-08-01/scheduledQueryRule_API.json#L354:9 |
| The new version has a different type 'integer' than the previous one 'number'. New: Microsoft.Insights/stable/2021-08-01/scheduledQueryRule_API.json#L354:9 Old: Microsoft.Insights/stable/2021-08-01/scheduledQueryRule_API.json#L354:9 |
️⚠️LintDiff: 0 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isLegacyLogAnalyticsRule Location: Microsoft.Insights/stable/2021-08-01/scheduledQueryRule_API.json#L341 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled Location: Microsoft.Insights/stable/2021-08-01/scheduledQueryRule_API.json#L370 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isWorkspaceAlertsStorageConfigured Location: Microsoft.Insights/stable/2021-08-01/scheduledQueryRule_API.json#L417 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: checkWorkspaceAlertsStorageConfigured Location: Microsoft.Insights/stable/2021-08-01/scheduledQueryRule_API.json#L422 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: skipQueryValidation Location: Microsoft.Insights/stable/2021-08-01/scheduledQueryRule_API.json#L426 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: autoMitigate Location: Microsoft.Insights/stable/2021-08-01/scheduledQueryRule_API.json#L430 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/monitor/resource-manager/readme.md tag: specification/monitor/resource-manager/readme.md#tag-package-2021-09 |
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
|
Hi @avjerafi, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Dec 23, 2021
JeffreyRichter
added
the
Approved-BreakingChange
|
Hi, @avjerafi. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
added
|
@ruowan Now that the breaking changes are approved, it is unclear to me what a actions I can/should be taking in order to have this PR approved. The reasons for the remaining failed checks are not clear and I could not find any calls to action. Can you please advise? |
ruowan
approved these changes
Feb 7, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
LGTM. For azure-sdk-for-net you could ignore it. It's an known issue. Ping me to merge if ready. |
|
@ruowan PR is ready to merge. Thanks. |
|
Hi, @avjerafi. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
@ruowan Can you please merge this PR? |
This was referenced Mar 7, 2022
Closed
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Mar 7, 2022
…ghts to add version stable/2021-08-01 (#2237) Create to sync Azure/azure-rest-api-specs#17174 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...AzureSDKAutomation:sdkAuto/monitor?expand=1)
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
Mar 7, 2022
…stable/2021-08-01 (Azure#17174) * Fixed type of Severity * Added missing required x-ms-identifiers in arrays Co-authored-by: Avi Jerafi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.