Skip to content

Correct Probe enums #18839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2022
Merged

Correct Probe enums #18839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
712d116
fix probe enums
vusause Apr 27, 2022
fecc0eb
Fix revision mode enum
vusause May 2, 2022
50cf648
Fix patch example
vusause May 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions ...tion/app/resource-manager/Microsoft.App/preview/2022-01-01-preview/CommonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,15 @@
},
"scheme": {
"description": "Scheme to use for connecting to the host. Defaults to HTTP.",
"type": "string"
"enum": [
"HTTP",
"HTTPS"
],
"type": "string",
"x-ms-enum": {
"name": "Scheme",
"modelAsString": true
}
}
}
},
Expand Down Expand Up @@ -222,9 +230,9 @@
"type": {
"description": "The type of probe.",
"enum": [
"liveness",
"readiness",
"startup"
"Liveness",
"Readiness",
"Startup"
],
"type": "string",
"x-ms-enum": {
Expand Down
4 changes: 2 additions & 2 deletions ...fication/app/resource-manager/Microsoft.App/preview/2022-01-01-preview/ContainerApps.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,8 +427,8 @@
"activeRevisionsMode": {
"description": "ActiveRevisionsMode controls how active revisions are handled for the Container app:\n<list><item>Multiple: multiple revisions can be active. If no value if provided, this is the default</item><item>Single: Only one revision can be active at a time. Revision weights can not be used in this mode</item></list>",
"enum": [
"multiple",
"single"
"Multiple",
"Single"
],
"type": "string",
"x-ms-enum": {
Expand Down
6 changes: 3 additions & 3 deletions ...nager/Microsoft.App/preview/2022-01-01-preview/examples/ContainerApps_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"name": "testcontainerApp0",
"probes": [
{
"type": "liveness",
"type": "Liveness",
"httpGet": {
"path": "/health",
"port": 8080,
Expand Down Expand Up @@ -122,7 +122,7 @@
},
"probes": [
{
"type": "liveness",
"type": "Liveness",
"httpGet": {
"path": "/health",
"port": 8080,
Expand Down Expand Up @@ -192,7 +192,7 @@
},
"probes": [
{
"type": "liveness",
"type": "Liveness",
"httpGet": {
"path": "/health",
"port": 8080,
Expand Down
16 changes: 12 additions & 4 deletions specification/app/resource-manager/Microsoft.App/stable/2022-03-01/CommonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,15 @@
},
"scheme": {
"description": "Scheme to use for connecting to the host. Defaults to HTTP.",
"type": "string"
"enum": [
"HTTP",
"HTTPS"
],
"type": "string",
"x-ms-enum": {
"name": "Scheme",
"modelAsString": true
}
}
}
},
Expand Down Expand Up @@ -222,9 +230,9 @@
"type": {
"description": "The type of probe.",
"enum": [
"liveness",
"readiness",
"startup"
"Liveness",
"Readiness",
"Startup"
],
"type": "string",
"x-ms-enum": {
Expand Down
4 changes: 2 additions & 2 deletions specification/app/resource-manager/Microsoft.App/stable/2022-03-01/ContainerApps.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,8 +425,8 @@
"activeRevisionsMode": {
"description": "ActiveRevisionsMode controls how active revisions are handled for the Container app:\n<list><item>Multiple: multiple revisions can be active.</item><item>Single: Only one revision can be active at a time. Revision weights can not be used in this mode. If no value if provided, this is the default.</item></list>",
"enum": [
"multiple",
"single"
"Multiple",
"Single"
],
"type": "string",
"x-ms-enum": {
Expand Down
6 changes: 3 additions & 3 deletions ...source-manager/Microsoft.App/stable/2022-03-01/examples/ContainerApps_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"name": "testcontainerApp0",
"probes": [
{
"type": "liveness",
"type": "Liveness",
"httpGet": {
"path": "/health",
"port": 8080,
Expand Down Expand Up @@ -140,7 +140,7 @@
},
"probes": [
{
"type": "liveness",
"type": "Liveness",
"httpGet": {
"path": "/health",
"port": 8080,
Expand Down Expand Up @@ -221,7 +221,7 @@
},
"probes": [
{
"type": "liveness",
"type": "Liveness",
"httpGet": {
"path": "/health",
"port": 8080,
Expand Down
2 changes: 1 addition & 1 deletion ...on/app/resource-manager/Microsoft.App/stable/2022-03-01/examples/ContainerApps_Patch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"name": "testcontainerApp0",
"probes": [
{
"type": "liveness",
"type": "Liveness",
"httpGet": {
"path": "/health",
"port": 8080,
Expand Down