Microsoft.DBForPostgreSQL/Flexible servers 2022-01-20-preview #18882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2021-06-01 to version 2022-01-20-preview
|
Hi, @pradeepkintali Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @pradeepkintali your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
pradeepkintali
changed the title
This was referenced May 2, 2022
This was referenced May 2, 2022
DaeunYim
approved these changes
May 3, 2022
Comment on lines
43
to
47
| ### Tag: package-preview-2022-01 | ||
|
|
||
| These settings apply only when `--tag=package-preview-2022-01` is specified on the command line. | ||
|
|
||
| ```yaml $(tag) == 'package-preview-2022-01' |
There was a problem hiding this comment.
Suggested change
| ### Tag: package-preview-2022-01 | |
| These settings apply only when `--tag=package-preview-2022-01` is specified on the command line. | |
| ```yaml $(tag) == 'package-preview-2022-01' | |
| ### Tag: package-flexibleserver-2022-01-preview | |
| These settings apply only when `--tag=package-flexibleserver-2022-01-preview` is specified on the command line. | |
| ```yaml $(tag) == 'package-flexibleserver-2022-01-preview' |
There was a problem hiding this comment.
Adding flexibleserver in the tag name was helpful when releasing multi-api SDKs..
Also, could you add this to python.readme as well?
`### Tag: package-flexibleserver-2022-01-preview and python
These settings apply only when --tag=package-flexibleserver-2022-01-preview --python is specified on the command line.
Please also specify --python-sdks-folder=<path to the root directory of your azure-sdk-for-python clone>.
namespace: azure.mgmt.rdbms.postgresql_flexibleservers
output-folder: $(python-sdks-folder)/rdbms/azure-mgmt-rdbms/azure/mgmt/rdbms/postgresql_flexibleservers
BigCat20196
approved these changes
May 5, 2022
zizw123
reviewed
May 5, 2022
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { |
|
Looks good, one minor comments, non blocking |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@ArcturusZhang Can you take a look at the GO track2 SDK breaking change. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @pradeepkintali, Your PR has some issues. Please fix the CI sequentially by following the order of
|
qiaozha
approved these changes
Jun 8, 2022
This was referenced Jun 8, 2022
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Jun 8, 2022
…2-01-20-preview (#2413) Create to sync Azure/azure-rest-api-specs#18882 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/postgresql?expand=1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[x] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.