Skip to content

Conversation

kjilla03
Copy link
Contributor

@kjilla03 kjilla03 commented May 9, 2022

…gezone

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @kjilla03 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 9, 2022

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    1038 - AddedPath The new version is adding a path that was not found in the old version.
    New: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L668:5
    ️⚠️LintDiff: 6 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:
    Rule Message
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'VirtualMachineImages_ListByEdgeZone' might be pageable. Consider adding the x-ms-pageable extension.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L669
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'VirtualMachineImages_ListByEdgeZone' might be pageable. Consider adding the x-ms-pageable extension.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L669
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'VirtualMachineImages_ListByEdgeZone' might be pageable. Consider adding the x-ms-pageable extension.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L669
    ⚠️ R4014 - AllResourcesMustHaveGetOperation The resource 'VirtualMachineImageResource' does not have get operation, please add it.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L810
    ⚠️ R4014 - AllResourcesMustHaveGetOperation The resource 'VirtualMachineImageResource' does not have get operation, please add it.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L810
    ⚠️ R4014 - AllResourcesMustHaveGetOperation The resource 'VirtualMachineImageResource' does not have get operation, please add it.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L810


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    R4037 - MissingTypeObject The schema 'DisallowedConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L793
    R4037 - MissingTypeObject The schema 'DisallowedConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L793
    R4037 - MissingTypeObject The schema 'DisallowedConfiguration' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L793
    R4037 - MissingTypeObject The schema 'VirtualMachineImageResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L810
    R4037 - MissingTypeObject The schema 'VirtualMachineImageResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L810
    R4037 - MissingTypeObject The schema 'VirtualMachineImageResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L810
    R4037 - MissingTypeObject The schema 'PurchasePlan' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L843
    R4037 - MissingTypeObject The schema 'PurchasePlan' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L843
    R4037 - MissingTypeObject The schema 'PurchasePlan' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L843
    R4037 - MissingTypeObject The schema 'OSDiskImage' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L865
    R4037 - MissingTypeObject The schema 'OSDiskImage' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L865
    R4037 - MissingTypeObject The schema 'OSDiskImage' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L865
    R4037 - MissingTypeObject The schema 'DataDiskImage' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L885
    R4037 - MissingTypeObject The schema 'DataDiskImage' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L885
    R4037 - MissingTypeObject The schema 'DataDiskImage' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L885
    R4037 - MissingTypeObject The schema 'AutomaticOSUpgradeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L896
    R4037 - MissingTypeObject The schema 'AutomaticOSUpgradeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L896
    R4037 - MissingTypeObject The schema 'AutomaticOSUpgradeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L896
    R4037 - MissingTypeObject The schema 'VirtualMachineImageFeature' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L908
    R4037 - MissingTypeObject The schema 'VirtualMachineImageFeature' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L908
    R4037 - MissingTypeObject The schema 'VirtualMachineImageFeature' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L908
    R4037 - MissingTypeObject The schema 'VirtualMachineImageProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L921
    R4037 - MissingTypeObject The schema 'VirtualMachineImageProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L921
    R4037 - MissingTypeObject The schema 'VirtualMachineImageProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L921
    R4037 - MissingTypeObject The schema 'VirtualMachineImage' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L963
    R4037 - MissingTypeObject The schema 'VirtualMachineImage' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L963
    R4037 - MissingTypeObject The schema 'VirtualMachineImage' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L963
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: automaticOSUpgradeSupported
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L898
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: automaticOSUpgradeSupported
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L898
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: automaticOSUpgradeSupported
    Location: stable/2022-03-01/ComputeRP/virtualMachineImage.json#L898
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/compute/resource-manager/readme.md
    tag: specification/compute/resource-manager/readme.md#tag-package-2022-03-02
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️❌PoliCheck: 0 Errors, 0 Warnings failed [Detail]
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 9, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go-track2 - armcompute - 2.0.0
    azure-sdk-for-js - @azure/arm-compute - Approved - 19.0.0
    +	Enum KnownSharingProfileGroupTypes no longer has value Community
    +	Removed Enum KnownGalleryApplicationVersionPropertiesProvisioningState
    +	Removed Enum KnownGalleryImagePropertiesProvisioningState
    +	Removed Enum KnownGalleryImageVersionPropertiesProvisioningState
    +	Removed Enum KnownGalleryPropertiesProvisioningState
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-compute - 27.0.0
    ️✔️azure-sdk-for-go - profiles/2020-09-01/compute/mgmt/compute - v65.0.0
    ️✔️azure-sdk-for-go - containerservice/mgmt/2017-01-31/containerservice - v65.0.0
    ️✔️azure-sdk-for-go - containerservice/mgmt/2016-09-30/containerservice - v65.0.0
    ️✔️azure-sdk-for-go - containerservice/mgmt/2016-03-30/containerservice - v65.0.0
    azure-sdk-for-go - compute/mgmt/2021-12-01/compute - v65.0.0
    azure-sdk-for-go - compute/mgmt/2021-11-01/compute - v65.0.0
    azure-sdk-for-go - compute/mgmt/2021-08-01/compute - v65.0.0
    azure-sdk-for-go - compute/mgmt/2021-07-01/compute - v65.0.0
    azure-sdk-for-go - compute/mgmt/2021-04-01/compute - v65.0.0
    azure-sdk-for-go - compute/mgmt/2021-03-01/compute - v65.0.0
    azure-sdk-for-go - compute/mgmt/2020-12-01/compute - v65.0.0
    azure-sdk-for-go - compute/mgmt/2020-06-30/compute - v65.0.0
    azure-sdk-for-go - compute/mgmt/2020-06-01/compute - v65.0.0
    azure-sdk-for-go - compute/mgmt/2019-12-01/compute - v65.0.0
    azure-sdk-for-go - compute/mgmt/2019-07-01/compute - v65.0.0
    azure-sdk-for-go - compute/mgmt/2019-03-01/compute - v65.0.0
    ️✔️azure-sdk-for-go - compute/mgmt/2018-10-01/compute - v65.0.0
    ️✔️azure-sdk-for-go - compute/mgmt/2018-06-01/compute - v65.0.0
    ️✔️azure-sdk-for-go - compute/mgmt/2018-04-01/compute - v65.0.0
    ️✔️azure-sdk-for-go - compute/mgmt/2017-12-01/compute - v65.0.0
    ️✔️azure-sdk-for-go - compute/mgmt/2017-09-01/skus - v65.0.0
    ️✔️azure-sdk-for-go - compute/mgmt/2017-03-30/compute - v65.0.0
    ️✔️azure-sdk-for-go - compute/mgmt/2016-03-30/compute - v65.0.0
    ️✔️azure-sdk-for-go - compute/mgmt/2015-06-15/compute - v65.0.0
    ️✔️azure-sdk-for-go - preview/containerservice/mgmt/2015-11-01-preview/containerservice - v65.0.0
    azure-sdk-for-go - preview/compute/mgmt/2020-10-01-preview/compute - v65.0.0
    ️✔️azure-sdk-for-go - preview/compute/mgmt/2016-04-30-preview/compute - v65.0.0
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from 92c0094. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/compute/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] No usable version of the libssl was found
      cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
      cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
      warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 92c0094. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-compute [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation CommunityGalleryImageVersionsOperations.list
      info	[Changelog]   - Added operation CommunityGalleryImagesOperations.list
      info	[Changelog]   - Added operation VirtualMachineImagesOperations.list_by_edge_zone
      info	[Changelog]   - Model CommunityGalleryImage has a new parameter architecture
      info	[Changelog]   - Model CommunityGalleryImage has a new parameter eula
      info	[Changelog]   - Model CommunityGalleryImage has a new parameter privacy_statement_uri
      info	[Changelog]   - Model CommunityGalleryImageVersion has a new parameter exclude_from_latest
      info	[Changelog]   - Model CommunityGalleryImageVersion has a new parameter storage_profile
      info	[Changelog]   - Model GalleryApplicationVersionPublishingProfile has a new parameter advanced_settings
      info	[Changelog]   - Model GalleryApplicationVersionPublishingProfile has a new parameter settings
      info	[Changelog]   - Model SharedGalleryImage has a new parameter architecture
      info	[Changelog]   - Model SharedGalleryImageVersion has a new parameter exclude_from_latest
      info	[Changelog]   - Model SharedGalleryImageVersion has a new parameter storage_profile
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 92c0094. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
      cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
      cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
      cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
      cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
      cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
    • ️✔️azure-resourcemanager-compute-generated [View full logs]  [Release SDK Changes]
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 92c0094. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh]  deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh]  @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh]  [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh]  deprecated @azure/[email protected]: This version has been deprecated, please upgrade to the version tagged as latest
      cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-compute [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation CommunityGalleryImages.list
      info	[Changelog]   - Added operation CommunityGalleryImageVersions.list
      info	[Changelog]   - Added operation VirtualMachineImages.listByEdgeZone
      info	[Changelog]   - Added Interface CommunityGalleryImageList
      info	[Changelog]   - Added Interface CommunityGalleryImagesListNextOptionalParams
      info	[Changelog]   - Added Interface CommunityGalleryImagesListOptionalParams
      info	[Changelog]   - Added Interface CommunityGalleryImageVersionList
      info	[Changelog]   - Added Interface CommunityGalleryImageVersionsListNextOptionalParams
      info	[Changelog]   - Added Interface CommunityGalleryImageVersionsListOptionalParams
      info	[Changelog]   - Added Interface CopyCompletionError
      info	[Changelog]   - Added Interface SharedGalleryDiskImage
      info	[Changelog]   - Added Interface SharedGalleryImageVersionStorageProfile
      info	[Changelog]   - Added Interface UserArtifactSettings
      info	[Changelog]   - Added Interface VirtualMachineImagesListByEdgeZoneOptionalParams
      info	[Changelog]   - Added Interface VmImagesInEdgeZoneListResult
      info	[Changelog]   - Added Type Alias CommunityGalleryImagesListNextResponse
      info	[Changelog]   - Added Type Alias CommunityGalleryImagesListResponse
      info	[Changelog]   - Added Type Alias CommunityGalleryImageVersionsListNextResponse
      info	[Changelog]   - Added Type Alias CommunityGalleryImageVersionsListResponse
      info	[Changelog]   - Added Type Alias CopyCompletionErrorReason
      info	[Changelog]   - Added Type Alias GalleryProvisioningState
      info	[Changelog]   - Added Type Alias SharedGalleryDataDiskImage
      info	[Changelog]   - Added Type Alias SharedGalleryHostCaching
      info	[Changelog]   - Added Type Alias SharedGalleryOSDiskImage
      info	[Changelog]   - Added Type Alias VirtualMachineImagesListByEdgeZoneResponse
      info	[Changelog]   - Interface DiskEncryptionSetUpdate has a new optional parameter federatedClientId
      info	[Changelog]   - Interface EncryptionSetIdentity has a new optional parameter userAssignedIdentities
      info	[Changelog]   - Interface ImageDiskReference has a new optional parameter communityGalleryImageId
      info	[Changelog]   - Interface ImageDiskReference has a new optional parameter sharedGalleryImageId
      info	[Changelog]   - Type Alias CommunityGalleryImage has a new parameter architecture
      info	[Changelog]   - Type Alias CommunityGalleryImage has a new parameter privacyStatementUri
      info	[Changelog]   - Type Alias CommunityGalleryImage has a new parameter eula
      info	[Changelog]   - Type Alias CommunityGalleryImageVersion has a new parameter excludeFromLatest
      info	[Changelog]   - Type Alias CommunityGalleryImageVersion has a new parameter storageProfile
      info	[Changelog]   - Type Alias DiskEncryptionSet has a new parameter federatedClientId
      info	[Changelog]   - Type Alias DiskRestorePoint has a new parameter securityProfile
      info	[Changelog]   - Type Alias GalleryApplicationVersionPublishingProfile has a new parameter settings
      info	[Changelog]   - Type Alias SharedGalleryImage has a new parameter architecture
      info	[Changelog]   - Type Alias SharedGalleryImageVersion has a new parameter excludeFromLatest
      info	[Changelog]   - Type Alias SharedGalleryImageVersion has a new parameter storageProfile
      info	[Changelog]   - Type Alias Snapshot has a new parameter copyCompletionError
      info	[Changelog]   - Added Enum KnownCopyCompletionErrorReason
      info	[Changelog]   - Added Enum KnownGalleryProvisioningState
      info	[Changelog]   - Added Enum KnownSharedGalleryHostCaching
      info	[Changelog]   - Enum KnownDiskEncryptionSetIdentityType has a new value SystemAssignedUserAssigned
      info	[Changelog]   - Enum KnownDiskEncryptionSetIdentityType has a new value UserAssigned
      info	[Changelog]   - Enum KnownDiskStorageAccountTypes has a new value PremiumV2LRS
      info	[Changelog]   - Enum KnownGallerySharingPermissionTypes has a new value Community
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed Enum KnownGalleryApplicationVersionPropertiesProvisioningState
      info	[Changelog]   - Removed Enum KnownGalleryImagePropertiesProvisioningState
      info	[Changelog]   - Removed Enum KnownGalleryImageVersionPropertiesProvisioningState
      info	[Changelog]   - Removed Enum KnownGalleryPropertiesProvisioningState
      info	[Changelog]   - Enum KnownSharingProfileGroupTypes no longer has value Community
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 92c0094. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️profiles/2020-09-01/compute/mgmt/compute [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
      info	[Changelog]
    • ️✔️containerservice/mgmt/2017-01-31/containerservice [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️containerservice/mgmt/2016-09-30/containerservice [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️containerservice/mgmt/2016-03-30/containerservice [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️compute/mgmt/2021-12-01/compute [View full logs
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `OrchestrationServiceNames` to `*string`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 0 additive change(s).
    • ️✔️compute/mgmt/2021-11-01/compute [View full logs
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `OrchestrationServiceNames` to `*string`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 0 additive change(s).
    • ️✔️compute/mgmt/2021-08-01/compute [View full logs
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `OrchestrationServiceNames` to `*string`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 0 additive change(s).
    • ️✔️compute/mgmt/2021-07-01/compute [View full logs
      Only show 5 items here, please refer to log for details.
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New field `TimeCreated` in struct `RestorePointProperties`
      info	[Changelog]
      info	[Changelog] Total 4 breaking change(s), 1 additive change(s).
    • ️✔️compute/mgmt/2021-04-01/compute [View full logs
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New field `CompletionPercent` in struct `DiskRestorePointProperties`
      info	[Changelog] - New field `SupportedCapabilities` in struct `DiskRestorePointProperties`
      info	[Changelog] - New field `NetworkAccessPolicy` in struct `DiskRestorePointProperties`
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 16 additive change(s).
    • ️✔️compute/mgmt/2021-03-01/compute [View full logs
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New field `Name` in struct `PublicIPAddressSku`
      info	[Changelog] - New field `Tier` in struct `PublicIPAddressSku`
      info	[Changelog] - New field `Location` in struct `RestorePointSourceMetadata`
      info	[Changelog]
      info	[Changelog] Total 4 breaking change(s), 21 additive change(s).
    • ️✔️compute/mgmt/2020-12-01/compute [View full logs
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `OrchestrationServiceNames` to `*string`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 0 additive change(s).
    • ️✔️compute/mgmt/2020-06-30/compute [View full logs
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New field `GroupByUserAgent` in struct `ThrottledRequestsInput`
      info	[Changelog] - New field `GroupByClientApplicationID` in struct `ThrottledRequestsInput`
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 9 additive change(s).
    • ️✔️compute/mgmt/2020-06-01/compute [View full logs
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New field `EnableFpga` in struct `VirtualMachineScaleSetUpdateNetworkConfigurationProperties`
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog] - New field `EnableFpga` in struct `VirtualMachineScaleSetNetworkConfigurationProperties`
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 9 additive change(s).
    • ️✔️compute/mgmt/2019-12-01/compute [View full logs
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New struct `UserArtifactManage`
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog]
      info	[Changelog] Total 3 breaking change(s), 4 additive change(s).
    • ️✔️compute/mgmt/2019-07-01/compute [View full logs
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New struct `UserArtifactManage`
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
    • ️✔️compute/mgmt/2019-03-01/compute [View full logs
      Only show 5 items here, please refer to log for details.
      info	[Changelog] - New struct `UserArtifactManage`
      info	[Changelog] - New field `DefaultConfigurationLink` in struct `UserArtifactSource`
      info	[Changelog] - New field `ManageActions` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 4 additive change(s).
    • ️✔️compute/mgmt/2018-10-01/compute [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️compute/mgmt/2018-06-01/compute [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️compute/mgmt/2018-04-01/compute [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️compute/mgmt/2017-12-01/compute [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️compute/mgmt/2017-09-01/skus [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️compute/mgmt/2017-03-30/compute [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️compute/mgmt/2016-03-30/compute [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️compute/mgmt/2015-06-15/compute [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/containerservice/mgmt/2015-11-01-preview/containerservice [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️preview/compute/mgmt/2020-10-01-preview/compute [View full logs
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `OrchestrationServiceStateInput.ServiceName` has been changed from `OrchestrationServiceNames` to `*string`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 0 additive change(s).
    • ️✔️preview/compute/mgmt/2016-04-30-preview/compute [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 92c0094. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armcompute [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `VirtualMachineScaleSetIdentity.UserAssignedIdentities` has been changed from `map[string]*VirtualMachineScaleSetIdentityUserAssignedIdentitiesValue` to `map[string]*UserAssignedIdentitiesValue`
      info	[Changelog] - Type of `GalleryImageProperties.ProvisioningState` has been changed from `*GalleryImagePropertiesProvisioningState` to `*GalleryProvisioningState`
      info	[Changelog] - Type of `GalleryProperties.ProvisioningState` has been changed from `*GalleryPropertiesProvisioningState` to `*GalleryProvisioningState`
      info	[Changelog] - Type of `GalleryApplicationVersionProperties.ProvisioningState` has been changed from `*GalleryApplicationVersionPropertiesProvisioningState` to `*GalleryProvisioningState`
      info	[Changelog] - Type of `GalleryImageVersionProperties.ProvisioningState` has been changed from `*GalleryImageVersionPropertiesProvisioningState` to `*GalleryProvisioningState`
      info	[Changelog] - Const `GalleryImageVersionPropertiesProvisioningStateSucceeded` has been removed
      info	[Changelog] - Const `GalleryPropertiesProvisioningStateMigrating` has been removed
      info	[Changelog] - Const `GalleryPropertiesProvisioningStateDeleting` has been removed
      info	[Changelog] - Const `GalleryApplicationVersionPropertiesProvisioningStateMigrating` has been removed
      info	[Changelog] - Const `SharingProfileGroupTypesCommunity` has been removed
      info	[Changelog] - Const `GalleryImagePropertiesProvisioningStateFailed` has been removed
      info	[Changelog] - Const `GalleryImageVersionPropertiesProvisioningStateFailed` has been removed
      info	[Changelog] - Const `GalleryPropertiesProvisioningStateCreating` has been removed
      info	[Changelog] - Const `GalleryImagePropertiesProvisioningStateDeleting` has been removed
      info	[Changelog] - Const `GalleryApplicationVersionPropertiesProvisioningStateCreating` has been removed
      info	[Changelog] - Const `GalleryImageVersionPropertiesProvisioningStateMigrating` has been removed
      info	[Changelog] - Const `GalleryPropertiesProvisioningStateUpdating` has been removed
      info	[Changelog] - Const `GalleryImageVersionPropertiesProvisioningStateUpdating` has been removed
      info	[Changelog] - Const `GalleryPropertiesProvisioningStateSucceeded` has been removed
      info	[Changelog] - Const `GalleryImageVersionPropertiesProvisioningStateDeleting` has been removed
      info	[Changelog] - Const `GalleryImagePropertiesProvisioningStateUpdating` has been removed
      info	[Changelog] - Const `GalleryImagePropertiesProvisioningStateMigrating` has been removed
      info	[Changelog] - Const `GalleryApplicationVersionPropertiesProvisioningStateFailed` has been removed
      info	[Changelog] - Const `GalleryImageVersionPropertiesProvisioningStateCreating` has been removed
      info	[Changelog] - Const `GalleryImagePropertiesProvisioningStateSucceeded` has been removed
      info	[Changelog] - Const `GalleryPropertiesProvisioningStateFailed` has been removed
      info	[Changelog] - Const `GalleryImagePropertiesProvisioningStateCreating` has been removed
      info	[Changelog] - Const `GalleryApplicationVersionPropertiesProvisioningStateSucceeded` has been removed
      info	[Changelog] - Const `GalleryApplicationVersionPropertiesProvisioningStateDeleting` has been removed
      info	[Changelog] - Const `GalleryApplicationVersionPropertiesProvisioningStateUpdating` has been removed
      info	[Changelog] - Function `PossibleGalleryPropertiesProvisioningStateValues` has been removed
      info	[Changelog] - Function `PossibleGalleryApplicationVersionPropertiesProvisioningStateValues` has been removed
      info	[Changelog] - Function `PossibleGalleryImagePropertiesProvisioningStateValues` has been removed
      info	[Changelog] - Function `PossibleGalleryImageVersionPropertiesProvisioningStateValues` has been removed
      info	[Changelog] - Struct `VirtualMachineScaleSetIdentityUserAssignedIdentitiesValue` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `SharedGalleryHostCachingReadWrite`
      info	[Changelog] - New const `DiskEncryptionSetIdentityTypeUserAssigned`
      info	[Changelog] - New const `GalleryProvisioningStateDeleting`
      info	[Changelog] - New const `DiskEncryptionSetIdentityTypeSystemAssignedUserAssigned`
      info	[Changelog] - New const `GalleryProvisioningStateUpdating`
      info	[Changelog] - New const `GalleryProvisioningStateCreating`
      info	[Changelog] - New const `GalleryProvisioningStateMigrating`
      info	[Changelog] - New const `GallerySharingPermissionTypesCommunity`
      info	[Changelog] - New const `SharedGalleryHostCachingReadOnly`
      info	[Changelog] - New const `SharedGalleryHostCachingNone`
      info	[Changelog] - New const `GalleryProvisioningStateFailed`
      info	[Changelog] - New const `GalleryProvisioningStateSucceeded`
      info	[Changelog] - New const `CopyCompletionErrorReasonCopySourceNotFound`
      info	[Changelog] - New const `DiskStorageAccountTypesPremiumV2LRS`
      info	[Changelog] - New function `PossibleGalleryProvisioningStateValues() []GalleryProvisioningState`
      info	[Changelog] - New function `*VirtualMachineImagesClient.ListByEdgeZone(context.Context, string, string, *VirtualMachineImagesClientListByEdgeZoneOptions) (VirtualMachineImagesClientListByEdgeZoneResponse, error)`
      info	[Changelog] - New function `*CommunityGalleryImagesClient.NewListPager(string, string, *CommunityGalleryImagesClientListOptions) *runtime.Pager[CommunityGalleryImagesClientListResponse]`
      info	[Changelog] - New function `*CommunityGalleryImageVersionsClient.NewListPager(string, string, string, *CommunityGalleryImageVersionsClientListOptions) *runtime.Pager[CommunityGalleryImageVersionsClientListResponse]`
      info	[Changelog] - New function `PossibleCopyCompletionErrorReasonValues() []CopyCompletionErrorReason`
      info	[Changelog] - New function `PossibleSharedGalleryHostCachingValues() []SharedGalleryHostCaching`
      info	[Changelog] - New struct `CommunityGalleryImageList`
      info	[Changelog] - New struct `CommunityGalleryImageVersionList`
      info	[Changelog] - New struct `CommunityGalleryImageVersionsClientListOptions`
      info	[Changelog] - New struct `CommunityGalleryImageVersionsClientListResponse`
      info	[Changelog] - New struct `CommunityGalleryImagesClientListOptions`
      info	[Changelog] - New struct `CommunityGalleryImagesClientListResponse`
      info	[Changelog] - New struct `CopyCompletionError`
      info	[Changelog] - New struct `SharedGalleryDataDiskImage`
      info	[Changelog] - New struct `SharedGalleryDiskImage`
      info	[Changelog] - New struct `SharedGalleryImageVersionStorageProfile`
      info	[Changelog] - New struct `SharedGalleryOSDiskImage`
      info	[Changelog] - New struct `UserArtifactSettings`
      info	[Changelog] - New struct `VMImagesInEdgeZoneListResult`
      info	[Changelog] - New struct `VirtualMachineImagesClientListByEdgeZoneOptions`
      info	[Changelog] - New struct `VirtualMachineImagesClientListByEdgeZoneResponse`
      info	[Changelog] - New field `FederatedClientID` in struct `EncryptionSetProperties`
      info	[Changelog] - New field `ExcludeFromLatest` in struct `SharedGalleryImageVersionProperties`
      info	[Changelog] - New field `StorageProfile` in struct `SharedGalleryImageVersionProperties`
      info	[Changelog] - New field `ExcludeFromLatest` in struct `CommunityGalleryImageVersionProperties`
      info	[Changelog] - New field `StorageProfile` in struct `CommunityGalleryImageVersionProperties`
      info	[Changelog] - New field `CommunityGalleryImageID` in struct `ImageDiskReference`
      info	[Changelog] - New field `SharedGalleryImageID` in struct `ImageDiskReference`
      info	[Changelog] - New field `UserAssignedIdentities` in struct `EncryptionSetIdentity`
      info	[Changelog] - New field `Architecture` in struct `SharedGalleryImageProperties`
      info	[Changelog] - New field `SecurityProfile` in struct `DiskRestorePointProperties`
      info	[Changelog] - New field `PrivacyStatementURI` in struct `CommunityGalleryImageProperties`
      info	[Changelog] - New field `Eula` in struct `CommunityGalleryImageProperties`
      info	[Changelog] - New field `Architecture` in struct `CommunityGalleryImageProperties`
      info	[Changelog] - New field `AdvancedSettings` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog] - New field `Settings` in struct `GalleryApplicationVersionPublishingProfile`
      info	[Changelog] - New field `CopyCompletionError` in struct `SnapshotProperties`
      info	[Changelog] - New field `FederatedClientID` in struct `DiskEncryptionSetUpdateProperties`
      info	[Changelog]
      info	[Changelog] Total 36 breaking change(s), 61 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 92c0094. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️compute [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 92c0094. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.compute [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label May 9, 2022
    @ghost
    Copy link

    ghost commented May 9, 2022

    Thank you for your contribution kjilla03! We will review the pull request and get back to you soon.

    @ghost
    Copy link

    ghost commented May 9, 2022

    CLA assistant check
    All CLA requirements met.

    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 9, 2022
    @openapi-workflow-bot
    Copy link

    Hi, @kjilla03 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @openapi-workflow-bot
    Copy link

    Hi @kjilla03, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    Copy link
    Member

    @rkmanda rkmanda left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    🕐

    @rkmanda rkmanda added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 12, 2022
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 12, 2022
    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 12, 2022
    Copy link
    Member

    @rkmanda rkmanda left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 14, 2022
    @openapi-workflow-bot openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 14, 2022
    @grizzlytheodore
    Copy link
    Contributor

    @ArcturusZhang could you check on the PoliCheck?

    @kjilla
    Copy link
    Contributor

    kjilla commented May 25, 2022 via email

    @kjilla03
    Copy link
    Contributor Author

    @ArcturusZhang could you check on the PoliCheck?

    @grizzlytheodore
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @kjilla03
    Copy link
    Contributor Author

    @ArcturusZhang could you check on the PoliCheck?

    @ArcturusZhang
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go-V2 Approved-SdkBreakingChange-JavaScript ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go-V2 CI-BreakingChange-JavaScript customer-reported Issues that are reported by GitHub users external to the Azure organization.
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    7 participants