ARM ID annotations for Batch #19589

matthchr · 2022-06-24T21:43:42Z

Uses the new arm-id format to describe fields which are references to other ARM resources.

This was split off from #18318

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-06-24T21:43:45Z

Hi, @matthchr Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2022-06-24T21:43:45Z

Swagger Validation Report

️❌BreakingChange: 12 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.9.6)]	new version	base version
BatchManagement.json	2021-01-01(a22c575)	2021-01-01(main)
BatchManagement.json	2021-06-01(a22c575)	2021-06-01(main)
BatchManagement.json	2022-01-01(a22c575)	2022-01-01(main)
BatchManagement.json	2022-06-01(a22c575)	2022-06-01(main)

Rule	Message
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2242:9 Old: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2242:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2332:9 Old: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2324:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2242:9 Old: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2242:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L2409:9 Old: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L2409:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L2574:9 Old: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L2566:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L2409:9 Old: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L2409:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Batch/stable/2022-01-01/BatchManagement.json#L2498:9 Old: Microsoft.Batch/stable/2022-01-01/BatchManagement.json#L2498:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Batch/stable/2022-01-01/BatchManagement.json#L2663:9 Old: Microsoft.Batch/stable/2022-01-01/BatchManagement.json#L2655:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Batch/stable/2022-01-01/BatchManagement.json#L2498:9 Old: Microsoft.Batch/stable/2022-01-01/BatchManagement.json#L2498:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Batch/stable/2022-06-01/BatchManagement.json#L2556:9 Old: Microsoft.Batch/stable/2022-06-01/BatchManagement.json#L2556:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Batch/stable/2022-06-01/BatchManagement.json#L2736:9 Old: Microsoft.Batch/stable/2022-06-01/BatchManagement.json#L2728:9
`❌` 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.Batch/stable/2022-06-01/BatchManagement.json#L2556:9 Old: Microsoft.Batch/stable/2022-06-01/BatchManagement.json#L2556:9

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v1.13.0)	new version	base version
package-2022-06	package-2022-06(a22c575)	package-2022-06(main)
package-2022-01	package-2022-01(a22c575)	package-2022-01(main)
package-2021-06	package-2021-06(a22c575)	package-2021-06(main)
package-2021-01	package-2021-01(a22c575)	package-2021-01(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R2026 - AvoidAnonymousTypes	Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2432
`❌` R2026 - AvoidAnonymousTypes	Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L3642
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.Batch/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L1041
`❌` R4037 - MissingTypeObject	The schema 'AutoStorageBaseProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2240
`❌` R4037 - MissingTypeObject	The schema 'BatchAccountUpdateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2260
`❌` R4037 - MissingTypeObject	The schema 'BatchAccountCreateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2274
`❌` R4037 - MissingTypeObject	The schema 'BatchAccountCreateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2302
`❌` R4037 - MissingTypeObject	The schema 'KeyVaultReference' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2330
`❌` R4037 - MissingTypeObject	The schema 'AutoStorageProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2355
`❌` R4037 - MissingTypeObject	The schema 'VirtualMachineFamilyCoreQuota' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2373
`❌` R4037 - MissingTypeObject	The schema 'BatchAccountIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2391
`❌` R4037 - MissingTypeObject	The schema 'BatchAccountProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2455
`❌` R4037 - MissingTypeObject	The schema 'BatchAccount' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2593
`❌` R4037 - MissingTypeObject	The schema 'BatchAccountUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2612
`❌` R4037 - MissingTypeObject	The schema 'BatchAccountListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2633
`❌` R4037 - MissingTypeObject	The schema 'EncryptionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2649
`❌` R4037 - MissingTypeObject	The schema 'KeyVaultProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2680
`❌` R4037 - MissingTypeObject	The schema 'BatchAccountRegenerateKeyParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2689
`❌` R4037 - MissingTypeObject	The schema 'BatchAccountKeys' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2719
`❌` R4037 - MissingTypeObject	The schema 'ActivateApplicationPackageParameters' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2739
`❌` R4037 - MissingTypeObject	The schema 'Application' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2751
`❌` R4037 - MissingTypeObject	The schema 'ApplicationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2766
`❌` R4037 - MissingTypeObject	The schema 'ApplicationPackage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2783
`❌` R4037 - MissingTypeObject	The schema 'ApplicationPackageProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2798
`❌` R4037 - MissingTypeObject	The schema 'ListApplicationsResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2848
`❌` R4037 - MissingTypeObject	The schema 'ListApplicationPackagesResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2864
`❌` R4037 - MissingTypeObject	The schema 'BatchLocationQuota' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2880
`❌` R4037 - MissingTypeObject	The schema 'Resource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2891
`❌` R4037 - MissingTypeObject	The schema 'ProxyResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2925
`❌` R4037 - MissingTypeObject	The schema 'CertificateBaseProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L2996

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️❌ModelValidation: 2 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` XMS_EXAMPLE_NOTFOUND_ERROR	x-ms-example not found in Operations_List. Url: Microsoft.Batch/stable/2021-01-01/BatchManagement.json#L1042:14
`❌` XMS_EXAMPLE_NOTFOUND_ERROR	x-ms-example not found in Operations_List. Url: Microsoft.Batch/stable/2021-06-01/BatchManagement.json#L1163:14

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]

The following tags are being changed in this PR

"https://github.com/Azure/azure-rest-api-specs/blob/a22c5754ab0bbb26473710a3586c130fa7d97cba/specification/batch/resource-manager/readme.md#tag-package-2022-06">batch/resource-manager/readme.md#package-2022-06
"https://github.com/Azure/azure-rest-api-specs/blob/a22c5754ab0bbb26473710a3586c130fa7d97cba/specification/batch/resource-manager/readme.md#tag-package-2022-01">batch/resource-manager/readme.md#package-2022-01
"https://github.com/Azure/azure-rest-api-specs/blob/a22c5754ab0bbb26473710a3586c130fa7d97cba/specification/batch/resource-manager/readme.md#tag-package-2021-06">batch/resource-manager/readme.md#package-2021-06
"https://github.com/Azure/azure-rest-api-specs/blob/a22c5754ab0bbb26473710a3586c130fa7d97cba/specification/batch/resource-manager/readme.md#tag-package-2021-01">batch/resource-manager/readme.md#package-2021-01

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ UnkownSecurityScheme	"readme":"batch/resource-manager/readme.md", "tag":"package-2022-06", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous"
⚠️ UnkownSecurityScheme	"readme":"batch/resource-manager/readme.md", "tag":"package-2022-01", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous"
⚠️ UnkownSecurityScheme	"readme":"batch/resource-manager/readme.md", "tag":"package-2021-06", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous"
⚠️ UnkownSecurityScheme	"readme":"batch/resource-manager/readme.md", "tag":"package-2021-01", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous"

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-06-24T21:43:46Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-batch - 16.2.0
❌azure-sdk-for-go - armbatch - 2.0.0

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from abe8b05. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/batch/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from abe8b05. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.

️✔️track2_azure-mgmt-batch [View full logs] [Release SDK Changes]
- azure_mgmt_batch-14.0.0b1-py3-none-any.whl
- azure-mgmt-batch-14.0.0b1.zip
```
info	[Changelog]
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from abe8b05. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] [ForkJoinPool-1-worker-3] INFO com.azure.core.test.implementation.TestingHelpers - Environment variable 'AZURE_TEST_MODE' has not been set yet. Using 'Playback' mode.

️✔️azure-resourcemanager-batch [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from abe8b05. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armbatch [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*ApplicationClient.Create` parameter(s) have been changed from `(context.Context, string, string, string, *ApplicationClientCreateOptions)` to `(context.Context, string, string, string, Application, *ApplicationClientCreateOptions)`
info	[Changelog] - Function `*ApplicationPackageClient.Create` parameter(s) have been changed from `(context.Context, string, string, string, string, *ApplicationPackageClientCreateOptions)` to `(context.Context, string, string, string, string, ApplicationPackage, *ApplicationPackageClientCreateOptions)`
info	[Changelog] - Field `Parameters` of struct `ApplicationPackageClientCreateOptions` has been removed
info	[Changelog] - Field `Parameters` of struct `ApplicationClientCreateOptions` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `PrivateEndpointConnectionProvisioningStateCancelled`
info	[Changelog] - New const `PrivateEndpointConnectionProvisioningStateCreating`
info	[Changelog] - New const `EndpointAccessDefaultActionDeny`
info	[Changelog] - New const `EndpointAccessDefaultActionAllow`
info	[Changelog] - New const `PrivateEndpointConnectionProvisioningStateDeleting`
info	[Changelog] - New function `PossibleEndpointAccessDefaultActionValues() []EndpointAccessDefaultAction`
info	[Changelog] - New function `*PrivateEndpointConnectionClient.BeginDelete(context.Context, string, string, string, *PrivateEndpointConnectionClientBeginDeleteOptions) (*runtime.Poller[PrivateEndpointConnectionClientDeleteResponse], error)`
info	[Changelog] - New struct `EndpointAccessProfile`
info	[Changelog] - New struct `IPRule`
info	[Changelog] - New struct `NetworkProfile`
info	[Changelog] - New struct `PrivateEndpointConnectionClientBeginDeleteOptions`
info	[Changelog] - New struct `PrivateEndpointConnectionClientDeleteResponse`
info	[Changelog] - New field `NetworkProfile` in struct `AccountUpdateProperties`
info	[Changelog] - New field `PublicNetworkAccess` in struct `AccountUpdateProperties`
info	[Changelog] - New field `NetworkProfile` in struct `AccountCreateProperties`
info	[Changelog] - New field `NetworkProfile` in struct `AccountProperties`
info	[Changelog] - New field `NodeManagementEndpoint` in struct `AccountProperties`
info	[Changelog] - New field `GroupIDs` in struct `PrivateEndpointConnectionProperties`
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 21 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from abe8b05. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
cmderr	[automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.

️✔️@azure/arm-batch [View full logs] [Release SDK Changes]

azure-arm-batch-7.2.1.tgz

info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from abe8b05. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️batch [View full logs] [Release Schema Changes]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from abe8b05. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.Batch [View full logs] [Release SDK Changes]
- Az.Batch.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-06-24T21:46:11Z

Hi @matthchr, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

openapi-workflow-bot · 2022-06-24T21:46:51Z

Hi @matthchr, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

matthchr · 2022-06-30T16:55:41Z

@dpwatrous is there elsewhere that this change needs to be made (batch repo?) for it to persist into new verisons?

dpwatrous · 2022-06-30T18:03:00Z

Thanks for the PR, @matthchr. We do need to merge this into the internal service repo, but this change should come along for the ride as I believe we have other changes to merge.

@paterasMSFT @wiboris FYI

matthchr · 2022-07-22T17:33:08Z

.NET SDK has no x-ms-format, so this is a superset, which is OK because this package is not GA yet in .NET

Create to sync Azure/azure-rest-api-specs#19589 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/batch?expand=1)

matthchr requested review from paterasMSFT and dpwatrous as code owners June 24, 2022 21:43

openapi-assignment-bot bot assigned ArcturusZhang Jun 24, 2022

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label Jun 24, 2022

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Jun 24, 2022

matthchr force-pushed the feature/batch-arm-ids branch from e0b72d4 to 41d9db5 Compare June 24, 2022 21:48

dpwatrous approved these changes Jun 30, 2022

View reviewed changes

ARM ID annotations for Batch

a22c575

matthchr force-pushed the feature/batch-arm-ids branch from 41d9db5 to a22c575 Compare July 22, 2022 17:49

openapi-pipeline-app bot added the CI-BreakingChange-Go label Jul 22, 2022

ArcturusZhang approved these changes Aug 5, 2022

View reviewed changes

ArcturusZhang added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-ModelValidation labels Aug 5, 2022

ArcturusZhang merged commit abe8b05 into Azure:main Aug 5, 2022

This was referenced Aug 5, 2022

[ReleasePR armbatch] Migrate to net track2 for some resource-manager readmes batch 2 Azure/azure-sdk-for-go#18261

Closed

[ReleasePR batch] ARM ID annotations for Batch Azure/azure-resource-manager-schemas#2514

Merged

matthchr deleted the feature/batch-arm-ids branch September 27, 2022 18:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ARM ID annotations for Batch #19589

ARM ID annotations for Batch #19589

Uh oh!

matthchr commented Jun 24, 2022

Uh oh!

openapi-workflow-bot bot commented Jun 24, 2022

Uh oh!

openapi-pipeline-app bot commented Jun 24, 2022 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Jun 24, 2022 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-workflow-bot bot commented Jun 24, 2022

Uh oh!

openapi-workflow-bot bot commented Jun 24, 2022

Uh oh!

matthchr commented Jun 30, 2022

Uh oh!

dpwatrous commented Jun 30, 2022

Uh oh!

matthchr commented Jul 22, 2022

Uh oh!

Uh oh!

ARM ID annotations for Batch #19589

ARM ID annotations for Batch #19589

Uh oh!

Conversation

matthchr commented Jun 24, 2022

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-workflow-bot bot commented Jun 24, 2022

Uh oh!

openapi-pipeline-app bot commented Jun 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Jun 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-workflow-bot bot commented Jun 24, 2022

Uh oh!

openapi-workflow-bot bot commented Jun 24, 2022

Uh oh!

matthchr commented Jun 30, 2022

Uh oh!

dpwatrous commented Jun 30, 2022

Uh oh!

matthchr commented Jul 22, 2022

Uh oh!

Uh oh!

openapi-pipeline-app bot commented Jun 24, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jun 24, 2022 •

edited

Loading