Skip to content

Fix a couple issues with existing swaggers #19735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 19, 2022
Merged

Fix a couple issues with existing swaggers #19735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5d12256
Change to lowercase for the TestNotificationDetailsResponse contract
Jul 7, 2022
b84e435
Revert "Change to lowercase for the TestNotificationDetailsResponse c…
Jul 8, 2022
a7268e9
Task 14946056: Fix the Swagger, need to return response schema for PO…
Jul 11, 2022
e3639b5
Merge branch 'main' of https://github.com/thomasp98296/azure-rest-api…
Jul 11, 2022
76a445b
Need to fix examples
Jul 12, 2022
1296726
Pretty check
Jul 12, 2022
5b5114c
State to state
Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
342 changes: 202 additions & 140 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

32 changes: 22 additions & 10 deletions ...ation/monitor/resource-manager/Microsoft.Insights/stable/2022-04-01/actionGroups_API.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,14 +242,20 @@
],
"responses": {
"202": {
"description": "The notification succeeded",
"description": "The notification request accepted",
"headers": {
"location": {
"type": "string",
"description": "The location header that has the polling uri."
}
}
},
"200": {
"description": "The notification succeeded",
"schema": {
"$ref": "#/definitions/TestNotificationDetailsResponse"
}
},
"default": {
"description": "An error occurred while sending the test notifications",
"schema": {
Expand Down Expand Up @@ -294,14 +300,20 @@
],
"responses": {
"202": {
"description": "The notification succeeded",
"description": "The notification request accepted",
"headers": {
"location": {
"type": "string",
"description": "The location header that has the polling uri."
}
}
},
"200": {
"description": "The notification succeeded",
"schema": {
"$ref": "#/definitions/TestNotificationDetailsResponse"
}
},
"default": {
"description": "An error occurred while sending the test notifications",
"schema": {
Expand Down Expand Up @@ -566,23 +578,23 @@
"description": "The details of the test notification results.",
"type": "object",
"properties": {
"Context": {
"context": {
"type": "object",
"$ref": "#/definitions/Context"
},
"State": {
"state": {
"type": "string",
"description": "The overall state"
},
"CompletedTime": {
"completedTime": {
"type": "string",
"description": "The completed time"
},
"CreatedTime": {
"createdTime": {
"type": "string",
"description": "The created time"
},
"ActionDetails": {
"actionDetails": {
"x-ms-identifiers": [],
"type": "array",
"items": {
Expand All @@ -592,7 +604,7 @@
}
},
"required": [
"State"
"state"
]
},
"ActionDetail": {
Expand Down Expand Up @@ -629,11 +641,11 @@
"description": "The context info",
"type": "object",
"properties": {
"NotificationSource": {
"notificationSource": {
"type": "string",
"description": "The source of the notification request"
},
"ContextType": {
"contextType": {
"type": "string",
"description": "The context id type"
}
Expand Down
14 changes: 7 additions & 7 deletions .../resource-manager/Microsoft.Insights/stable/2022-04-01/examples/getTestNotifications.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@
"200": {
"headers": {},
"body": {
"Context": {
"NotificationSource": "Microsoft.Insights/TestNotification",
"ContextType": "Microsoft.Insights/Budget"
"context": {
"notificationSource": "Microsoft.Insights/TestNotification",
"contextType": "Microsoft.Insights/Budget"
},
"State": "Completed",
"CompletedTime": "0001-01-01T00:00:00+00:00",
"CreatedTime": "2021-09-21T04:52:29.5091168+00:00",
"ActionDetails": [
"state": "Completed",
"completedTime": "0001-01-01T00:00:00+00:00",
"createdTime": "2021-09-21T04:52:29.5091168+00:00",
"actionDetails": [
{
"MechanismType": "AzureAppPush",
"Name": "AzureAppPush-name",
Expand Down
14 changes: 7 additions & 7 deletions ...crosoft.Insights/stable/2022-04-01/examples/getTestNotificationsAtResourceGroupLevel.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@
"200": {
"headers": {},
"body": {
"Context": {
"NotificationSource": "Microsoft.Insights/TestNotification",
"ContextType": "Microsoft.Insights/Budget"
"context": {
"notificationSource": "Microsoft.Insights/TestNotification",
"contextType": "Microsoft.Insights/Budget"
},
"State": "Completed",
"CompletedTime": "0001-01-01T00:00:00+00:00",
"CreatedTime": "2021-09-21T04:52:29.5091168+00:00",
"ActionDetails": [
"state": "Completed",
"completedTime": "0001-01-01T00:00:00+00:00",
"createdTime": "2021-09-21T04:52:29.5091168+00:00",
"actionDetails": [
{
"MechanismType": "AzureAppPush",
"Name": "AzureAppPush-name",
Expand Down
104 changes: 103 additions & 1 deletion ...resource-manager/Microsoft.Insights/stable/2022-04-01/examples/postTestNotifications.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,109 @@
"responses": {
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/11111111-1111-1111-1111-111111111111/resourceGroups/Test-Rg/providers/microsoft.insights/notificationStatus/11111111111111?api-version=2021-09-01"
"location": "https://management.azure.com/subscriptions/11111111-1111-1111-1111-111111111111/providers/microsoft.insights/notificationStatus/11111111111111?api-version=2022-04-01"
}
},
"200": {
"headers": {},
"body": {
"context": {
"notificationSource": "Microsoft.Insights/TestNotification",
"contextType": "Microsoft.Insights/Budget"
},
"state": "Completed",
"completedTime": "0001-01-01T00:00:00+00:00",
"createdTime": "2021-09-21T04:52:29.5091168+00:00",
"actionDetails": [
{
"MechanismType": "AzureAppPush",
"Name": "AzureAppPush-name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:42.8620629+00:00",
"Detail": null
},
{
"MechanismType": "AzureFunction",
"Name": "AzureFunction-name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:42.0623319+00:00",
"Detail": null
},
{
"MechanismType": "Email",
"Name": "Email-name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:40.7480368+00:00",
"Detail": null
},
{
"MechanismType": "LogicApp",
"Name": "LogicApp-Name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:42.2473419+00:00",
"Detail": null
},
{
"MechanismType": "Webhook",
"Name": "Webhook-name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:42.0723479+00:00",
"Detail": null
},
{
"MechanismType": "SecureWebhook",
"Name": "SecureWebhook-name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:42.0723479+00:00",
"Detail": null
},
{
"MechanismType": "Sms",
"Name": "Sms-name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:41.353015+00:00",
"Detail": null
},
{
"MechanismType": "Voice",
"Name": "Voice-name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:41.6330734+00:00",
"Detail": null
},
{
"MechanismType": "EventHub",
"Name": "EventHub-name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:42.0723479+00:00",
"Detail": null
},
{
"MechanismType": "AutomationRunbook",
"Name": "AutomationRunbook-name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:42.0723479+00:00",
"Detail": null
},
{
"MechanismType": "Itsm",
"Name": "Itsm-name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:42.0723479+00:00",
"Detail": null
}
]
}
}
}
Expand Down
104 changes: 103 additions & 1 deletion ...rosoft.Insights/stable/2022-04-01/examples/postTestNotificationsAtResourceGroupLevel.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,109 @@
"responses": {
"202": {
"headers": {
"location": "https://management.azure.com/subscriptions/11111111-1111-1111-1111-111111111111/resourceGroups/Test-Rg/providers/microsoft.insights/notificationStatus/11111111111111?api-version=2021-09-01"
"location": "https://management.azure.com/subscriptions/11111111-1111-1111-1111-111111111111/resourceGroups/Test-Rg/providers/microsoft.insights/notificationStatus/11111111111111?api-version=2022-04-01"
}
},
"200": {
"headers": {},
"body": {
"context": {
"notificationSource": "Microsoft.Insights/TestNotification",
"contextType": "Microsoft.Insights/Budget"
},
"state": "Completed",
"completedTime": "0001-01-01T00:00:00+00:00",
"createdTime": "2021-09-21T04:52:29.5091168+00:00",
"actionDetails": [
{
"MechanismType": "AzureAppPush",
"Name": "AzureAppPush-name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:42.8620629+00:00",
"Detail": null
},
{
"MechanismType": "AzureFunction",
"Name": "AzureFunction-name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:42.0623319+00:00",
"Detail": null
},
{
"MechanismType": "Email",
"Name": "Email-name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:40.7480368+00:00",
"Detail": null
},
{
"MechanismType": "LogicApp",
"Name": "LogicApp-Name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:42.2473419+00:00",
"Detail": null
},
{
"MechanismType": "Webhook",
"Name": "Webhook-name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:42.0723479+00:00",
"Detail": null
},
{
"MechanismType": "SecureWebhook",
"Name": "SecureWebhook-name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:42.0723479+00:00",
"Detail": null
},
{
"MechanismType": "Sms",
"Name": "Sms-name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:41.353015+00:00",
"Detail": null
},
{
"MechanismType": "Voice",
"Name": "Voice-name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:41.6330734+00:00",
"Detail": null
},
{
"MechanismType": "EventHub",
"Name": "EventHub-name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:42.0723479+00:00",
"Detail": null
},
{
"MechanismType": "AutomationRunbook",
"Name": "AutomationRunbook-name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:42.0723479+00:00",
"Detail": null
},
{
"MechanismType": "Itsm",
"Name": "Itsm-name",
"Status": "Completed",
"SubState": "Default",
"SendTime": "2021-09-21T04:52:42.0723479+00:00",
"Detail": null
}
]
}
}
}
Expand Down
Loading