Skip to content

[app] Fix default vaule for "type": "boolean" #21044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2022
Merged

[app] Fix default vaule for "type": "boolean" #21044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...fication/app/resource-manager/Microsoft.App/preview/2022-06-01-preview/ContainerApps.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,7 +754,7 @@
"allowInsecure": {
"description": "Bool indicating if HTTP connections to is allowed. If set to false HTTP connections are automatically redirected to HTTPS connections",
"type": "boolean",
"default": "false"
"default": false
},
"ipSecurityRestrictions": {
"description": "Rules to restrict incoming IP address.",
Expand Down
2 changes: 1 addition & 1 deletion specification/app/resource-manager/Microsoft.App/stable/2022-03-01/ContainerApps.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@
"allowInsecure": {
"description": "Bool indicating if HTTP connections to is allowed. If set to false HTTP connections are automatically redirected to HTTPS connections",
"type": "boolean",
"default": "false"
"default": false
}
}
},
Expand Down
23 changes: 0 additions & 23 deletions specification/app/resource-manager/readme.python.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,26 +16,3 @@ clear-output-folder: true
no-namespace-folders: true
output-folder: $(python-sdks-folder)/appcontainers/azure-mgmt-appcontainers/azure/mgmt/appcontainers
```

``` yaml $(python)
directive:
- from: CommonDefinitions.json
where: $.definitions.DaprComponent.properties.ignoreErrors
transform: $['default'] = 'False'

- from: ContainerApps.json
where: $.definitions.Dapr.properties.enabled
transform: $['default'] = 'False'

- from: ContainerApps.json
where: $.definitions.Ingress.properties.external
transform: $['default'] = 'False'

- from: ContainerApps.json
where: $.definitions.TrafficWeight.properties.latestRevision
transform: $['default'] = 'False'

- from: ContainerApps.json
where: $.definitions.Ingress.properties.allowInsecure
transform: $['default'] = 'False'
```