Test compute #21834
Closed
Test compute #21834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…21232) * Adding zones, example and renaming frontendIPConfigurations to frontendIpConfigurations, LoadBalancerFrontendIPConfiguration to LoadBalancerFrontendIpConfiguration, LoadBalancerFrontendIPConfigurationProperties to LoadBalancerFrontendIpConfigurationProperties * resolving CI validations * changing privateIPAddress to privateIpAddress, publiCIPAddress to ppublicIpAddress * reverting publicIpAddress, privateIpAddress to privateIPAddress, publicIPAddress * removing x-ms-client-flatten and parameter order change
|
Hi, @msyyc Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
ghost
added
the
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.2)] | new version | base version |
|---|---|---|
| common.json | 1.0(e50ad90) | 1.0(main) |
️❌Breaking Change(Cross-Version): 4 Errors, 47 Warnings failed [Detail]
| compared swaggers (via Oad v0.10.2)] | new version | base version |
|---|---|---|
| cloudService.json | 2022-09-04(e50ad90) | 2022-04-04(main) |
| cloudService.json | 2022-09-04(e50ad90) | 2020-10-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
The following breaking changes are detected by comparison with the latest preview version:
Only 30 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 1 Warnings warning [Detail]
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-2022-03-03 | package-2022-03-03(e50ad90) | package-2022-03-03(main) |
| package-2022-08-01 | package-2022-08-01(e50ad90) | package-2022-08-01(main) |
| package-2022-07-02 | package-2022-07-02(e50ad90) | package-2022-07-02(main) |
| package-2022-09-04 | package-2022-09-04(e50ad90) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| Consider using x-ms-client-flatten to provide a better end user experience Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L2082 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The resource name parameter 'cloudServiceName' should be defined with a 'pattern' restriction. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L37 |
|
The resource name parameter 'roleInstanceName' should be defined with a 'pattern' restriction. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L37 |
|
An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L38 |
|
A 'delete' operation 'CloudServiceRoleInstances_Delete' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 204. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L38 |
|
The parameters:roleInstanceName,resourceGroupName,cloudServiceName should be kept in the same order as they present in the path. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L38 |
|
A 202 response should include an Location response header. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L83 |
|
The parameters:roleInstanceName,resourceGroupName,cloudServiceName should be kept in the same order as they present in the path. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L97 |
|
The resource name parameter 'cloudServiceName' should be defined with a 'pattern' restriction. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L167 |
|
The resource name parameter 'roleInstanceName' should be defined with a 'pattern' restriction. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L167 |
|
The parameters:roleInstanceName,resourceGroupName,cloudServiceName should be kept in the same order as they present in the path. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L168 |
|
The resource name parameter 'cloudServiceName' should be defined with a 'pattern' restriction. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L224 |
|
The resource name parameter 'cloudServiceName' should be defined with a 'pattern' restriction. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L291 |
|
The resource name parameter 'roleInstanceName' should be defined with a 'pattern' restriction. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L291 |
|
The parameters:roleInstanceName,resourceGroupName,cloudServiceName should be kept in the same order as they present in the path. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L292 |
|
An async POST operation must set long running operation options 'x-ms-long-running-operation-options' Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L292 |
|
A 202 response should include an Location response header. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L337 |
|
The resource name parameter 'cloudServiceName' should be defined with a 'pattern' restriction. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L349 |
|
The resource name parameter 'roleInstanceName' should be defined with a 'pattern' restriction. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L349 |
|
The parameters:roleInstanceName,resourceGroupName,cloudServiceName should be kept in the same order as they present in the path. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L350 |
|
An async POST operation must set long running operation options 'x-ms-long-running-operation-options' Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L350 |
|
A 202 response should include an Location response header. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L395 |
|
The resource name parameter 'cloudServiceName' should be defined with a 'pattern' restriction. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L407 |
|
The resource name parameter 'roleInstanceName' should be defined with a 'pattern' restriction. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L407 |
|
The parameters:roleInstanceName,resourceGroupName,cloudServiceName should be kept in the same order as they present in the path. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L408 |
|
An async POST operation must set long running operation options 'x-ms-long-running-operation-options' Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L408 |
|
A 202 response should include an Location response header. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L453 |
|
The resource name parameter 'cloudServiceName' should be defined with a 'pattern' restriction. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L465 |
|
The resource name parameter 'roleInstanceName' should be defined with a 'pattern' restriction. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L465 |
|
The parameters:roleInstanceName,resourceGroupName,cloudServiceName should be kept in the same order as they present in the path. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L466 |
|
The resource name parameter 'cloudServiceName' should be defined with a 'pattern' restriction. Location: CloudserviceRP/stable/2022-09-04/cloudService.json#L526 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2022-09-04 |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️❌~[Staging] SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
|
Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
|
Hi, @msyyc, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
|
Hi @msyyc, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test timeout for #21630