Skip to content

Conversation

sushil490023
Copy link
Contributor

…/en-us/azure/automation/manage-runbooks

Changes

With recent changes made to swagger https://github.com/Azure/azure-rest-api-specs/pull/21128/files#diff-8a2476001660339cd88481fb4f06109174b32e1be800923813a9c5ecd0fe53fd

Pattern rule was added to Runbook Name resource to mandatory requirement . However this pattern didnt matched with what is mentioned in public document and whats already being used by customer.

https://learn.microsoft.com/en-us/azure/automation/manage-runbooks

image

This introduced a bug in new cmdlets generated by usingthis swagger version for few customer.

The changes are used to fix the Name as per doc and fix breaking changes

@openapi-workflow-bot
Copy link

Hi, @sushil490023 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 30, 2023

    Swagger Validation Report

    ️❌BreakingChange: 17 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    runbook.json 2022-08-08(1031054) 2022-08-08(main)
    Rule Message
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Automation/stable/2022-08-08/runbook.json#L67:11
    Old: Microsoft.Automation/stable/2022-08-08/runbook.json#L67:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Automation/stable/2022-08-08/runbook.json#L121:11
    Old: Microsoft.Automation/stable/2022-08-08/runbook.json#L121:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Automation/stable/2022-08-08/runbook.json#L197:11
    Old: Microsoft.Automation/stable/2022-08-08/runbook.json#L197:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Automation/stable/2022-08-08/runbook.json#L250:11
    Old: Microsoft.Automation/stable/2022-08-08/runbook.json#L250:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Automation/stable/2022-08-08/runbook.json#L307:11
    Old: Microsoft.Automation/stable/2022-08-08/runbook.json#L307:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Automation/stable/2022-08-08/runbook.json#L363:11
    Old: Microsoft.Automation/stable/2022-08-08/runbook.json#L363:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Automation/stable/2022-08-08/runbook.json#L416:11
    Old: Microsoft.Automation/stable/2022-08-08/runbook.json#L416:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Automation/stable/2022-08-08/runbook.json#L470:11
    Old: Microsoft.Automation/stable/2022-08-08/runbook.json#L470:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Automation/stable/2022-08-08/runbook.json#L536:11
    Old: Microsoft.Automation/stable/2022-08-08/runbook.json#L536:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Automation/stable/2022-08-08/runbook.json#L596:11
    Old: Microsoft.Automation/stable/2022-08-08/runbook.json#L596:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Automation/stable/2022-08-08/runbook.json#L697:11
    Old: Microsoft.Automation/stable/2022-08-08/runbook.json#L697:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Automation/stable/2022-08-08/runbook.json#L757:11
    Old: Microsoft.Automation/stable/2022-08-08/runbook.json#L757:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Automation/stable/2022-08-08/runbook.json#L820:11
    Old: Microsoft.Automation/stable/2022-08-08/runbook.json#L820:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Automation/stable/2022-08-08/runbook.json#L880:11
    Old: Microsoft.Automation/stable/2022-08-08/runbook.json#L880:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Automation/stable/2022-08-08/runbook.json#L933:11
    Old: Microsoft.Automation/stable/2022-08-08/runbook.json#L933:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Automation/stable/2022-08-08/runbook.json#L983:11
    Old: Microsoft.Automation/stable/2022-08-08/runbook.json#L983:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Automation/stable/2022-08-08/runbook.json#L1033:11
    Old: Microsoft.Automation/stable/2022-08-08/runbook.json#L1033:11
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2022-08-08 package-2022-08-08(1031054) package-2022-08-08(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    PathForNestedResource The path for nested resource doest not meet the valid resource pattern.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L39
    ResourceNameRestriction The resource name parameter 'automationAccountName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L39
    XmsResourceInPutResponse The 200 response model for an ARM PUT operation must have x-ms-azure-resource extension set to true in its hierarchy.Operation: RunbookDraft_ReplaceContent
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L94
    ValidFormats 'file' is not a known format.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L135
    CreateOperationAsyncResponseValidation An async PUT operation must return 201.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L143
    CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L150
    ResourceNameRestriction The resource name parameter 'automationAccountName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L172
    ResourceNameRestriction The resource name parameter 'automationAccountName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L225
    PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L226
    PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L282
    ResourceNameRestriction The resource name parameter 'automationAccountName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L282
    ResourceNameRestriction The resource name parameter 'automationAccountName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L335
    ResourceNameRestriction The resource name parameter 'automationAccountName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L391
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property name.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L544
    UnSupportedPatchProperties The patch operation body parameter schema should not contains property location.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L544
    ResourceNameRestriction The resource name parameter 'automationAccountName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L624
    ResourceNameRestriction The resource name parameter 'automationAccountName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L672
    ResourceNameRestriction The resource name parameter 'automationAccountName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L732
    PathForNestedResource The path for nested resource doest not meet the valid resource pattern.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L795
    ResourceNameRestriction The resource name parameter 'automationAccountName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L795
    XmsResourceInPutResponse The 200 response model for an ARM PUT operation must have x-ms-azure-resource extension set to true in its hierarchy.Operation: TestJob_Create
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L796
    PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L908
    ResourceNameRestriction The resource name parameter 'automationAccountName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L908
    PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L958
    ResourceNameRestriction The resource name parameter 'automationAccountName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L958
    PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L1008
    ResourceNameRestriction The resource name parameter 'automationAccountName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L1008
    ProvisioningStateValidation ProvisioningState must have terminal states: Succeeded, Failed and Canceled.
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L1251
    BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'TestJob' has extra properties ['creationTime'].
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L1596
    BodyTopLevelProperties Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'TestJob' has extra properties ['status'].
    Location: Microsoft.Automation/stable/2022-08-08/runbook.json#L1596
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/automation/resource-manager/readme.md
    tag: specification/automation/resource-manager/readme.md#tag-package-2022-08-08
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️~[Staging] SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️~[Staging] CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jan 30, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 30, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/automation/armautomation - Approved - 0.8.0
    +	Field `Value` of struct `DscConfigurationClientGetContentResponse` has been removed
    +	Function `*DscConfigurationClient.UpdateWithJSON` parameter(s) have been changed from `(context.Context, string, string, string, DscConfigurationUpdateParameters, *DscConfigurationClientUpdateWithJSONOptions)` to `(context.Context, string, string, string, *DscConfigurationClientUpdateWithJSONOptions)`
    +	Function `*DscConfigurationClient.UpdateWithText` parameter(s) have been changed from `(context.Context, string, string, string, string, *DscConfigurationClientUpdateWithTextOptions)` to `(context.Context, string, string, string, *DscConfigurationClientUpdateWithTextOptions)`
    +	Struct `ComponentsSgqdofSchemasIdentityPropertiesUserassignedidentitiesAdditionalproperties` has been removed
    +	Type of `Identity.UserAssignedIdentities` has been changed from `map[string]*ComponentsSgqdofSchemasIdentityPropertiesUserassignedidentitiesAdditionalproperties` to `map[string]*UserAssignedIdentitiesProperties`

    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from 1c23efa. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • Azure.ResourceManager.Automation [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.Response<Azure.ResourceManager.Automation.AutomationAccountPython2PackageResource> Azure.ResourceManager.Automation.AutomationAccountPython2PackageResource.Update(Azure.ResourceManager.Automation.Models.AutomationAccountPython2PackagePatch, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Threading.Tasks.Task<Azure.Response<Azure.ResourceManager.Automation.AutomationAccountPython2PackageResource>> Azure.ResourceManager.Automation.AutomationAccountPython2PackageResource.UpdateAsync(Azure.ResourceManager.Automation.Models.AutomationAccountPython2PackagePatch, System.Threading.CancellationToken)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.Automation.Models.AutomationAccountPython2PackageCreateOrUpdateContent' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.Automation.Models.AutomationAccountPython2PackagePatch' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState.ActivitiesStored' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState.Cancelled' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState.ConnectionTypeImported' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState.ContentDownloaded' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState.ContentRetrieved' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState.ContentStored' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState.ContentValidated' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState.Created' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState.Creating' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState.Failed' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState.ModuleDataStored' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState.ModuleImportRunbookComplete' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState.RunningImportModuleRunbook' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState.StartingImportModuleRunbook' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState.Succeeded' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState Azure.ResourceManager.Automation.Models.ModuleProvisioningState.Updating' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Int32 System.Int32 Azure.ResourceManager.Automation.Models.ModuleProvisioningState.value__' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Automation/Debug/netstandard2.0/Azure.ResourceManager.Automation.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/automation/Azure.ResourceManager.Automation/src/Azure.ResourceManager.Automation.csproj::TargetFramework=netstandard2.0]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 1c23efa. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.1
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.1>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-automation [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 1c23efa. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/automation/armautomation [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `*DscConfigurationClient.UpdateWithJSON` parameter(s) have been changed from `(context.Context, string, string, string, DscConfigurationUpdateParameters, *DscConfigurationClientUpdateWithJSONOptions)` to `(context.Context, string, string, string, *DscConfigurationClientUpdateWithJSONOptions)`
      info	[Changelog] - Function `*DscConfigurationClient.UpdateWithText` parameter(s) have been changed from `(context.Context, string, string, string, string, *DscConfigurationClientUpdateWithTextOptions)` to `(context.Context, string, string, string, *DscConfigurationClientUpdateWithTextOptions)`
      info	[Changelog] - Type of `Identity.UserAssignedIdentities` has been changed from `map[string]*ComponentsSgqdofSchemasIdentityPropertiesUserassignedidentitiesAdditionalproperties` to `map[string]*UserAssignedIdentitiesProperties`
      info	[Changelog] - Struct `ComponentsSgqdofSchemasIdentityPropertiesUserassignedidentitiesAdditionalproperties` has been removed
      info	[Changelog] - Field `Value` of struct `DscConfigurationClientGetContentResponse` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New function `NewPython3PackageClient(string, azcore.TokenCredential, *arm.ClientOptions) (*Python3PackageClient, error)`
      info	[Changelog] - New function `*Python3PackageClient.CreateOrUpdate(context.Context, string, string, string, PythonPackageCreateParameters, *Python3PackageClientCreateOrUpdateOptions) (Python3PackageClientCreateOrUpdateResponse, error)`
      info	[Changelog] - New function `*Python3PackageClient.Delete(context.Context, string, string, string, *Python3PackageClientDeleteOptions) (Python3PackageClientDeleteResponse, error)`
      info	[Changelog] - New function `*Python3PackageClient.Get(context.Context, string, string, string, *Python3PackageClientGetOptions) (Python3PackageClientGetResponse, error)`
      info	[Changelog] - New function `*Python3PackageClient.NewListByAutomationAccountPager(string, string, *Python3PackageClientListByAutomationAccountOptions) *runtime.Pager[Python3PackageClientListByAutomationAccountResponse]`
      info	[Changelog] - New function `*Python3PackageClient.Update(context.Context, string, string, string, PythonPackageUpdateParameters, *Python3PackageClientUpdateOptions) (Python3PackageClientUpdateResponse, error)`
      info	[Changelog] - New struct `Dimension`
      info	[Changelog] - New struct `LogSpecification`
      info	[Changelog] - New struct `MetricSpecification`
      info	[Changelog] - New struct `OperationPropertiesFormat`
      info	[Changelog] - New struct `OperationPropertiesFormatServiceSpecification`
      info	[Changelog] - New struct `Python3PackageClient`
      info	[Changelog] - New struct `Python3PackageClientListByAutomationAccountResponse`
      info	[Changelog] - New struct `UserAssignedIdentitiesProperties`
      info	[Changelog] - New field `Parameters` in struct `DscConfigurationClientUpdateWithJSONOptions`
      info	[Changelog] - New field `Parameters` in struct `DscConfigurationClientUpdateWithTextOptions`
      info	[Changelog] - New field `Origin` in struct `Operation`
      info	[Changelog] - New field `Properties` in struct `Operation`
      info	[Changelog] - New field `Description` in struct `OperationDisplay`
      info	[Changelog]
      info	[Changelog] Total 6 breaking change(s), 26 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 1c23efa. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-automation [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 1c23efa. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️automation [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 1c23efa. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.automation [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost
    Copy link

    ghost commented Jan 30, 2023

    Thank you for your contribution sushil490023! We will review the pull request and get back to you soon.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 30, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/automation/armautomation Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    .Net Azure.ResourceManager.Automation Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-automation Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @openapi-workflow-bot
    Copy link

    Hi @sushil490023, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @sushil490023
    Copy link
    Contributor Author

    Business' Justification : With last API introduction changes its kind of break changes which is impacting customer.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 1, 2023
    @jianyexi
    Copy link
    Contributor

    jianyexi commented Feb 2, 2023

    @qiaozha @fengzhou-msft could you help with the SDK generation failure ?
    @tadelesh could you help with the Go SDK breaking change ?

    @tadelesh tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Feb 2, 2023
    @qiaozha
    Copy link
    Member

    qiaozha commented Feb 2, 2023

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @fengzhou-msft
    Copy link
    Member

    azure-sdk-for-net-track2 failure is not related to this PR. It can be ignored for the purpose of PR review.

    @live1206 live1206 added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Feb 2, 2023
    @live1206 live1206 merged commit 1c23efa into Azure:main Feb 2, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Automation BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go customer-reported Issues that are reported by GitHub users external to the Azure organization. resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    8 participants