Skip to content

Conversation

seaeunlee14
Copy link
Contributor

@seaeunlee14 seaeunlee14 commented Feb 14, 2023

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@seaeunlee14 seaeunlee14 requested a review from giakas as a code owner February 14, 2023 18:42
@openapi-workflow-bot
Copy link

Hi, @seaeunlee14 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 14, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️Breaking Change(Cross-Version): 42 Warnings warning [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    Accounts.json 2023-01-01(0cdb206) 2021-11-01(main)
    Accounts.json 2023-01-01(0cdb206) 2019-05-01-preview(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Media/mediaservices/{accountName}' removed or restructured?
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L857:5
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '204'.
    New: Accounts/stable/2023-01-01/Accounts.json#L1127:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Accounts/stable/2023-01-01/Accounts.json#L1166:11
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Accounts/stable/2023-01-01/Accounts.json#L298:9
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L214:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Accounts/stable/2023-01-01/Accounts.json#L250:11
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L178:11
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Accounts/stable/2023-01-01/Accounts.json#L928:13
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L469:13
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: common-types/resource-management/v2/types.json#L332:9
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L380:9
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: common-types/resource-management/v2/types.json#L307:11
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L369:11
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Accounts/stable/2023-01-01/Accounts.json#L959:13
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L503:13
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Accounts/stable/2023-01-01/Accounts.json#L999:13
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L543:13
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Accounts/stable/2023-01-01/Accounts.json#L1077:13
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L591:13
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Accounts/stable/2023-01-01/Accounts.json#L1132:13
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L639:13
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Accounts/stable/2023-01-01/Accounts.json#L1212:13
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L704:13
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Accounts/stable/2023-01-01/Accounts.json#L1189:13
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L681:13
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Accounts/stable/2023-01-01/Accounts.json#L1240:13
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L731:13
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Accounts/stable/2023-01-01/Accounts.json#L1639:13
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L784:13
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Accounts/stable/2023-01-01/Accounts.json#L1803:13
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L828:13
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Accounts/stable/2023-01-01/Accounts.json#L885:11
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L440:11
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Accounts/stable/2023-01-01/Accounts.json#L1809:13
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L834:13
    ⚠️ 1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
    New: Accounts/stable/2023-01-01/Accounts.json#L557:7
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L328:7
    ⚠️ 1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
    New: Accounts/stable/2023-01-01/Accounts.json#L557:7
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L344:7
    ⚠️ 1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
    New: common-types/resource-management/v2/types.json#L54:7
    Old: Accounts/preview/2019-05-01-preview/Common.json#L43:7
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: common-types/resource-management/v2/types.json#L289:9
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L355:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: common-types/resource-management/v2/types.json#L294:9
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L359:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: common-types/resource-management/v2/types.json#L299:9
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L363:9
    ⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
    New: common-types/resource-management/v2/types.json#L304:9
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L367:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Accounts/stable/2023-01-01/Accounts.json#L1212:13
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L704:13
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was '@odata.nextLink' renamed or removed?
    New: Accounts/stable/2023-01-01/Accounts.json#L866:7
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L389:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'location' renamed or removed?
    New: Accounts/stable/2023-01-01/Accounts.json#L577:7
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L328:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'id' renamed or removed?
    New: Accounts/stable/2023-01-01/Accounts.json#L577:7
    Old: Accounts/preview/2019-05-01-preview/Accounts.json#L328:7
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-account-2023-01 package-account-2023-01(0cdb206) default(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Accounts/stable/2023-01-01/Accounts.json#L411
    ProvisioningStateValidation ProvisioningState must have terminal states: Succeeded, Failed and Canceled.
    Location: Accounts/stable/2023-01-01/Accounts.json#L476
    GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Accounts/stable/2023-01-01/Accounts.json#L665
    GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Accounts/stable/2023-01-01/Accounts.json#L672
    GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Accounts/stable/2023-01-01/Accounts.json#L691
    GuidUsage Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board.
    Location: Accounts/stable/2023-01-01/Accounts.json#L698
    ResourceNameRestriction The resource name parameter 'accountName' should be defined with a 'pattern' restriction.
    Location: Accounts/stable/2023-01-01/Accounts.json#L985
    CreateOperationAsyncResponseValidation An async PUT operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Accounts/stable/2023-01-01/Accounts.json#L1028
    ResourceNameRestriction The resource name parameter 'accountName' should be defined with a 'pattern' restriction.
    Location: Accounts/stable/2023-01-01/Accounts.json#L1229
    ResourceNameRestriction The resource name parameter 'accountName' should be defined with a 'pattern' restriction.
    Location: Accounts/stable/2023-01-01/Accounts.json#L1279
    GetCollectionResponseSchema The response in the GET collection operation 'PrivateLinkResources_List' does not match the response definition in the individual GET operation 'PrivateLinkResources_Get' .
    Location: Accounts/stable/2023-01-01/Accounts.json#L1332
    ResourceNameRestriction The resource name parameter 'accountName' should be defined with a 'pattern' restriction.
    Location: Accounts/stable/2023-01-01/Accounts.json#L1332
    ResourceNameRestriction The resource name parameter 'accountName' should be defined with a 'pattern' restriction.
    Location: Accounts/stable/2023-01-01/Accounts.json#L1376
    GetCollectionResponseSchema The response in the GET collection operation 'PrivateEndpointConnections_List' does not match the response definition in the individual GET operation 'PrivateEndpointConnections_Get' .
    Location: Accounts/stable/2023-01-01/Accounts.json#L1426
    ResourceNameRestriction The resource name parameter 'accountName' should be defined with a 'pattern' restriction.
    Location: Accounts/stable/2023-01-01/Accounts.json#L1426
    ResourceNameRestriction The resource name parameter 'accountName' should be defined with a 'pattern' restriction.
    Location: Accounts/stable/2023-01-01/Accounts.json#L1470
    ResourceNameRestriction The resource name parameter 'locationName' should be defined with a 'pattern' restriction.
    Location: Accounts/stable/2023-01-01/Accounts.json#L1625
    ResourceNameRestriction The resource name parameter 'locationName' should be defined with a 'pattern' restriction.
    Location: Accounts/stable/2023-01-01/Accounts.json#L1675
    ResourceNameRestriction The resource name parameter 'locationName' should be defined with a 'pattern' restriction.
    Location: Accounts/stable/2023-01-01/Accounts.json#L1729
    GetOperation200 The get operation should only return 200.
    Location: Accounts/stable/2023-01-01/Accounts.json#L1741
    XmsParameterLocation The parameter 'SubscriptionId' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
    Location: Accounts/stable/2023-01-01/Accounts.json#L1834
    XmsParameterLocation The parameter 'ApiVersion' is defined in global parameters section without 'x-ms-parameter-location' extension. This would add the parameter as the client property. Please ensure that this is exactly you want. If so, apply the extension 'x-ms-parameter-location': 'client'. Else, apply the extension 'x-ms-parameter-location': 'method'.
    Location: Accounts/stable/2023-01-01/Accounts.json#L1849
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Accounts/stable/2023-01-01/Accounts.json#L64
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Accounts/stable/2023-01-01/Accounts.json#L196
    ⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Accounts/stable/2023-01-01/Accounts.json#L298
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Accounts/stable/2023-01-01/Accounts.json#L302
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Accounts/stable/2023-01-01/Accounts.json#L334
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Accounts/stable/2023-01-01/Accounts.json#L602
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Accounts/stable/2023-01-01/Accounts.json#L611
    ⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
    Location: Accounts/stable/2023-01-01/Accounts.json#L628
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/mediaservices/resource-manager/readme.md
    tag: specification/mediaservices/resource-manager/readme.md#tag-package-account-2023-01
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
    Validation passes for ServiceAPIReadinessTest.

    Tag package-account-2023-01; Prod region: Deployed

    Test run on region: westcentralus; Operation coverage: total: 102, untested: 30, failed: 0, passed: 72

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 14, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking




    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from 51d4c24. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:760
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 760 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • Azure.ResourceManager.Media [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 51d4c24. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.5.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.5.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-media [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation LiveEventsOperations.begin_list_get_status
      info	[Changelog]   - Added operation LiveEventsOperations.begin_list_get_stream_events
      info	[Changelog]   - Added operation LiveEventsOperations.begin_list_get_track_ingest_heartbeats
      info	[Changelog]   - Model LiveEventInput has a new parameter timed_metadata_endpoints
      info	[Changelog]   - Model MediaService has a new parameter minimum_tls_version
      info	[Changelog]   - Model MediaServiceUpdate has a new parameter minimum_tls_version
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 51d4c24. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip available: 22.3.1 -> 23.0
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-mediaservices [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 51d4c24. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/mediaservices/armmediaservices [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New type alias `LiveEventHealthStatus` with values `LiveEventHealthStatusExcellent`, `LiveEventHealthStatusGood`, `LiveEventHealthStatusPoor`
      info	[Changelog] - New type alias `LiveEventState` with values `LiveEventStateRunning`, `LiveEventStateStopped`
      info	[Changelog] - New type alias `LiveEventStreamEventLevel` with values `LiveEventStreamEventLevelCritical`, `LiveEventStreamEventLevelError`, `LiveEventStreamEventLevelInformation`, `LiveEventStreamEventLevelWarning`
      info	[Changelog] - New type alias `LiveEventStreamEventMaxTimeMediaType` with values `LiveEventStreamEventMaxTimeMediaTypeAudio`, `LiveEventStreamEventMaxTimeMediaTypeVideo`
      info	[Changelog] - New type alias `LiveEventStreamEventMediaType` with values `LiveEventStreamEventMediaTypeAudio`, `LiveEventStreamEventMediaTypeVideo`
      info	[Changelog] - New type alias `LiveEventStreamEventMinTimeMediaType` with values `LiveEventStreamEventMinTimeMediaTypeAudio`, `LiveEventStreamEventMinTimeMediaTypeVideo`
      info	[Changelog] - New type alias `LiveEventStreamEventType` with values `LiveEventStreamEventTypeStreamEventBeginIngest`, `LiveEventStreamEventTypeStreamEventChunkDropped`, `LiveEventStreamEventTypeStreamEventDiscontinuity`, `LiveEventStreamEventTypeStreamEventEndIngest`, `LiveEventStreamEventTypeStreamEventFirstChunkReceived`, `LiveEventStreamEventTypeStreamEventInvalidConnection`, `LiveEventStreamEventTypeStreamEventUnalignedKeyFrames`, `LiveEventStreamEventTypeStreamEventUnalignedPresentation`
      info	[Changelog] - New type alias `LiveEventTrackEventType` with values `LiveEventTrackEventTypeTrackEventIngestHeartbeat`
      info	[Changelog] - New type alias `LiveEventTrackType` with values `LiveEventTrackTypeAudio`, `LiveEventTrackTypeVideo`
      info	[Changelog] - New type alias `MinimumTLSVersion` with values `MinimumTLSVersionTls10`, `MinimumTLSVersionTls11`, `MinimumTLSVersionTls12`, `MinimumTLSVersionTls13`
      info	[Changelog] - New function `*LiveEventsClient.BeginListGetStatus(context.Context, string, string, string, *LiveEventsClientBeginListGetStatusOptions) (*runtime.Poller[*runtime.Pager[LiveEventsClientListGetStatusResponse]], error)`
      info	[Changelog] - New function `*LiveEventsClient.BeginListGetStreamEvents(context.Context, string, string, string, *LiveEventsClientBeginListGetStreamEventsOptions) (*runtime.Poller[*runtime.Pager[LiveEventsClientListGetStreamEventsResponse]], error)`
      info	[Changelog] - New function `*LiveEventsClient.BeginListGetTrackIngestHeartbeats(context.Context, string, string, string, *LiveEventsClientBeginListGetTrackIngestHeartbeatsOptions) (*runtime.Poller[*runtime.Pager[LiveEventsClientListGetTrackIngestHeartbeatsResponse]], error)`
      info	[Changelog] - New struct `LiveEventGetStatusResult`
      info	[Changelog] - New struct `LiveEventGetStreamEventsResult`
      info	[Changelog] - New struct `LiveEventGetTrackIngestHeartbeatsResult`
      info	[Changelog] - New struct `LiveEventIngestInterruption`
      info	[Changelog] - New struct `LiveEventIngestion`
      info	[Changelog] - New struct `LiveEventStatus`
      info	[Changelog] - New struct `LiveEventStreamEvent`
      info	[Changelog] - New struct `LiveEventStreamEventData`
      info	[Changelog] - New struct `LiveEventTimedMetadataEndpoint`
      info	[Changelog] - New struct `LiveEventTrackEvent`
      info	[Changelog] - New struct `LiveEventTrackEventData`
      info	[Changelog] - New struct `LiveEventTrackStatus`
      info	[Changelog] - New struct `LiveEventsClientListGetStatusResponse`
      info	[Changelog] - New struct `LiveEventsClientListGetStreamEventsResponse`
      info	[Changelog] - New struct `LiveEventsClientListGetTrackIngestHeartbeatsResponse`
      info	[Changelog] - New field `TimedMetadataEndpoints` in struct `LiveEventInput`
      info	[Changelog] - New field `MinimumTLSVersion` in struct `MediaServiceProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 75 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 51d4c24. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-mediaservices [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation LiveEvents.beginListGetStatusAndWait
      info	[Changelog]   - Added operation LiveEvents.beginListGetStreamEventsAndWait
      info	[Changelog]   - Added operation LiveEvents.beginListGetTrackIngestHeartbeatsAndWait
      info	[Changelog]   - Added Interface LiveEventGetStatusResult
      info	[Changelog]   - Added Interface LiveEventGetStreamEventsResult
      info	[Changelog]   - Added Interface LiveEventGetTrackIngestHeartbeatsResult
      info	[Changelog]   - Added Interface LiveEventIngestInterruption
      info	[Changelog]   - Added Interface LiveEventIngestion
      info	[Changelog]   - Added Interface LiveEventsListGetStatusHeaders
      info	[Changelog]   - Added Interface LiveEventsListGetStatusOptionalParams
      info	[Changelog]   - Added Interface LiveEventsListGetStreamEventsHeaders
      info	[Changelog]   - Added Interface LiveEventsListGetStreamEventsOptionalParams
      info	[Changelog]   - Added Interface LiveEventsListGetTrackIngestHeartbeatsHeaders
      info	[Changelog]   - Added Interface LiveEventsListGetTrackIngestHeartbeatsOptionalParams
      info	[Changelog]   - Added Interface LiveEventStatus
      info	[Changelog]   - Added Interface LiveEventStreamEvent
      info	[Changelog]   - Added Interface LiveEventStreamEventData
      info	[Changelog]   - Added Interface LiveEventTimedMetadataEndpoint
      info	[Changelog]   - Added Interface LiveEventTrackEvent
      info	[Changelog]   - Added Interface LiveEventTrackEventData
      info	[Changelog]   - Added Interface LiveEventTrackStatus
      info	[Changelog]   - Added Type Alias LiveEventHealthStatus
      info	[Changelog]   - Added Type Alias LiveEventsListGetStatusResponse
      info	[Changelog]   - Added Type Alias LiveEventsListGetStreamEventsResponse
      info	[Changelog]   - Added Type Alias LiveEventsListGetTrackIngestHeartbeatsResponse
      info	[Changelog]   - Added Type Alias LiveEventState
      info	[Changelog]   - Added Type Alias LiveEventStreamEventLevel
      info	[Changelog]   - Added Type Alias LiveEventStreamEventMaxTimeMediaType
      info	[Changelog]   - Added Type Alias LiveEventStreamEventMediaType
      info	[Changelog]   - Added Type Alias LiveEventStreamEventMinTimeMediaType
      info	[Changelog]   - Added Type Alias LiveEventStreamEventType
      info	[Changelog]   - Added Type Alias LiveEventTrackEventType
      info	[Changelog]   - Added Type Alias LiveEventTrackType
      info	[Changelog]   - Added Type Alias MinimumTlsVersion
      info	[Changelog]   - Interface LiveEventInput has a new optional parameter timedMetadataEndpoints
      info	[Changelog]   - Interface MediaService has a new optional parameter minimumTlsVersion
      info	[Changelog]   - Interface MediaServiceUpdate has a new optional parameter minimumTlsVersion
      info	[Changelog]   - Added Enum KnownLiveEventHealthStatus
      info	[Changelog]   - Added Enum KnownLiveEventState
      info	[Changelog]   - Added Enum KnownLiveEventStreamEventLevel
      info	[Changelog]   - Added Enum KnownLiveEventStreamEventMaxTimeMediaType
      info	[Changelog]   - Added Enum KnownLiveEventStreamEventMediaType
      info	[Changelog]   - Added Enum KnownLiveEventStreamEventMinTimeMediaType
      info	[Changelog]   - Added Enum KnownLiveEventStreamEventType
      info	[Changelog]   - Added Enum KnownLiveEventTrackEventType
      info	[Changelog]   - Added Enum KnownLiveEventTrackType
      info	[Changelog]   - Added Enum KnownMinimumTlsVersion
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 51d4c24. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️mediaservices [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 51d4c24. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.mediaservices [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the Media Services label Feb 14, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 14, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/mediaservices/armmediaservices https://apiview.dev/Assemblies/Review/53c2407923944469802cf0d198ed3412
    JavaScript @azure/arm-mediaservices https://apiview.dev/Assemblies/Review/0453d38b4193494686ad1541bb53b262

    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 14, 2023
    @openapi-workflow-bot
    Copy link

    Hi, @seaeunlee14 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @@ -26,7 +26,7 @@ These are the global settings for the MediaServices API.

    ``` yaml
    openapi-type: arm
    tag: package-streaming-2022-11
    tag: package-2023-01
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Can you rename the tag to package-account-2023-01

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    done

    @giakas
    Copy link
    Contributor

    giakas commented Feb 14, 2023

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-workflow-bot
    Copy link

    Hi, @seaeunlee14, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline


    These settings apply only when `--tag=package-account-2023-01` is specified on the command line.

    ```yaml $(tag) == 'package-account-2023-01'
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Do you need the space here, similar to how you added below?

    Copy link
    Member

    @TimLovellSmith TimLovellSmith left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @TimLovellSmith TimLovellSmith added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Feb 16, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 16, 2023
    @tianxchen-ms tianxchen-ms merged commit 51d4c24 into main Feb 16, 2023
    @tianxchen-ms tianxchen-ms deleted the seaeunlee14-mediaservices-Microsoft.Media-2023-01-01 branch February 16, 2023 03:11
    ghost pushed a commit to Azure/azure-resource-manager-schemas that referenced this pull request Feb 16, 2023
    aviyerMSFT pushed a commit to aviyerMSFT/azure-rest-api-specs that referenced this pull request Mar 22, 2023
    …perty (Azure#22614)
    
    * Adds base for updating Microsoft.Media/Accounts from version stable/2021-11-01 to version 2023-01-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * add tls version
    
    * add default
    
    * add to readme test
    
    * fix readme
    
    ---------
    
    Co-authored-by: Sea Eun Lee <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-MissingBaseCommit Media Services new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants