Skip to content

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented Mar 22, 2023

@msyyc msyyc requested a review from Wzb123456789 as a code owner March 22, 2023 04:58
@msyyc msyyc self-assigned this Mar 22, 2023
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 22, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
compared tags (via openapi-validator v2.0.0) new version base version
default default(c4a1dd7) default(main)
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
Validation passes for ServiceAPIReadinessTest.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-workflow-bot
Copy link

Hi @msyyc, this service has enabled Service API Toolset. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth., please review this pull request if it's intentional or reject it if it's not expected. Normally, all the specification or example changes should start with PR created in ADO.

  • You can refer to Service API Toolset Introduction for details.
  • Please contact service focal contacts or Service API Toolset Support Channel if need further help.
  • @ghost ghost added the Container Service label Mar 22, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 22, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/containerservice/armcontainerservice - 3.0.0
    +	Const `ManagedClusterSKUNameBasic` from type alias `ManagedClusterSKUName` has been removed
    +	Const `ManagedClusterSKUTierPaid` from type alias `ManagedClusterSKUTier` has been removed
    azure-sdk-for-js - @azure/arm-containerservice - 18.0.0
    +	Enum KnownManagedClusterSKUName no longer has value Basic
    +	Enum KnownManagedClusterSKUTier no longer has value Paid
    +	Removed Enum KnownContainerServiceStorageProfileTypes
    +	Removed Enum KnownContainerServiceVMSizeTypes
    azure-sdk-for-python-track2 - track2_azure-mgmt-containerservice - 21.2.0
    +	Model ContainerServiceNetworkProfile no longer has parameter ebpf_dataplane
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 08788e3. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-containerservice [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model ContainerServiceNetworkProfile has a new parameter network_dataplane
      info	[Changelog]   - Model ManagedCluster has a new parameter service_mesh_profile
      info	[Changelog]   - Model ManagedClusterIngressProfileWebAppRouting has a new parameter identity
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model ContainerServiceNetworkProfile no longer has parameter ebpf_dataplane
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 08788e3. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-containerservicemicrosoftcontainerserviceaks-generated [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 08788e3. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/containerservice/armcontainerservice [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Const `ManagedClusterSKUNameBasic` from type alias `ManagedClusterSKUName` has been removed
      info	[Changelog] - Const `ManagedClusterSKUTierPaid` from type alias `ManagedClusterSKUTier` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `ManagedClusterSKUNameBase` added to enum type `ManagedClusterSKUName`
      info	[Changelog] - New value `ManagedClusterSKUTierStandard` added to enum type `ManagedClusterSKUTier`
      info	[Changelog] - New value `NetworkPolicyCilium` added to enum type `NetworkPolicy`
      info	[Changelog] - New enum type `NetworkDataplane` with values `NetworkDataplaneAzure`, `NetworkDataplaneCilium`
      info	[Changelog] - New enum type `NetworkPluginMode` with values `NetworkPluginModeOverlay`
      info	[Changelog] - New function `*AgentPoolsClient.BeginAbortLatestOperation(context.Context, string, string, string, *AgentPoolsClientBeginAbortLatestOperationOptions) (*runtime.Poller[AgentPoolsClientAbortLatestOperationResponse], error)`
      info	[Changelog] - New function `NewClientFactory(string, azcore.TokenCredential, *arm.ClientOptions) (*ClientFactory, error)`
      info	[Changelog] - New function `*ClientFactory.NewAgentPoolsClient() *AgentPoolsClient`
      info	[Changelog] - New function `*ClientFactory.NewMaintenanceConfigurationsClient() *MaintenanceConfigurationsClient`
      info	[Changelog] - New function `*ClientFactory.NewManagedClustersClient() *ManagedClustersClient`
      info	[Changelog] - New function `*ClientFactory.NewOperationsClient() *OperationsClient`
      info	[Changelog] - New function `*ClientFactory.NewPrivateEndpointConnectionsClient() *PrivateEndpointConnectionsClient`
      info	[Changelog] - New function `*ClientFactory.NewPrivateLinkResourcesClient() *PrivateLinkResourcesClient`
      info	[Changelog] - New function `*ClientFactory.NewResolvePrivateLinkServiceIDClient() *ResolvePrivateLinkServiceIDClient`
      info	[Changelog] - New function `*ClientFactory.NewSnapshotsClient() *SnapshotsClient`
      info	[Changelog] - New function `*ManagedClustersClient.BeginAbortLatestOperation(context.Context, string, string, *ManagedClustersClientBeginAbortLatestOperationOptions) (*runtime.Poller[ManagedClustersClientAbortLatestOperationResponse], error)`
      info	[Changelog] - New struct `ClientFactory`
      info	[Changelog] - New struct `ManagedClusterAzureMonitorProfile`
      info	[Changelog] - New struct `ManagedClusterAzureMonitorProfileKubeStateMetrics`
      info	[Changelog] - New struct `ManagedClusterAzureMonitorProfileMetrics`
      info	[Changelog] - New struct `ManagedClusterSecurityProfileImageCleaner`
      info	[Changelog] - New struct `ManagedClusterSecurityProfileWorkloadIdentity`
      info	[Changelog] - New field `AzureMonitorProfile` in struct `ManagedClusterProperties`
      info	[Changelog] - New field `ImageCleaner` in struct `ManagedClusterSecurityProfile`
      info	[Changelog] - New field `WorkloadIdentity` in struct `ManagedClusterSecurityProfile`
      info	[Changelog] - New field `NetworkDataplane` in struct `NetworkProfile`
      info	[Changelog] - New field `NetworkPluginMode` in struct `NetworkProfile`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 34 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 08788e3. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-containerservice [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Interface ManagedClusterSecurityProfileImageCleaner
      info	[Changelog]   - Added Interface ManagedClusterSecurityProfileWorkloadIdentity
      info	[Changelog]   - Added Type Alias NetworkDataplane
      info	[Changelog]   - Added Type Alias NetworkPluginMode
      info	[Changelog]   - Interface ContainerServiceNetworkProfile has a new optional parameter networkDataplane
      info	[Changelog]   - Interface ContainerServiceNetworkProfile has a new optional parameter networkPluginMode
      info	[Changelog]   - Interface ManagedClusterSecurityProfile has a new optional parameter imageCleaner
      info	[Changelog]   - Interface ManagedClusterSecurityProfile has a new optional parameter workloadIdentity
      info	[Changelog]   - Added Enum KnownNetworkDataplane
      info	[Changelog]   - Added Enum KnownNetworkPluginMode
      info	[Changelog]   - Enum KnownNetworkPolicy has a new value Cilium
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed Enum KnownContainerServiceStorageProfileTypes
      info	[Changelog]   - Removed Enum KnownContainerServiceVMSizeTypes
      info	[Changelog]   - Enum KnownManagedClusterSKUName no longer has value Basic
      info	[Changelog]   - Enum KnownManagedClusterSKUTier no longer has value Paid
    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 08788e3. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
      cannot force update branch 'sdkAuto/containerservice' as it is the current HEAD of the repository.
      Error: cannot force update branch 'sdkAuto/containerservice' as it is the current HEAD of the repository.
    • ️✔️containerservice [View full logs
    • ️✔️containerservice [View full logs
      error	Fatal error: cannot force update branch 'sdkAuto/containerservice' as it is the current HEAD of the repository.
      error	The following packages are still pending:
      error		containerservice
      error		containerservice
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 08788e3. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.
      HttpError: You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.
          at /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/@[email protected][email protected]/node_modules/@octokit/request/dist-node/index.js:86:21
          at runMicrotasks (<anonymous>)
          at processTicksAndRejections (node:internal/process/task_queues:96:5)
          at async workflowPkgUpdatePR (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:397:21)
          at async Object.exports.workflowPkgMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflowPackage.js:63:5)
          at async workflowHandleReadmeMdOrCadlProject (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:216:9)
          at async Object.exports.workflowMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:94:9)
          at async Object.exports.sdkAutoMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:191:13)
          at async /mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
    • ️✔️Az.containerservice.DefaultTag [View full logs
      error	Fatal error: You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later.
      error	The following packages are still pending:
      error		Az.containerservice.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Mar 22, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/containerservice/armcontainerservice Create ApiView failed. Please ask PR assignee for help
    .Net Azure.ResourceManager.ContainerService There is no API change compared with the previous version
    JavaScript @azure/arm-containerservice https://apiview.dev/Assemblies/Review/818118591ef8405d99525ed6b6fe3709

    @openapi-workflow-bot openapi-workflow-bot bot added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Mar 22, 2023
    @openapi-workflow-bot
    Copy link

    Hi, @msyyc Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @msyyc msyyc merged commit 08788e3 into main Mar 23, 2023
    @msyyc msyyc deleted the msyyc-patch-3 branch March 23, 2023 02:24
    JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants