Skip to content

Conversation

rohinisharma
Copy link
Contributor

@rohinisharma rohinisharma commented Apr 14, 2023

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
    April
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
    April
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@rohinisharma rohinisharma requested a review from naveedaz as a code owner April 14, 2023 20:43
@openapi-workflow-bot
Copy link

Hi, @rohinisharma Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 14, 2023
    @openapi-workflow-bot
    Copy link

    Hi, @rohinisharma your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Apr 14, 2023
    @ghost
    Copy link

    ghost commented Apr 14, 2023

    Thank you for your contribution rohinisharma! We will review the pull request and get back to you soon.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 14, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.10.4)] new version base version
    ResourceProvider.json 2023-01-01(eb7b549) 2022-09-01(main)
    ️❌LintDiff: 1 Errors, 13 Warnings failed [Detail]
    compared tags (via openapi-validator v2.1.1) new version base version
    package-2023-01 package-2023-01(eb7b549) package-2023-01(release-web-2023-01-01)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    PathForNestedResource The path for nested resource doest not meet the valid resource pattern.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L551
    RPC-Uri-V1-06,RPC-Put-V1-02
    ⚠️ ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L511
    ⚠️ PageableOperation Based on the response model schema, operation 'GetUsagesInLocation' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L511
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L515
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L515
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L515
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L515
    ⚠️ ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L552
    ⚠️ PageableOperation Based on the response model schema, operation 'GetZoneRedundantUsagesInLocation' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L552
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L556
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L556
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L556
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L556
    ⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get usages in location for subscription
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L585


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    PathForPutOperation The path for 'put' operation must be under a subscription and resource group.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L18
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L31
    PutResponseSchemaDescription Any Put MUST contain 200 and 201 return codes.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L61
    PathForPutOperation The path for 'put' operation must be under a subscription and resource group.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L106
    PutResponseSchemaDescription Any Put MUST contain 200 and 201 return codes.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L163
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L320
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L497
    PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L635
    PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L714
    TopLevelResourcesListBySubscription The top-level resource 'SourceControl' does not have list by subscription operation, please add it.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L1251
    ⚠️ XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L19
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L23
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L23
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L23
    ⚠️ XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L43
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L47
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L47
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L47
    ⚠️ ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L78
    ⚠️ XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L78
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L82
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L82
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L82
    ⚠️ RequiredReadOnlySystemData The response of operation:'GetSourceControl' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L107
    ⚠️ XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L107
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'subscriptionId'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L111
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'resourceGroupName'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L111
    ⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'api-version'.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L111
    ⚠️ RequiredReadOnlySystemData The response of operation:'UpdateSourceControl' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L138
    ⚠️ XmsExamplesRequired Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations.
    Location: Microsoft.Web/stable/2023-01-01/ResourceProvider.json#L138
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 14, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️⚠️SDK Breaking Change Tracking warning [Detail]

    Breaking Changes Tracking

    ⚠️azure-sdk-for-python-track2 - track2_azure-mgmt-web - 7.1.0
    +	Model Site no longer has parameter managed_environment_id
    +	Model SiteConfig no longer has parameter elastic_web_app_scale_limit
    +	Model SiteConfig no longer has parameter ip_security_restrictions_default_action
    +	Model SiteConfig no longer has parameter metadata
    +	Model SiteConfig no longer has parameter scm_ip_security_restrictions_default_action
    +	Model SiteConfigResource no longer has parameter elastic_web_app_scale_limit
    +	Model SiteConfigResource no longer has parameter ip_security_restrictions_default_action
    +	Model SiteConfigResource no longer has parameter metadata
    +	Model SiteConfigResource no longer has parameter scm_ip_security_restrictions_default_action
    +	Model StaticSiteARMResource no longer has parameter database_connections
    +	Model StaticSiteBuildARMResource no longer has parameter database_connections
    +	Model StaticSitePatchResource no longer has parameter database_connections
    +	Removed operation StaticSitesOperations.create_or_update_basic_auth
    +	Removed operation StaticSitesOperations.create_or_update_build_database_connection
    +	Removed operation StaticSitesOperations.create_or_update_database_connection
    +	Removed operation StaticSitesOperations.delete_build_database_connection
    +	Removed operation StaticSitesOperations.delete_database_connection
    +	Removed operation StaticSitesOperations.get_basic_auth
    +	Removed operation StaticSitesOperations.get_build_database_connection
    +	Removed operation StaticSitesOperations.get_build_database_connection_with_details
    +	Removed operation StaticSitesOperations.get_build_database_connections
    +	Removed operation StaticSitesOperations.get_build_database_connections_with_details
    +	Removed operation StaticSitesOperations.get_database_connection
    +	Removed operation StaticSitesOperations.get_database_connection_with_details
    +	Removed operation StaticSitesOperations.get_database_connections
    +	Removed operation StaticSitesOperations.get_database_connections_with_details
    +	Removed operation StaticSitesOperations.list_basic_auth
    +	Removed operation StaticSitesOperations.update_build_database_connection
    +	Removed operation StaticSitesOperations.update_database_connection
    +	Removed operation WebAppsOperations.deploy_workflow_artifacts
    +	Removed operation WebAppsOperations.deploy_workflow_artifacts_slot
    +	Removed operation WebAppsOperations.get_instance_workflow_slot
    +	Removed operation WebAppsOperations.get_workflow
    +	Removed operation WebAppsOperations.list_instance_workflows_slot
    +	Removed operation WebAppsOperations.list_workflows
    +	Removed operation WebAppsOperations.list_workflows_connections
    +	Removed operation WebAppsOperations.list_workflows_connections_slot
    ️✔️azure-sdk-for-go - sdk/resourcemanager/appservice/armappservice - 3.0.0
    +	Field `Interface` of struct `WebAppsClientCreateOneDeployOperationResponse` has been removed
    +	Field `Interface` of struct `WebAppsClientGetOneDeployStatusResponse` has been removed

    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs] Generate from dfac8d1606f1186e7eefea6a3864f495f43d6762. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:800
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 800 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • Azure.ResourceManager.AppService [View full logs]  [Preview SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs] Generate from dfac8d1606f1186e7eefea6a3864f495f43d6762. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  notice
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.6
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.6>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-web [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Model Site no longer has parameter managed_environment_id
      info	[Changelog]   - Model SiteConfig no longer has parameter elastic_web_app_scale_limit
      info	[Changelog]   - Model SiteConfig no longer has parameter ip_security_restrictions_default_action
      info	[Changelog]   - Model SiteConfig no longer has parameter metadata
      info	[Changelog]   - Model SiteConfig no longer has parameter scm_ip_security_restrictions_default_action
      info	[Changelog]   - Model SiteConfigResource no longer has parameter elastic_web_app_scale_limit
      info	[Changelog]   - Model SiteConfigResource no longer has parameter ip_security_restrictions_default_action
      info	[Changelog]   - Model SiteConfigResource no longer has parameter metadata
      info	[Changelog]   - Model SiteConfigResource no longer has parameter scm_ip_security_restrictions_default_action
      info	[Changelog]   - Model StaticSiteARMResource no longer has parameter database_connections
      info	[Changelog]   - Model StaticSiteBuildARMResource no longer has parameter database_connections
      info	[Changelog]   - Model StaticSitePatchResource no longer has parameter database_connections
      info	[Changelog]   - Removed operation StaticSitesOperations.create_or_update_basic_auth
      info	[Changelog]   - Removed operation StaticSitesOperations.create_or_update_build_database_connection
      info	[Changelog]   - Removed operation StaticSitesOperations.create_or_update_database_connection
      info	[Changelog]   - Removed operation StaticSitesOperations.delete_build_database_connection
      info	[Changelog]   - Removed operation StaticSitesOperations.delete_database_connection
      info	[Changelog]   - Removed operation StaticSitesOperations.get_basic_auth
      info	[Changelog]   - Removed operation StaticSitesOperations.get_build_database_connection
      info	[Changelog]   - Removed operation StaticSitesOperations.get_build_database_connection_with_details
      info	[Changelog]   - Removed operation StaticSitesOperations.get_build_database_connections
      info	[Changelog]   - Removed operation StaticSitesOperations.get_build_database_connections_with_details
      info	[Changelog]   - Removed operation StaticSitesOperations.get_database_connection
      info	[Changelog]   - Removed operation StaticSitesOperations.get_database_connection_with_details
      info	[Changelog]   - Removed operation StaticSitesOperations.get_database_connections
      info	[Changelog]   - Removed operation StaticSitesOperations.get_database_connections_with_details
      info	[Changelog]   - Removed operation StaticSitesOperations.list_basic_auth
      info	[Changelog]   - Removed operation StaticSitesOperations.update_build_database_connection
      info	[Changelog]   - Removed operation StaticSitesOperations.update_database_connection
      info	[Changelog]   - Removed operation WebAppsOperations.deploy_workflow_artifacts
      info	[Changelog]   - Removed operation WebAppsOperations.deploy_workflow_artifacts_slot
      info	[Changelog]   - Removed operation WebAppsOperations.get_instance_workflow_slot
      info	[Changelog]   - Removed operation WebAppsOperations.get_workflow
      info	[Changelog]   - Removed operation WebAppsOperations.list_instance_workflows_slot
      info	[Changelog]   - Removed operation WebAppsOperations.list_workflows
      info	[Changelog]   - Removed operation WebAppsOperations.list_workflows_connections
      info	[Changelog]   - Removed operation WebAppsOperations.list_workflows_connections_slot
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs] Generate from dfac8d1606f1186e7eefea6a3864f495f43d6762. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-appservice-generated [View full logs]  [Preview SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs] Generate from dfac8d1606f1186e7eefea6a3864f495f43d6762. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/appservice/armappservice [View full logs]  [Preview SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Field `Interface` of struct `WebAppsClientCreateOneDeployOperationResponse` has been removed
      info	[Changelog] - Field `Interface` of struct `WebAppsClientGetOneDeployStatusResponse` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New function `*WebSiteManagementClient.GetUsagesInLocation(context.Context, string, *WebSiteManagementClientGetUsagesInLocationOptions) (WebSiteManagementClientGetUsagesInLocationResponse, error)`
      info	[Changelog] - New function `*WebSiteManagementClient.GetZoneRedundantUsagesInLocation(context.Context, string, *WebSiteManagementClientGetZoneRedundantUsagesInLocationOptions) (WebSiteManagementClientGetZoneRedundantUsagesInLocationResponse, error)`
      info	[Changelog] - New struct `OneDeployRequest`
      info	[Changelog] - New field `Request` in struct `WebAppsClientCreateOneDeployOperationOptions`
      info	[Changelog] - New anonymous field `Deployment` in struct `WebAppsClientCreateOneDeployOperationResponse`
      info	[Changelog] - New anonymous field `Deployment` in struct `WebAppsClientGetOneDeployStatusResponse`
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 7 additive change(s).
    ️❌ azure-sdk-for-js failed [Detail]
    • Pipeline Framework Failed [Logs] Generate from dfac8d1606f1186e7eefea6a3864f495f43d6762. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
      unexpected http status code: 500
      Error: unexpected http status code: 500
    • ️✔️@azure/arm-appservice [View full logs
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Interface GetUsagesInLocationOptionalParams
      info	[Changelog]   - Added Interface GetZoneRedundantUsagesInLocationOptionalParams
      info	[Changelog]   - Added Interface OneDeployRequest
      info	[Changelog]   - Added Type Alias GetUsagesInLocationResponse
      info	[Changelog]   - Added Type Alias GetZoneRedundantUsagesInLocationResponse
      info	[Changelog]   - Interface WebAppsCreateOneDeployOperationOptionalParams has a new optional parameter request
      info	[Changelog]   - Added Enum KnownWorkflowState
      error	Fatal error: unexpected http status code: 500
      error	The following packages are still pending:
      error		@azure/arm-appservice
    ️🔄 azure-resource-manager-schemas inProgress [Detail]
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs] Generate from dfac8d1606f1186e7eefea6a3864f495f43d6762. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • Az.web.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.web.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the Web Apps label Apr 14, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 14, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/appservice/armappservice https://apiview.dev/Assemblies/Review/b7cdb18bded14c6a8665e607b916b690
    Java azure-resourcemanager-appservice-generated https://apiview.dev/Assemblies/Review/b77fd6010723450bbaf2b6574070f162

    @edwin-msft
    Copy link
    Contributor

    @rohinisharma be sure to resolve the issues listed here: #23567 (comment)

    You may have to run some tools locally as I've done in past PRs

    @openapi-workflow-bot
    Copy link

    Hi @rohinisharma, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @sjanamma
    Copy link

    sjanamma commented Apr 22, 2023

    Tenant/Provider level APIs that are outside the subscription context must discuss the scenario with PAS team. Partners can send an email to the following email ids to kick start the review.

    SARBACRev, [email protected]

    Alos please fix all the Linter error shown at the link https://github.com/Azure/azure-rest-api-specs/pull/23567/checks?check_run_id=12811212029

    @sjanamma sjanamma added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Apr 22, 2023
    @openapi-workflow-bot
    Copy link

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 22, 2023
    @rohinisharma
    Copy link
    Contributor Author

    @sjanamma

    Linter errors are not part of the changes I am introducing. Also, could you explain how these changes are outside the subscription context? I am adding the /subscriptions/{subscriptionId}/providers/Microsoft.Web/locations/{location}/usages endpoint, which requires a subID.

    @edwin-msft
    Copy link
    Contributor

    There have been two merged PRs that have also had the linter not fully pass:

    #23084
    #23224

    Not sure why it's being enforced here specifically.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview CI-BreakingChange-Go CI-FixRequiredOnFailure customer-reported Issues that are reported by GitHub users external to the Azure organization. resource-manager Web Apps
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    7 participants