Update `pull_request_assignment.yml`: remove `armapireview` and other reviewers for ARM paths, except `rkmanda`. #24566

konrad-jamrozik · 2023-06-25T00:00:17Z

This is a PR made by the Azure SDK Engineering System team.

Original description 6/24/2023

This PR removes armapireview from assignees as it appears to be misconfigured. Likely it doesn't have access. I.e. probably this user https://github.com/armapireview should be given permissions to be assignable to the repositories. This doc might be helpful here.

For context, see this Teams discussion.

This Kusto query (from this doc) shows the affected PRs since 6/10/2023.

14 pull requests were affected. Even though our logs show the assignment was successful, it actually wasn't.

Here is the list of the PRs:

Update 6/25/2023

Per @rkmanda request, I removed all reviewers (not only armapireview) for the ARM paths except him.

Update 7/6/2023

Info from @weshaggard:

you cannot add non-FTE linked accounts into the Azure org do to the SSO sign-in requirements for the org. So, I don’t think it is possible to use a bot for that purpose.

…onfigured

openapi-workflow-bot · 2023-06-25T00:00:21Z

Hi, @konrad-jamrozik Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2023-06-25T00:00:21Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]

Validation passes for ServiceAPIReadinessTest.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-06-25T00:00:22Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

openapi-pipeline-app · 2023-06-25T00:00:24Z

Swagger pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

konrad-jamrozik · 2023-06-25T10:05:46Z

@rkmanda we should either merge this PR ASAP, or an admin of armapireview should follow these instructions to give it access. This (hopefully!) should make the assignment work. We could test it works by trying to assign armapireview to a PR by hand - currently it is not possible, as it doesn't even appear in the list of suggested assignees.

.github/pull_request_assignment.yml

rkmanda

🕐

Removed all other assignees for mgmt. plane PR.

.github/pull_request_assignment.yml

Moved the default mgmt. PR assignment rule.

.github/pull_request_assignment.yml

rkmanda

… reviewers for ARM paths, except `rkmanda`. (Azure#24566) * Update pull_request_assignment.yml: remove armapireview as it is misconfigured * Update pull_request_assignment.yml Removed all other assignees for mgmt. plane PR. * Update pull_request_assignment.yml Moved the default mgmt. PR assignment rule. --------- Co-authored-by: Ray Chen <[email protected]>

Update pull_request_assignment.yml: remove armapireview as it is misc…

017004b

…onfigured

openapi-assignment-bot bot assigned weshaggard Jun 25, 2023

konrad-jamrozik changed the title ~~Update pull_request_assignment.yml: remove armapireview as it is misconfigured.~~ Update pull_request_assignment.yml: remove armapireview as it is misconfigured. Jun 25, 2023

konrad-jamrozik requested a review from rkmanda June 25, 2023 00:00

konrad-jamrozik mentioned this pull request Jun 25, 2023

[Hub Generated] Publish private branch 'InbalZim-storagemover-Microsoft.StorageMover-RPSaaSMaster-2023-07-01-preview' #24390

Merged

11 tasks

rkmanda reviewed Jun 25, 2023

View reviewed changes

.github/pull_request_assignment.yml Outdated Show resolved Hide resolved

rkmanda requested changes Jun 25, 2023

View reviewed changes

konrad-jamrozik changed the title ~~Update pull_request_assignment.yml: remove armapireview as it is misconfigured.~~ Update pull_request_assignment.yml: remove armapireview and other reviewers for ARM paths, except rkmanda. Jun 26, 2023

konrad-jamrozik requested a review from rkmanda June 26, 2023 06:41

Update pull_request_assignment.yml

7f1702e

Removed all other assignees for mgmt. plane PR.

raych1 approved these changes Jun 26, 2023

View reviewed changes

rkmanda reviewed Jun 26, 2023

View reviewed changes

.github/pull_request_assignment.yml Show resolved Hide resolved

rkmanda reviewed Jun 26, 2023

View reviewed changes

.github/pull_request_assignment.yml Show resolved Hide resolved

rkmanda reviewed Jun 26, 2023

View reviewed changes

.github/pull_request_assignment.yml Show resolved Hide resolved

Update pull_request_assignment.yml

8f919b6

Moved the default mgmt. PR assignment rule.

rkmanda reviewed Jun 27, 2023

View reviewed changes

.github/pull_request_assignment.yml Show resolved Hide resolved

rkmanda approved these changes Jun 27, 2023

View reviewed changes

raych1 merged commit b67eccd into main Jun 27, 2023

raych1 deleted the konrad-jamrozik-patch-2 branch June 27, 2023 01:08

konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Aug 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update `pull_request_assignment.yml`: remove `armapireview` and other reviewers for ARM paths, except `rkmanda`. #24566

Update `pull_request_assignment.yml`: remove `armapireview` and other reviewers for ARM paths, except `rkmanda`. #24566

Uh oh!

konrad-jamrozik commented Jun 25, 2023 •

edited

Loading

Uh oh!

openapi-workflow-bot bot commented Jun 25, 2023

Uh oh!

openapi-pipeline-app bot commented Jun 25, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Jun 25, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Jun 25, 2023 •

edited

Loading

Uh oh!

konrad-jamrozik commented Jun 25, 2023 •

edited

Loading

Uh oh!

Uh oh!

rkmanda left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rkmanda left a comment

Uh oh!

Uh oh!

Update pull_request_assignment.yml: remove armapireview and other reviewers for ARM paths, except rkmanda. #24566

Update pull_request_assignment.yml: remove armapireview and other reviewers for ARM paths, except rkmanda. #24566

Uh oh!

Conversation

konrad-jamrozik commented Jun 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Original description 6/24/2023

Update 6/25/2023

Update 7/6/2023

Uh oh!

openapi-workflow-bot bot commented Jun 25, 2023

Uh oh!

openapi-pipeline-app bot commented Jun 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Jun 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openapi-pipeline-app bot commented Jun 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

konrad-jamrozik commented Jun 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

rkmanda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rkmanda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Update `pull_request_assignment.yml`: remove `armapireview` and other reviewers for ARM paths, except `rkmanda`. #24566

Update `pull_request_assignment.yml`: remove `armapireview` and other reviewers for ARM paths, except `rkmanda`. #24566

konrad-jamrozik commented Jun 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 25, 2023 •

edited

Loading

openapi-pipeline-app bot commented Jun 25, 2023 •

edited

Loading

konrad-jamrozik commented Jun 25, 2023 •

edited

Loading