-
Notifications
You must be signed in to change notification settings - Fork 5.5k
fix start job exec template required property #24850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi, @anandanthony! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
Jobs.json | 2022-11-01-preview(9bd0991) | 2022-11-01-preview(main) |
Jobs.json | 2023-04-01-preview(9bd0991) | 2023-04-01-preview(main) |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.3) | new version | base version |
---|---|---|
package-preview-2023-04 | package-preview-2023-04(9bd0991) | package-preview-2023-04(main) |
package-preview-2022-11 | package-preview-2022-11(9bd0991) | package-preview-2022-11(main) |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
PutResponseSchemaDescription |
Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L179 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L195 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L252 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L318 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L383 |
LroPostReturn |
200 response for a LRO POST operation must have a response schema specified. Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L399 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L447 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L515 |
PutResponseSchemaDescription |
Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L170 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L186 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L242 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L304 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L364 |
LroPostReturn |
200 response for a LRO POST operation must have a response schema specified. Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L380 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L418 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L472 |
The summary and description values should not be same. Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L145 |
|
The summary and description values should not be same. Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L209 |
|
Since operation response has model definition in array type, it should be of the form '_list'. Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L463 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L678 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L690 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2022-11-01-preview/Jobs.json#L812 |
|
The summary and description values should not be same. Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L140 |
|
The summary and description values should not be same. Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L203 |
|
Since operation response has model definition in array type, it should be of the form '_list'. Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L434 |
|
'GET' operation 'JobExecution' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L545 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L690 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L702 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L721 |
|
Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.App/preview/2023-04-01-preview/Jobs.json#L839 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️❌
~[Staging] ServiceAPIReadinessTest: 82 Errors, 0 Warnings failed [Detail]
Tag package-preview-2023-04; Prod region: Deployed
Test run on region: northcentralus; Operation coverage: total: 98, untested: 0, failed: 82, passed: 16
Service API Readiness Test failed. Check pipeline artifact for detail report.
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/connectedEnvironments/connectetz25aj' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ConnectedEnvironments_CheckNameAvailability |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/managedEnvironments/environmgq9n5h' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Namespaces_CheckNameAvailability |
CLIENT_ERROR |
statusCode: 404, errorCode: ManagedEnvironmentNotFound, errorMessage: Environment /subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-ISWcEc-24850/providers/Microsoft.App/managedEnvironments/demokube was not found. Source: runtime OperationId: ContainerApps_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/containerApps/containelegde9' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ContainerApps_Get |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/containerApps/containelegde9' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ContainerApps_Update |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/containerApps/containelegde9' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ContainerApps_Stop |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/containerApps/containelegde9' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ContainerApps_ListSecrets |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/containerApps/containelegde9' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ContainerApps_GetAuthToken |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/containerApps/containelegde9' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ContainerApps_ListCustomHostNameAnalysis |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/containerApps/containelegde9' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ContainerApps_Start |
CLIENT_ERROR |
statusCode: 400, errorCode: ManagedEnvironmentInvalidNetworkConfiguration, errorMessage: The environment network configuration is invalid: Invalid vnet resource ID provided, or the virtual network could not be found. Source: runtime OperationId: ManagedEnvironments_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/managedEnvironments/environmgq9n5h' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ManagedEnvironments_ListWorkloadProfileStates |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/managedEnvironments/environmgq9n5h' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ManagedEnvironments_Get |
CLIENT_ERROR |
statusCode: 404, errorCode: PatchResourceNotFound, errorMessage: The resource '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-ISWcEc-24850/providers/Microsoft.App/managedEnvironments/environmgq9n5h' was not found when evaluating policies for a PATCH operation. Source: runtime OperationId: ManagedEnvironments_Update |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/managedEnvironments/environmgq9n5h' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ManagedEnvironments_GetAuthToken |
CLIENT_ERROR |
statusCode: 400, errorCode: 10104, errorMessage: Invalid request for kube environment: connectetz25aj. Must specify extended location with valid Name and Type. Source: runtime OperationId: ConnectedEnvironments_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/connectedEnvironments/connectetz25aj' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ConnectedEnvironments_Get |
CLIENT_ERROR |
statusCode: 400, errorCode: InvalidResource, errorMessage: The resource definition is invalid. Source: runtime OperationId: ConnectedEnvironments_Update |
CLIENT_ERROR |
statusCode: 404, errorCode: ManagedEnvironmentNotFound, errorMessage: Environment /subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-ISWcEc-24850/providers/Microsoft.App/managedEnvironments/demokube was not found. Source: runtime OperationId: Jobs_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/jobs/jobnamea7v9bn' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Jobs_Get |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/jobs/jobnamea7v9bn' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Jobs_Update |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/jobs/jobnamea7v9bn' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Jobs_StopExecution |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/jobs/jobnamea7v9bn' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Jobs_ListSecrets |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/jobs/jobnamea7v9bn' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Jobs_Start |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/jobs/jobnamea7v9bn' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: Jobs_StopMultipleExecutions |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/managedEnvironments/environmgq9n5h' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: DaprComponents_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/managedEnvironments/environmgq9n5h' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: DaprComponents_List |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/managedEnvironments/environmgq9n5h' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: DaprComponents_Get |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.App/managedEnvironments/environmgq9n5h' under resource group 'apiTest-ISWcEc-24850' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: DaprComponents_ListSecrets |
CLIENT_ERROR |
statusCode: 404, errorCode: ParentResourceNotFound, errorMessage: Failed to perform 'write' on resource(s) of type 'managedEnvironments/certificates', because the parent resource '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-ISWcEc-24850/providers/Microsoft.App/managedEnvironments/environmgq9n5h' could not be found. Source: runtime OperationId: Certificates_CreateOrUpdate |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
CadlAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Please ignore, experimental check succeeded [Detail] [Expand]
Validation passes for 'Please ignore, experimental check'.
Swagger Generation Artifacts
|
Generated ApiView
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
No commit pushedDate could be found for PR 24850 in repo Azure/azure-rest-api-specs |
@rkmanda could you help review and merge the PR? |
closing PR, since this seemed to have some issues with ADO pipeline, created another PR with these changes: |
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.
ARM API changes review
ARMReview
label.ARMReview
label, if appropriate.If this happens, proceed according to guidance given in GitHub comments also added by the automation.
Breaking change review
If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.
Getting help
and https://aka.ms/ci-fix.