Skip to content

Conversation

kazrael2119
Copy link
Member

@kazrael2119 kazrael2119 commented Aug 21, 2023

@kazrael2119 kazrael2119 requested a review from MaryGao August 21, 2023 02:34
@kazrael2119 kazrael2119 requested a review from qiaozha as a code owner August 21, 2023 02:34
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 21, 2023

Next Steps to Merge

⚠️ This is an experimental comment. It may not always be up-to-date. ⚠️

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 21, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
compared tags (via openapi-validator v2.1.4) new version base version
default default(90e9670) default(main)
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 21, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

azure-sdk-for-go - sdk/resourcemanager/resources/armresources - 2.0.0
+	Operation `*TagsClient.CreateOrUpdateAtScope` has been changed to LRO, use `*TagsClient.BeginCreateOrUpdateAtScope` instead.
+	Operation `*TagsClient.DeleteAtScope` has been changed to LRO, use `*TagsClient.BeginDeleteAtScope` instead.
+	Operation `*TagsClient.UpdateAtScope` has been changed to LRO, use `*TagsClient.BeginUpdateAtScope` instead.
+	Type of `DeploymentProperties.Parameters` has been changed from `any` to `map[string]*DeploymentParameter`
+	Type of `DeploymentWhatIfProperties.Parameters` has been changed from `any` to `map[string]*DeploymentParameter`











️⚠️ azure-sdk-for-net-track2 warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 48a17e1. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    warn	No file changes detected after generation
  • ️✔️Azure.ResourceManager.Resources [View full logs
    info	[Changelog]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 48a17e1. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-resource [View full logs]  [Release SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added model DeploymentParameter
    info	[Changelog]   - Added model KeyVaultParameterReference
    info	[Changelog]   - Added model KeyVaultReference
️⚠️ azure-sdk-for-java warning [Detail]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 48a17e1. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/resources/armresources [View full logs]  [Release SDK Changes] Breaking Change Detected
    Only show 11 items here, please refer to log for details.
    info	[Changelog] - Operation `*TagsClient.CreateOrUpdateAtScope` has been changed to LRO, use `*TagsClient.BeginCreateOrUpdateAtScope` instead.
    info	[Changelog] - Operation `*TagsClient.DeleteAtScope` has been changed to LRO, use `*TagsClient.BeginDeleteAtScope` instead.
    info	[Changelog] - Operation `*TagsClient.UpdateAtScope` has been changed to LRO, use `*TagsClient.BeginUpdateAtScope` instead.
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New struct `DeploymentParameter`
    info	[Changelog] - New struct `KeyVaultParameterReference`
    info	[Changelog] - New struct `KeyVaultReference`
    info	[Changelog]
    info	[Changelog] Total 5 breaking change(s), 6 additive change(s).
  • ️✔️sdk/resourcemanager/resources/armdeploymentscripts [View full logs]  [Release SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
  • ️✔️sdk/resourcemanager/resources/armfeatures [View full logs]  [Release SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
  • ️✔️sdk/resourcemanager/resources/armlinks [View full logs]  [Release SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
  • ️✔️sdk/resourcemanager/resources/armlocks [View full logs]  [Release SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
  • ️✔️sdk/resourcemanager/resources/armmanagedapplications [View full logs]  [Release SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
  • ️✔️sdk/resourcemanager/resources/armpolicy [View full logs]  [Release SDK Changes]
    Only show 11 items here, please refer to log for details.
    info	[Changelog] - New struct `VariableListResult`
    info	[Changelog] - New struct `VariableProperties`
    info	[Changelog] - New struct `VariableValue`
    info	[Changelog] - New struct `VariableValueColumnValue`
    info	[Changelog] - New struct `VariableValueListResult`
    info	[Changelog] - New struct `VariableValueProperties`
    info	[Changelog] - New field `Overrides`, `ResourceSelectors` in struct `AssignmentProperties`
    info	[Changelog] - New field `Properties` in struct `AssignmentUpdate`
    info	[Changelog] - New field `AssignmentScopeValidation`, `ResourceSelectors` in struct `ExemptionProperties`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 62 additive change(s).
  • ️✔️sdk/resourcemanager/resources/armsubscriptions [View full logs]  [Release SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
  • ️✔️sdk/resourcemanager/resources/armtemplatespecs [View full logs]  [Release SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
  • ️✔️sdk/resourcemanager/resources/armchanges [View full logs]  [Release SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
  • ️✔️sdk/resourcemanager/resources/armdeploymentstacks [View full logs]  [Release SDK Changes]
    info	[Changelog] ### Other Changes
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
️🔄 azure-sdk-for-js inProgress [Detail]
️❌ azure-resource-manager-schemas failed [Detail]
  • Pipeline Framework Failed [Logs]Release - Generate from 48a17e1. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    warn	No file changes detected after generation
    cannot force update branch 'sdkAuto/resources' as it is the current HEAD of the repository.
    Error: cannot force update branch 'sdkAuto/resources' as it is the current HEAD of the repository.
  • ️✔️resources [View full logs
  • ️✔️resources [View full logs
    error	Fatal error: cannot force update branch 'sdkAuto/resources' as it is the current HEAD of the repository.
    error	The following packages are still pending:
    error		resources
    error		resources
    error		resources
  • ️✔️resources
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs]Release - Generate from 48a17e1. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ⚠️Az.resources.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.resources.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 21, 2023

Generated ApiView

Language Package Name ApiView Link
Java azure-resourcemanager-resources-generated https://apiview.dev/Assemblies/Review/170f8a28be03489282994a8c5333d0fc
Go sdk/resourcemanager/resources/armchanges There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armdeploymentscripts https://apiview.dev/Assemblies/Review/93bcc9c72c8d4ca3bf6012c75ad37576
Go sdk/resourcemanager/resources/armdeploymentstacks https://apiview.dev/Assemblies/Review/d91c192d13ac4137b47be51a3df9c431
Go sdk/resourcemanager/resources/armfeatures There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armlinks There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armlocks There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armmanagedapplications There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armpolicy https://apiview.dev/Assemblies/Review/0db83427f0494ca084b6f70f521751b3
Go sdk/resourcemanager/resources/armresources Create ApiView failed. Please ask PR assignee for help
Go sdk/resourcemanager/resources/armsubscriptions There is no API change compared with the previous version
Go sdk/resourcemanager/resources/armtemplatespecs There is no API change compared with the previous version
.Net Azure.ResourceManager.Resources There is no API change compared with the previous version

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 21, 2023

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 21, 2023
This was referenced Aug 21, 2023
MaryGao pushed a commit to Azure/azure-sdk-for-js that referenced this pull request Aug 25, 2023
Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only JS config changes and no need to require ARM review

@kazrael2119
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@MaryGao MaryGao removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required CI-BreakingChange-Go ARMReview labels Aug 28, 2023
@MaryGao MaryGao merged commit 48a17e1 into Azure:main Aug 28, 2023
@openapi-pipeline-app
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 28, 2023
This was referenced Aug 28, 2023
@kazrael2119 kazrael2119 deleted the update-resource-ts.md branch August 28, 2023 05:48
dgetu pushed a commit to Azure/azure-sdk-for-js that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview CI-BreakingChange-Go ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants