Skip to content

Conversation

Juliehzl
Copy link
Contributor

@Juliehzl Juliehzl commented Mar 21, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@Juliehzl Juliehzl requested a review from jijohn14 as a code owner March 21, 2024 03:19
Copy link

openapi-pipeline-app bot commented Mar 21, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see https://aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Mar 21, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️Breaking Change(Cross-Version): 4 Warnings warning [Detail]
Compared specs (v0.10.7) new version base version
Subscriptions.json 2024-03-01(970e6a1) 2023-11-02-preview(main)
Usages.json 2024-03-01(970e6a1) 2023-11-02-preview(main)
AuthConfigs.json 2024-03-01(970e6a1) 2023-05-01(main)
AuthConfigs.json 2024-03-01(970e6a1) 2023-11-02-preview(main)
ContainerApps.json 2024-03-01(970e6a1) 2023-05-01(main)
ContainerApps.json 2024-03-01(970e6a1) 2023-11-02-preview(main)

The following breaking changes are detected by comparison with the latest preview version:

Rule Message
⚠️ 1019 - RemovedEnumValue The new version is removing enum value(s) 'NfsAzureFile' from the old version.
New: Microsoft.App/stable/2024-03-01/CommonDefinitions.json#L640:9
Old: Microsoft.App/preview/2023-11-02-preview/CommonDefinitions.json#L644:9
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'targetPortHttpScheme' renamed or removed?
New: Microsoft.App/stable/2024-03-01/ContainerApps.json#L859:7
Old: Microsoft.App/preview/2023-11-02-preview/ContainerApps.json#L862:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'clientType' renamed or removed?
New: Microsoft.App/stable/2024-03-01/CommonDefinitions.json#L1166:7
Old: Microsoft.App/preview/2023-11-02-preview/CommonDefinitions.json#L1530:7
⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'customizedKeys' renamed or removed?
New: Microsoft.App/stable/2024-03-01/CommonDefinitions.json#L1166:7
Old: Microsoft.App/preview/2023-11-02-preview/CommonDefinitions.json#L1530:7
️⚠️LintDiff: 10 Warnings warning [Detail]
Compared specs (v2.2.0) new version base version
package-2024-03 package-2024-03(970e6a1) package-2024-03(release-app-Microsoft.App-2024-03-01)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.App/stable/2024-03-01/AuthConfigs.json#L459
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L1187
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.App/stable/2024-03-01/Usages.json#L27
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/stable/2024-03-01/Usages.json#L35
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/stable/2024-03-01/Usages.json#L38
⚠️ MissingSegmentsInNestedResourceListOperation A nested resource type's List operation must include all the parent segments in its api path.
Location: Microsoft.App/stable/2024-03-01/Usages.json#L65
RPC-Get-V1-11
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/stable/2024-03-01/Usages.json#L74
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/stable/2024-03-01/Usages.json#L77
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/stable/2024-03-01/Usages.json#L88
⚠️ SchemaDescriptionOrTitle Schema should have a description or title.
Location: Microsoft.App/stable/2024-03-01/Usages.json#L168


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/stable/2024-03-01/AuthConfigs.json#L18
ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/stable/2024-03-01/AuthConfigs.json#L67
ResourceNameRestriction The resource name parameter 'authConfigName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/stable/2024-03-01/AuthConfigs.json#L67
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.App/stable/2024-03-01/AuthConfigs.json#L119
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.App/stable/2024-03-01/AuthConfigs.json#L245
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.App/stable/2024-03-01/AuthConfigs.json#L277
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.App/stable/2024-03-01/AuthConfigs.json#L555
DefinitionsPropertiesNamesCamelCase Property name should be camel case.
Location: Microsoft.App/stable/2024-03-01/AuthConfigs.json#L601
ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L99
GetResponseCodes GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L100
NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L131
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L198
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L218
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L261
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:location.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L301
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:type.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L301
PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:activeRevisionsMode.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L301
PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:transport.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L301
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:allowedOrigins.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L301
PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:appProtocol.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L301
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:type.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L301
PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:maxReplicas.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L301
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L327
ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L339
ParametersInPost customHostname is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L346
ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L391
ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L437
PostResponseCodes Synchronous POST operations must have one of the following combinations of responses - 200 and default ; 204 and default. They also must not have other response codes.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L438
NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L469
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L531
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Mar 21, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌ azure-sdk-for-python-track2 failed [Detail]
  • Code Generator Failed [Logs] Generate from 84460aa51b4dec86be8d6f5d9f46f7595dd4090e. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_generate.sh] npm notice
    cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
    warn	Skip package processing as generation is failed
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from 84460aa51b4dec86be8d6f5d9f46f7595dd4090e. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 24.0
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh]   Average Speed   Time    Time     Time  Current
    cmderr	[init.sh]                                  Dload  Upload   Total   Spent    Left  Speed
    cmderr	[init.sh] 
      0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     00k
    cmderr	[init.sh]  notice
    cmderr	[init.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
    cmderr	[init.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
    cmderr	[init.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[init.sh] npm notice
    cmderr	[init.sh] Downloading https://nodejs.org/dist/v18.15.0/node-v18.15.0-linux-x64.tar.xz...
    cmderr	[init.sh] Computing checksum with sha256sum
    cmderr	[init.sh] Checksums matched!
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-appcontainers [View full logs]  [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 84460aa51b4dec86be8d6f5d9f46f7595dd4090e. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/appcontainers/armappcontainers [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Field `EndTime`, `StartTime`, `Status`, `Template` of struct `JobExecution` has been removed
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New function `*ClientFactory.NewManagedEnvironmentUsagesClient() *ManagedEnvironmentUsagesClient`
    info	[Changelog] - New function `*ClientFactory.NewUsagesClient() *UsagesClient`
    info	[Changelog] - New function `*ContainerAppsAPIClient.GetCustomDomainVerificationID(context.Context, *ContainerAppsAPIClientGetCustomDomainVerificationIDOptions) (ContainerAppsAPIClientGetCustomDomainVerificationIDResponse, error)`
    info	[Changelog] - New function `NewManagedEnvironmentUsagesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagedEnvironmentUsagesClient, error)`
    info	[Changelog] - New function `*ManagedEnvironmentUsagesClient.NewListPager(string, string, *ManagedEnvironmentUsagesClientListOptions) *runtime.Pager[ManagedEnvironmentUsagesClientListResponse]`
    info	[Changelog] - New function `NewUsagesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*UsagesClient, error)`
    info	[Changelog] - New function `*UsagesClient.NewListPager(string, *UsagesClientListOptions) *runtime.Pager[UsagesClientListResponse]`
    info	[Changelog] - New struct `BlobStorageTokenStore`
    info	[Changelog] - New struct `EncryptionSettings`
    info	[Changelog] - New struct `IngressPortMapping`
    info	[Changelog] - New struct `JobExecutionProperties`
    info	[Changelog] - New struct `ListUsagesResult`
    info	[Changelog] - New struct `ManagedEnvironmentPropertiesPeerTrafficConfiguration`
    info	[Changelog] - New struct `ManagedEnvironmentPropertiesPeerTrafficConfigurationEncryption`
    info	[Changelog] - New struct `TokenStore`
    info	[Changelog] - New struct `Usage`
    info	[Changelog] - New struct `UsageName`
    info	[Changelog] - New field `EncryptionSettings` in struct `AuthConfigProperties`
    info	[Changelog] - New field `AdditionalPortMappings` in struct `Ingress`
    info	[Changelog] - New field `Properties` in struct `JobExecution`
    info	[Changelog] - New field `TokenStore` in struct `Login`
    info	[Changelog] - New field `PeerTrafficConfiguration` in struct `ManagedEnvironmentProperties`
    info	[Changelog]
    info	[Changelog] Total 1 breaking change(s), 32 additive change(s).
    Present SDK breaking changes suppressions
    Field `EndTime`, `StartTime`, `Status`, `Template` of struct `JobExecution` has been removed
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 84460aa51b4dec86be8d6f5d9f46f7595dd4090e. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-appcontainers [View full logs]  [Preview SDK Changes]
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added operation group ManagedEnvironmentUsages
    info	[Changelog]   - Added operation group Usages
    info	[Changelog]   - Added Interface BlobStorageTokenStore
    info	[Changelog]   - Added Interface EncryptionSettings
    info	[Changelog]   - Added Interface GetCustomDomainVerificationIdOptionalParams
    info	[Changelog]   - Added Interface IngressPortMapping
    info	[Changelog]   - Added Interface ListUsagesResult
    info	[Changelog]   - Added Interface ManagedEnvironmentPropertiesPeerTrafficConfiguration
    info	[Changelog]   - Added Interface ManagedEnvironmentPropertiesPeerTrafficConfigurationEncryption
    info	[Changelog]   - Added Interface ManagedEnvironmentUsagesListNextOptionalParams
    info	[Changelog]   - Added Interface ManagedEnvironmentUsagesListOptionalParams
    info	[Changelog]   - Added Interface TokenStore
    info	[Changelog]   - Added Interface Usage
    info	[Changelog]   - Added Interface UsageName
    info	[Changelog]   - Added Interface UsagesListNextOptionalParams
    info	[Changelog]   - Added Interface UsagesListOptionalParams
    info	[Changelog]   - Added Type Alias GetCustomDomainVerificationIdResponse
    info	[Changelog]   - Added Type Alias ManagedEnvironmentUsagesListNextResponse
    info	[Changelog]   - Added Type Alias ManagedEnvironmentUsagesListResponse
    info	[Changelog]   - Added Type Alias UsagesListNextResponse
    info	[Changelog]   - Added Type Alias UsagesListResponse
    info	[Changelog]   - Interface AuthConfig has a new optional parameter encryptionSettings
    info	[Changelog]   - Interface Ingress has a new optional parameter additionalPortMappings
    info	[Changelog]   - Interface Login has a new optional parameter tokenStore
    info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter peerTrafficConfiguration
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs] Generate from 84460aa51b4dec86be8d6f5d9f46f7595dd4090e. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh]
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.2.4 -> 10.5.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.5.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️️✔️ azure-powershell succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 84460aa51b4dec86be8d6f5d9f46f7595dd4090e. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ️✔️Az.app.DefaultTag [View full logs]  [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Mar 21, 2024

@Juliehzl
Copy link
Contributor Author

Juliehzl commented Mar 21, 2024

All changes are from previous api version 2023-05-02-preview, which includes:
#24286
#24459
#24455
#24822
#24833

@ms-zhenhua ms-zhenhua added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 22, 2024
@Alancere Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Mar 26, 2024
@Juliehzl
Copy link
Contributor Author

Juliehzl commented Apr 2, 2024

/pr RequestMerge

@rkmanda rkmanda merged commit 566baab into Azure:release-app-Microsoft.App-2024-03-01 Apr 2, 2024
raosuhas pushed a commit that referenced this pull request Apr 18, 2024
* Adds base for updating Microsoft.App from version stable/2023-05-01 to version 2024-03-01

* Updates readme

* Updates API version in new specs and examples

* [ContainerApp] Support peer traffic encryption. (#28159)

* fix (#28426)

* Add new feature GPU and job diagnostics to 2024-03-01 (#27875)

* fix

* fix

* Add more features to 2024-03-01 which are same with 2023-05-02-preview (#28369)

* fix

* fix

* fix

* update readme

* add sdk-suppressions.yaml

---------

Co-authored-by: Alancere <[email protected]>

---------

Co-authored-by: Xiangyang Yu <[email protected]>
Co-authored-by: Alancere <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Go-Sdk-Suppression BreakingChange-Go-Sdk-Suppression-Approved resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants