-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Add more features to 2024-03-01 which are same with 2023-05-02-preview #28369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rkmanda
merged 5 commits into
Azure:release-app-Microsoft.App-2024-03-01
from
Juliehzl:user/zuh/add-aca-0301
Apr 2, 2024
Merged
Add more features to 2024-03-01 which are same with 2023-05-02-preview #28369
rkmanda
merged 5 commits into
Azure:release-app-Microsoft.App-2024-03-01
from
Juliehzl:user/zuh/add-aca-0301
Apr 2, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see https://aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
Compared specs (v0.10.7) | new version | base version |
---|---|---|
Subscriptions.json | 2024-03-01(970e6a1) | 2023-11-02-preview(main) |
Usages.json | 2024-03-01(970e6a1) | 2023-11-02-preview(main) |
AuthConfigs.json | 2024-03-01(970e6a1) | 2023-05-01(main) |
AuthConfigs.json | 2024-03-01(970e6a1) | 2023-11-02-preview(main) |
ContainerApps.json | 2024-03-01(970e6a1) | 2023-05-01(main) |
ContainerApps.json | 2024-03-01(970e6a1) | 2023-11-02-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
️⚠️
LintDiff: 10 Warnings warning [Detail]
Compared specs (v2.2.0) | new version | base version |
---|---|---|
package-2024-03 | package-2024-03(970e6a1) | package-2024-03(release-app-Microsoft.App-2024-03-01) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/stable/2024-03-01/AuthConfigs.json#L459 |
||
Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L1187 |
||
Not using the common-types defined parameter 'location'. Location: Microsoft.App/stable/2024-03-01/Usages.json#L27 |
||
Use the latest version v5 of types.json. Location: Microsoft.App/stable/2024-03-01/Usages.json#L35 |
||
Use the latest version v5 of types.json. Location: Microsoft.App/stable/2024-03-01/Usages.json#L38 |
||
A nested resource type's List operation must include all the parent segments in its api path. Location: Microsoft.App/stable/2024-03-01/Usages.json#L65 |
RPC-Get-V1-11 | |
Use the latest version v5 of types.json. Location: Microsoft.App/stable/2024-03-01/Usages.json#L74 |
||
Use the latest version v5 of types.json. Location: Microsoft.App/stable/2024-03-01/Usages.json#L77 |
||
Use the latest version v5 of types.json. Location: Microsoft.App/stable/2024-03-01/Usages.json#L88 |
||
Schema should have a description or title. Location: Microsoft.App/stable/2024-03-01/Usages.json#L168 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
ResourceNameRestriction |
The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/stable/2024-03-01/AuthConfigs.json#L18 |
ResourceNameRestriction |
The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/stable/2024-03-01/AuthConfigs.json#L67 |
ResourceNameRestriction |
The resource name parameter 'authConfigName' should be defined with a 'pattern' restriction. Location: Microsoft.App/stable/2024-03-01/AuthConfigs.json#L67 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.App/stable/2024-03-01/AuthConfigs.json#L119 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/stable/2024-03-01/AuthConfigs.json#L245 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/stable/2024-03-01/AuthConfigs.json#L277 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.App/stable/2024-03-01/AuthConfigs.json#L555 |
DefinitionsPropertiesNamesCamelCase |
Property name should be camel case. Location: Microsoft.App/stable/2024-03-01/AuthConfigs.json#L601 |
ResourceNameRestriction |
The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L99 |
GetResponseCodes |
GET operation must have response codes 200 and default. In addition, can have 202 if the GET represents the location header polling url. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L100 |
NoErrorCodeResponses |
Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L131 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L198 |
DeleteResponseCodes |
Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L218 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L261 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:location. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L301 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:type. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L301 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not have default value, property:activeRevisionsMode. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L301 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not have default value, property:transport. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L301 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:allowedOrigins. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L301 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not have default value, property:appProtocol. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L301 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:type. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L301 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not have default value, property:maxReplicas. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L301 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L327 |
ResourceNameRestriction |
The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L339 |
ParametersInPost |
customHostname is a query parameter. Post operation must not contain any query parameter other than api-version. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L346 |
ResourceNameRestriction |
The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L391 |
ResourceNameRestriction |
The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L437 |
PostResponseCodes |
Synchronous POST operations must have one of the following combinations of responses - 200 and default ; 204 and default. They also must not have other response codes. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L438 |
NoErrorCodeResponses |
Invalid status code specified. Please refer to the documentation for the allowed set. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L469 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/stable/2024-03-01/ContainerApps.json#L531 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced Mar 21, 2024
/pr RequestMerge |
rkmanda
approved these changes
Apr 2, 2024
raosuhas
pushed a commit
that referenced
this pull request
Apr 18, 2024
* Adds base for updating Microsoft.App from version stable/2023-05-01 to version 2024-03-01 * Updates readme * Updates API version in new specs and examples * [ContainerApp] Support peer traffic encryption. (#28159) * fix (#28426) * Add new feature GPU and job diagnostics to 2024-03-01 (#27875) * fix * fix * Add more features to 2024-03-01 which are same with 2023-05-02-preview (#28369) * fix * fix * fix * update readme * add sdk-suppressions.yaml --------- Co-authored-by: Alancere <[email protected]> --------- Co-authored-by: Xiangyang Yu <[email protected]> Co-authored-by: Alancere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMReview
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
BreakingChange-Go-Sdk-Suppression
BreakingChange-Go-Sdk-Suppression-Approved
resource-manager
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.Note
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1, Breaking Changes review
If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.
Click here to see the details of Step 2, ARM review
See https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.