fixed url for signature overrides - replaced with correct intrusionDe… #28966

mtatarik · 2024-05-03T19:24:16Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

…tectionSignaturesOverrides

openapi-pipeline-app · 2024-05-03T19:24:20Z

Next Steps to Merge

Next steps that must be taken to merge this PR:

❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
Automation should then add WaitForARMFeedback label.
For details of the ARM review, see aka.ms/azsdk/pr-arm-review
❌ The required check named Swagger LintDiff has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it

openapi-pipeline-app · 2024-05-03T19:24:20Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌Breaking Change(Cross-Version): 1 Errors, 0 Warnings failed [Detail]

Compared specs (v0.10.8)	new version	base version
firewallPolicy.json	2024-01-01(2f13c83)	2023-11-01(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
`❌` 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/firewallPolicies/{firewallPolicyName}/signatureOverrides/default' removed or restructured? Old: Microsoft.Network/stable/2023-11-01/firewallPolicy.json#L686:5

️❌LintDiff: 7 Errors, 8 Warnings failed [Detail]

Compared specs (v2.2.2)	new version	base version
package-2024-01	package-2024-01(2f13c83)	package-2024-01(release-network-Microsoft.Network-2024-01-01)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
`❌` EvenSegmentedPathForPutOperation	API path with PUT operation defined MUST have even number of segments (i.e. end in {resourceType}/{resourceName} segments). Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L686	RPC-Put-V1-02
`❌` ResourceNameRestriction	The resource name parameter 'firewallPolicyName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L686	RPC-Uri-V1-05
`❌` UnSupportedPatchProperties	Mark the top-level property 'id', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L691	RPC-Patch-V1-02
`❌` UnSupportedPatchProperties	Mark the top-level property 'name', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L691	RPC-Patch-V1-02
`❌` UnSupportedPatchProperties	Mark the top-level property 'type', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L691	RPC-Patch-V1-02
`❌` PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L741	RPC-Async-V1-11, RPC-Put-V1-11
`❌` XmsPageableForListCalls	`x-ms-pageable` extension must be specified for LIST APIs. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L795	RPC-Get-V1-13
⚠️ RequiredReadOnlySystemData	The response of operation:'FirewallPolicyIdpsSignaturesOverrides_Patch' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L687
⚠️ PatchInOperationName	'PATCH' operation 'FirewallPolicyIdpsSignaturesOverrides_Patch' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L688
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L701
⚠️ RequiredReadOnlySystemData	The response of operation:'FirewallPolicyIdpsSignaturesOverrides_Put' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L741
⚠️ PutInOperationName	'PUT' operation 'FirewallPolicyIdpsSignaturesOverrides_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L743
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L755
⚠️ RequiredReadOnlySystemData	The response of operation:'FirewallPolicyIdpsSignaturesOverrides_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L795
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L800

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'firewallPolicyName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L37
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L38
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L67
`❌` ParametersInPointGet	Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L99
`❌` PatchIdentityProperty	The patch operation body parameter schema should contain property 'identity'. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L236
`❌` ResourceNameRestriction	The resource name parameter 'firewallPolicyName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L358
`❌` ResourceNameRestriction	The resource name parameter 'ruleCollectionGroupName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L358
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L359
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L395
`❌` ResourceNameRestriction	The resource name parameter 'firewallPolicyName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L572
`❌` ResourceNameRestriction	The resource name parameter 'firewallPolicyName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L631
`❌` ResourceNameRestriction	The resource name parameter 'firewallPolicyName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L841
`❌` ResourceNameRestriction	The resource name parameter 'firewallPolicyName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L896
`❌` XmsPageableForListCalls	`x-ms-pageable` extension must be specified for LIST APIs. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L897
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L925
`❌` EvenSegmentedPathForPutOperation	API path with PUT operation defined MUST have even number of segments (i.e. end in {resourceType}/{resourceName} segments). Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L943
`❌` XmsPageableForListCalls	`x-ms-pageable` extension must be specified for LIST APIs. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L1051
`❌` EvenSegmentedPathForPutOperation	API path with PUT operation defined MUST have even number of segments (i.e. end in {resourceType}/{resourceName} segments). Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L1157
`❌` XmsPageableForListCalls	`x-ms-pageable` extension must be specified for LIST APIs. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L1281
`❌` NestedResourcesMustHaveListOperation	The nested resource 'FirewallPolicyDraft' does not have list operation, please add it. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L1448
`❌` TrackedResourcePatchOperation	Tracked resource 'FirewallPolicyDraft' must have patch operation that at least supports the update of tags. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L1448
`❌` NestedResourcesMustHaveListOperation	The nested resource 'FirewallPolicyRuleCollectionGroupDraft' does not have list operation, please add it. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L1536
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L2631
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L2644
`❌` AvoidAdditionalProperties	Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L2672
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L46
⚠️ RequiredReadOnlySystemData	The response of operation:'FirewallPolicies_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L93
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L101
⚠️ RequiredReadOnlySystemData	The response of operation:'FirewallPolicies_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L148
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Network/stable/2024-01-01/firewallPolicy.json#L156

️❌Avocado: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` MISSING_APIS_IN_DEFAULT_TAG	The default tag should contain all APIs. The API path `/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Network/firewallPolicies/{}/signatureOverrides/default` is not in the default tag. Please make sure the missing API swaggers are in the default tag. readme: specification/network/resource-manager/readme.md json: Microsoft.Network/stable/2023-11-01/firewallPolicy.json

️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-05-03T19:24:21Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌ azure-sdk-for-net failed [Detail]

❌Code Generator Failed in generating from 60c5c15e29ae6d29f5f2d0fac33c7a17c72d3cd6. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/network/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.Network [Preview SDK Changes]

cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
cmdout	[msbuild] /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
cmdout	[msbuild]      2>/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
cmdout	[msbuild] /home/cloudtest/.nuget/packages/microsoft.internal.netsdkbuild.mgmt.tools/0.12.0-dev.20220216.1/targets/common.targets(119,5): error MSB4181: The "MSBuild" task returned false but did not log an error. [/mnt/vss/_work/1/s/azure-sdk-for-net/eng/mgmt.proj]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=netstandard1.4]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/VirtualNetworkTap.cs(148,60): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/InboundNatRule.cs(238,40): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
cmdout	[msbuild]          /mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Generated/Models/ApplicationGatewayBackendHealthServer.cs(89,33): error CS1061: 'NetworkInterfaceIPConfiguration' does not contain a definition for 'Validate' and no accessible extension method 'Validate' accepting a first argument of type 'NetworkInterfaceIPConfiguration' could be found (are you missing a using directive or an assembly reference?) [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/network/Microsoft.Azure.Management.Network/src/Microsoft.Azure.Management.Network.csproj::TargetFramework=net452]
cmdout	[msbuild]          /home/cloudtest/.nuget/packages/microsoft.internal.netsdkbuild.mgmt.tools/0.12.0-dev.20220216.1/targets/common.targets(119,5): error MSB4181: The "MSBuild" task returned false but did not log an error. [/mnt/vss/_work/1/s/azure-sdk-for-net/eng/mgmt.proj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded in generating from 60c5c15e29ae6d29f5f2d0fac33c7a17c72d3cd6. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.Network [Preview SDK Changes]
- Azure.ResourceManager.Network.1.8.0-alpha.20240503.1.nupkg
```
info	[Changelog]
```

️🔄 azure-sdk-for-python inProgress [Detail]

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded in generating from 60c5c15e29ae6d29f5f2d0fac33c7a17c72d3cd6. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-network-generated [Preview SDK Changes]
- pom.xml
- azure-resourcemanager-network-generated-1.0.0-beta.1-sources.jar
- azure-resourcemanager-network-generated-1.0.0-beta.1.jar

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded in generating from 60c5c15e29ae6d29f5f2d0fac33c7a17c72d3cd6. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/network/armnetwork [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `EndpointTypeAzureArcNetwork` added to enum type `EndpointType`
info	[Changelog] - New enum type `ApplicationGatewaySKUFamily` with values `ApplicationGatewaySKUFamilyGeneration1`, `ApplicationGatewaySKUFamilyGeneration2`
info	[Changelog] - New enum type `InboundSecurityRuleType` with values `InboundSecurityRuleTypeAutoExpire`, `InboundSecurityRuleTypePermanent`
info	[Changelog] - New enum type `NicTypeInRequest` with values `NicTypeInRequestPrivateNic`, `NicTypeInRequestPublicNic`
info	[Changelog] - New enum type `NicTypeInResponse` with values `NicTypeInResponseAdditionalNic`, `NicTypeInResponsePrivateNic`, `NicTypeInResponsePublicNic`
info	[Changelog] - New enum type `SharingScope` with values `SharingScopeDelegatedServices`, `SharingScopeTenant`
info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyDeploymentsClient() *FirewallPolicyDeploymentsClient`
info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyDraftsClient() *FirewallPolicyDraftsClient`
info	[Changelog] - New function `*ClientFactory.NewFirewallPolicyRuleCollectionGroupDraftsClient() *FirewallPolicyRuleCollectionGroupDraftsClient`
info	[Changelog] - New function `NewFirewallPolicyDeploymentsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyDeploymentsClient, error)`
info	[Changelog] - New function `*FirewallPolicyDeploymentsClient.BeginDeploy(context.Context, string, string, *FirewallPolicyDeploymentsClientBeginDeployOptions) (*runtime.Poller[FirewallPolicyDeploymentsClientDeployResponse], error)`
info	[Changelog] - New function `NewFirewallPolicyDraftsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyDraftsClient, error)`
info	[Changelog] - New function `*FirewallPolicyDraftsClient.CreateOrUpdate(context.Context, string, string, FirewallPolicyDraft, *FirewallPolicyDraftsClientCreateOrUpdateOptions) (FirewallPolicyDraftsClientCreateOrUpdateResponse, error)`
info	[Changelog] - New function `*FirewallPolicyDraftsClient.Delete(context.Context, string, string, *FirewallPolicyDraftsClientDeleteOptions) (FirewallPolicyDraftsClientDeleteResponse, error)`
info	[Changelog] - New function `*FirewallPolicyDraftsClient.Get(context.Context, string, string, *FirewallPolicyDraftsClientGetOptions) (FirewallPolicyDraftsClientGetResponse, error)`
info	[Changelog] - New function `NewFirewallPolicyRuleCollectionGroupDraftsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*FirewallPolicyRuleCollectionGroupDraftsClient, error)`
info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.CreateOrUpdate(context.Context, string, string, string, FirewallPolicyRuleCollectionGroupDraft, *FirewallPolicyRuleCollectionGroupDraftsClientCreateOrUpdateOptions) (FirewallPolicyRuleCollectionGroupDraftsClientCreateOrUpdateResponse, error)`
info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.Delete(context.Context, string, string, string, *FirewallPolicyRuleCollectionGroupDraftsClientDeleteOptions) (FirewallPolicyRuleCollectionGroupDraftsClientDeleteResponse, error)`
info	[Changelog] - New function `*FirewallPolicyRuleCollectionGroupDraftsClient.Get(context.Context, string, string, string, *FirewallPolicyRuleCollectionGroupDraftsClientGetOptions) (FirewallPolicyRuleCollectionGroupDraftsClientGetResponse, error)`
info	[Changelog] - New function `*VirtualAppliancesClient.Restart(context.Context, string, string, *VirtualAppliancesClientRestartOptions) (VirtualAppliancesClientRestartResponse, error)`
info	[Changelog] - New struct `ConnectionMonitorEndpointLocationDetails`
info	[Changelog] - New struct `FirewallPolicyDraft`
info	[Changelog] - New struct `FirewallPolicyDraftProperties`
info	[Changelog] - New struct `FirewallPolicyRuleCollectionGroupDraft`
info	[Changelog] - New struct `FirewallPolicyRuleCollectionGroupDraftProperties`
info	[Changelog] - New struct `HeaderValueMatcher`
info	[Changelog] - New struct `PacketCaptureSettings`
info	[Changelog] - New struct `VirtualApplianceIPConfiguration`
info	[Changelog] - New struct `VirtualApplianceIPConfigurationProperties`
info	[Changelog] - New struct `VirtualApplianceInstanceIDs`
info	[Changelog] - New struct `VirtualApplianceNetworkInterfaceConfiguration`
info	[Changelog] - New struct `VirtualApplianceNetworkInterfaceConfigurationProperties`
info	[Changelog] - New struct `VirtualAppliancePropertiesFormatNetworkProfile`
info	[Changelog] - New field `HeaderValueMatcher` in struct `ApplicationGatewayHeaderConfiguration`
info	[Changelog] - New field `Family` in struct `ApplicationGatewaySKU`
info	[Changelog] - New field `LocationDetails`, `SubscriptionID` in struct `ConnectionMonitorEndpoint`
info	[Changelog] - New field `EnableDirectPortRateLimit` in struct `ExpressRouteCircuitPropertiesFormat`
info	[Changelog] - New field `Identity` in struct `FlowLog`
info	[Changelog] - New field `Identity` in struct `FlowLogInformation`
info	[Changelog] - New field `RuleType` in struct `InboundSecurityRuleProperties`
info	[Changelog] - New field `AppliesOn`, `DestinationPortRanges`, `Name` in struct `InboundSecurityRules`
info	[Changelog] - New field `PrivateIPAddressPrefixLength` in struct `InterfaceIPConfigurationPropertiesFormat`
info	[Changelog] - New field `CaptureSettings`, `ContinuousCapture` in struct `PacketCaptureParameters`
info	[Changelog] - New field `CaptureSettings`, `ContinuousCapture` in struct `PacketCaptureResultProperties`
info	[Changelog] - New field `LocalPath` in struct `PacketCaptureStorageLocation`
info	[Changelog] - New field `JsChallengeCookieExpirationInMins` in struct `PolicySettings`
info	[Changelog] - New field `SharingScope` in struct `SubnetPropertiesFormat`
info	[Changelog] - New field `DpdTimeoutSeconds` in struct `VPNSiteLinkConnectionProperties`
info	[Changelog] - New field `NicType` in struct `VirtualApplianceNicProperties`
info	[Changelog] - New field `NetworkProfile` in struct `VirtualAppliancePropertiesFormat`
info	[Changelog] - New field `EnableOnlyIPv6Peering`, `LocalAddressSpace`, `LocalSubnetNames`, `LocalVirtualNetworkAddressSpace`, `PeerCompleteVnets`, `RemoteSubnetNames` in struct `VirtualNetworkPeeringPropertiesFormat`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 75 additive change(s).

️🔄 azure-sdk-for-js inProgress [Detail]

️❌ azure-resource-manager-schemas failed [Detail]

❌Failed in generating from 60c5c15e29ae6d29f5f2d0fac33c7a17c72d3cd6. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.5.0 -> 10.7.0
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.7.0>
cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

❌network/resource-manager [Preview Schema Changes]

️⚠️ azure-powershell warning [Detail]

⚠️Warning in generating from 60c5c15e29ae6d29f5f2d0fac33c7a17c72d3cd6. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

⚠️Az.network.DefaultTag [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-05-03T19:24:21Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/network/armnetwork	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Java	azure-resourcemanager-network-generated	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
.Net	Azure.ResourceManager.Network	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Swagger	Microsoft.Network	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

microsoft-github-policy-service · 2024-05-03T19:24:30Z

Thank you for your contribution mtatarik! We will review the pull request and get back to you soon.

mentat9 · 2024-05-15T22:56:01Z

specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/firewallPolicy.json

@@ -683,7 +683,7 @@
        }
      }
    },
-    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/firewallPolicies/{firewallPolicyName}/signatureOverrides/default": {
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/firewallPolicies/{firewallPolicyName}/intrusionDetectionSignaturesOverrides/default": {


intrusionDetectionSignaturesOverrides

You also need to change the corresponding collection GET path

mentat9 · 2024-05-15T22:56:14Z

"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/firewallPolicies/{firewallPolicyName}/signatureOverrides": {

Also needs to change to intrusionDetectionSignaturesOverrides

Refers to: specification/network/resource-manager/Microsoft.Network/stable/2024-01-01/firewallPolicy.json:896 in 2f13c83. [](commit_id = 2f13c83, deletion_comment = False)

fixed url for signature overrides - replaced with correct intrusionDe…

2f13c83

…tectionSignaturesOverrides

mtatarik requested a review from Joanna-Yang-Art as a code owner May 3, 2024 19:24

microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label May 3, 2024

AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 3, 2024

mentat9 reviewed May 15, 2024

View reviewed changes

mentat9 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 15, 2024

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 15, 2024

Joanna-Yang-Art deleted the branch Azure:release-network-Microsoft.Network-2024-01-01 June 21, 2024 06:55

Joanna-Yang-Art closed this Jun 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fixed url for signature overrides - replaced with correct intrusionDe… #28966

fixed url for signature overrides - replaced with correct intrusionDe… #28966

Uh oh!

mtatarik commented May 3, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

Uh oh!

microsoft-github-policy-service bot commented May 3, 2024

Uh oh!

mentat9 May 15, 2024

Uh oh!

mentat9 commented May 15, 2024

Uh oh!

Uh oh!

fixed url for signature overrides - replaced with correct intrusionDe… #28966

fixed url for signature overrides - replaced with correct intrusionDe… #28966

Uh oh!

Conversation

mtatarik commented May 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Uh oh!

openapi-pipeline-app bot commented May 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app bot commented May 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented May 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Uh oh!

openapi-pipeline-app bot commented May 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

microsoft-github-policy-service bot commented May 3, 2024

Uh oh!

mentat9 May 15, 2024

Choose a reason for hiding this comment

Uh oh!

mentat9 commented May 15, 2024

Uh oh!

Uh oh!

mtatarik commented May 3, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading