Skip to content

Conversation

@zaowang-ms
Copy link
Contributor

@zaowang-ms zaowang-ms commented Jul 10, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 10, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 10, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️Breaking Change(Cross-Version): 1 Warnings warning [Detail]
Compared specs (v0.10.12) new version base version
swagger.json 2024-06-01-preview(d770711) 2023-09-01(main)
swagger.json 2024-06-01-preview(d770711) 2024-01-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule Message
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L1619:15
Old: NGINX.NGINXPLUS/stable/2023-09-01/swagger.json#L1516:15
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 2 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2024-06-01-preview package-2024-06-01-preview(d770711) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L1386
⚠️ AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L1462


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
ResourceNameRestriction The resource name parameter 'certificateName' should be defined with a 'pattern' restriction.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L29
RequestSchemaForTrackedResourcesMustHaveTags A tracked resource MUST always have tags as a top level optional property. Tracked resource does not have tags in the request schema.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L80
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L137
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L151
LroLocationHeader A 202 response should include an Location response header.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L185
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L194
ResourceNameRestriction The resource name parameter 'configurationName' should be defined with a 'pattern' restriction.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L302
RequestSchemaForTrackedResourcesMustHaveTags A tracked resource MUST always have tags as a top level optional property. Tracked resource does not have tags in the request schema.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L353
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L410
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L424
LroLocationHeader A 202 response should include an Location response header.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L458
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L467
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L639
PatchResponseCodes Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L653
UnSupportedPatchProperties Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L678
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:profiles.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L681
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:upgradeChannel.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L681
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:name.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L681
LroPatch202 The async patch operation should return 202.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L686
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L702
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L713
LroLocationHeader A 202 response should include an Location response header.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L740
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L749
OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L867
TrackedResourcePatchOperation Tracked resource 'NginxCertificate' must have patch operation that at least supports the update of tags.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L1006
TrackedResourcePatchOperation Tracked resource 'NginxConfiguration' must have patch operation that at least supports the update of tags.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L1102
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L41
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L44
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L57
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json#L94
️❌Avocado: 104 Errors, 0 Warnings failed [Detail]

Only 30 items are listed, please refer to log for more details.

Rule Message
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":1},"token":"<","message":"invalid symbol, token: <, line: 8, column: 1","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":2},"token":"<","message":"invalid symbol, token: <, line: 8, column: 2","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":3},"token":"<","message":"invalid symbol, token: <, line: 8, column: 3","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":4},"token":"<","message":"invalid symbol, token: <, line: 8, column: 4","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":5},"token":"<","message":"invalid symbol, token: <, line: 8, column: 5","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":6},"token":"<","message":"invalid symbol, token: <, line: 8, column: 6","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":7},"token":"<","message":"invalid symbol, token: <, line: 8, column: 7","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid token","position":{"line":8,"column":9},"token":"HEAD","message":"invalid token, token: HEAD, line: 8, column: 9","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"structure","code":"unexpected token","position":{"line":9,"column":5},"token":""requestBody"","message":"unexpected token, token: "requestBody", line: 9, column: 5","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":10,"column":1},"token":"=","message":"invalid symbol, token: =, line: 10, column: 1","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":10,"column":2},"token":"=","message":"invalid symbol, token: =, line: 10, column: 2","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":10,"column":3},"token":"=","message":"invalid symbol, token: =, line: 10, column: 3","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":10,"column":4},"token":"=","message":"invalid symbol, token: =, line: 10, column: 4","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":10,"column":5},"token":"=","message":"invalid symbol, token: =, line: 10, column: 5","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":10,"column":6},"token":"=","message":"invalid symbol, token: =, line: 10, column: 6","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":10,"column":7},"token":"=","message":"invalid symbol, token: =, line: 10, column: 7","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":12,"column":1},"token":">","message":"invalid symbol, token: >, line: 12, column: 1","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":12,"column":2},"token":">","message":"invalid symbol, token: >, line: 12, column: 2","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":12,"column":3},"token":">","message":"invalid symbol, token: >, line: 12, column: 3","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":12,"column":4},"token":">","message":"invalid symbol, token: >, line: 12, column: 4","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":12,"column":5},"token":">","message":"invalid symbol, token: >, line: 12, column: 5","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":12,"column":6},"token":">","message":"invalid symbol, token: >, line: 12, column: 6","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":12,"column":7},"token":">","message":"invalid symbol, token: >, line: 12, column: 7","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid token","position":{"line":12,"column":9},"token":"ad586683a95c59b4e581081881037f614049040c","message":"invalid token, token: ad58668, line: 12, column: 9","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"structure","code":"unexpected token","position":{"line":13,"column":7},"token":""properties"","message":"unexpected token, token: "properties", line: 13, column: 7","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"}]({"kind":"structure","code":"unexpected end of file","position":{"line":1,"column":1},"token":"}","message":"unexpected end of file, token: }, line: 1, column: 1","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Certificates_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Configurations_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":1},"token":"<","message":"invalid symbol, token: <, line: 8, column: 1","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Configurations_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Configurations_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":2},"token":"<","message":"invalid symbol, token: <, line: 8, column: 2","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Configurations_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Configurations_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":3},"token":"<","message":"invalid symbol, token: <, line: 8, column: 3","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Configurations_CreateOrUpdate.json"})
JSON_PARSE The file is not a valid JSON file.
json: [stable/2023-04-01/examples/Configurations_CreateOrUpdate.json"}]({"kind":"syntax","code":"invalid symbol","position":{"line":8,"column":4},"token":"<","message":"invalid symbol, token: <, line: 8, column: 4","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/nginx/resource-manager/NGINX.NGINXPLUS/stable/2023-04-01/examples/Configurations_CreateOrUpdate.json"})
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 1 Errors, 0 Warnings failed [Detail]
Rule Message
JSON_PARSING_ERROR Json parsing error: invalid symbol
Url: stable/2023-04-01/examples/Certificates_CreateOrUpdate.json#L8:1
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 10, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌ azure-sdk-for-net failed [Detail]
    For more instructions, please refer to the FAQ .
  • Code Generator Failed in generating from 7608034df33069aeed76b35c064fb4e4f1896a5f. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/nginx/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
  • Microsoft.Azure.Management.Nginx [Preview SDK Changes]
    cmdout	[msbuild] MSBUILD : error MSB1009: Project file does not exist.
    error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet
️⚠️ azure-sdk-for-python warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from 7608034df33069aeed76b35c064fb4e4f1896a5f. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh] npm notice
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
    cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
    cmderr	[automation_init.sh] npm notice To update run: npm install -g [email protected]
    cmderr	[automation_init.sh] npm notice
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-nginx [Preview SDK Changes]
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 7608034df33069aeed76b35c064fb4e4f1896a5f. SDK Automation 14.0.0
    command	./eng/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-nginx [Preview SDK Changes]
    Only showing 120 items here. Refer to log for details.
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.NginxDeploymentScalingProperties` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `profiles()` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `withProfiles(java.util.List)` was added
    info	[Changelog]
    info	[Changelog] #### `models.NginxConfigurationListResponse` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.NginxDeploymentUpdateParameters` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.NginxFrontendIpConfiguration` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.Configurations` was modified
    info	[Changelog]
    info	[Changelog] * `analysis(java.lang.String,java.lang.String,java.lang.String)` was added
    info	[Changelog] * `analysisWithResponse(java.lang.String,java.lang.String,java.lang.String,models.AnalysisCreate,com.azure.core.util.Context)` was added
    info	[Changelog]
    info	[Changelog] #### `models.OperationDisplay` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.NginxDeploymentUserProfile` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.NginxPublicIpAddress` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.NginxConfigurationPackage` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.NginxDeploymentUpdateProperties` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `withAutoUpgradeProfile(models.AutoUpgradeProfile)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `withNginxAppProtect(models.NginxDeploymentUpdatePropertiesNginxAppProtect)` was added
    info	[Changelog] * `autoUpgradeProfile()` was added
    info	[Changelog] * `nginxAppProtect()` was added
    info	[Changelog]
    info	[Changelog] #### `models.NginxLogging` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.NginxDeploymentProperties` was modified
    info	[Changelog]
    info	[Changelog] * `withAutoUpgradeProfile(models.AutoUpgradeProfile)` was added
    info	[Changelog] * `nginxAppProtect()` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `autoUpgradeProfile()` was added
    info	[Changelog] * `withNginxAppProtect(models.NginxDeploymentPropertiesNginxAppProtect)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.ResourceSku` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.NginxCertificateProperties` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `certificateError()` was added
    info	[Changelog] * `sha1Thumbprint()` was added
    info	[Changelog] * `withCertificateError(models.NginxCertificateErrorResponseBody)` was added
    info	[Changelog] * `keyVaultSecretVersion()` was added
    info	[Changelog] * `keyVaultSecretCreated()` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.NginxNetworkProfile` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.NginxStorageAccount` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog] #### `models.NginxCertificateListResponse` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.NginxConfiguration` was modified
    info	[Changelog]
    info	[Changelog] * `analysis()` was added
    info	[Changelog] * `analysisWithResponse(models.AnalysisCreate,com.azure.core.util.Context)` was added
    info	[Changelog]
    info	[Changelog] #### `models.NginxConfigurationProperties` was modified
    info	[Changelog]
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog]
    info	[Changelog] #### `models.NginxPrivateIpAddress` was modified
    info	[Changelog]
    info	[Changelog] * `fromJson(com.azure.json.JsonReader)` was added
    info	[Changelog] * `toJson(com.azure.json.JsonWriter)` was added
    info	[Changelog]
    info	[Changelog]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 7608034df33069aeed76b35c064fb4e4f1896a5f. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/nginx/armnginx [Preview SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 7608034df33069aeed76b35c064fb4e4f1896a5f. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-nginx [Preview SDK Changes]
️❌ azure-resource-manager-schemas failed [Detail]
    For more instructions, please refer to the FAQ .
  • Code Generator Failed in generating from 7608034df33069aeed76b35c064fb4e4f1896a5f. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.2
    cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.2
    cmderr	[initScript.sh] npm notice To update run: npm install -g [email protected]
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.
️️✔️ azure-powershell succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 7608034df33069aeed76b35c064fb4e4f1896a5f. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ️✔️Az.nginx.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

@raosuhas
Copy link

Can you please fix the swagger Lint diff warnings : https://github.com/Azure/azure-rest-api-specs/pull/29773/checks?check_run_id=27249014316

@raosuhas
Copy link

Also please update the descrption section and follow all the instructions on that carefully. This PR needs a base commit of the previous api version so that we can do a diff across the versions and compare.

@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 16, 2024
@zaowang-ms
Copy link
Contributor Author

Also please update the descrption section and follow all the instructions on that carefully. This PR needs a base commit of the previous api version so that we can do a diff across the versions and compare.

@raosuhas I apologize for the commit confusion. Please take a look at the version specific diff in this file here : d770711#diff-57df7de9e3f104a102d3a74c90fdbff079feaecc51359f260974956497d1beef

This is already approved in private repo here:
https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/nginx/resource-manager/NGINX.NGINXPLUS/preview/2024-06-01-preview/swagger.json

What we do is just copying and publishing the private api which is tested well.

@zaowang-ms
Copy link
Contributor Author

Can you please fix the swagger Lint diff warnings : https://github.com/Azure/azure-rest-api-specs/pull/29773/checks?check_run_id=27249014316

Errors introduced by this PR is resolved now

@AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Jul 17, 2024
@zaowang-ms
Copy link
Contributor Author

@raosuhas while I don't have access to remove the ARMChangesRequested label and access is being processed, please go ahead to review / sign off this PR as I think it's ready now from our end. I'll add the WaitForARMFeedback label once I have permission.

@zaowang-ms
Copy link
Contributor Author

/azp run

@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 18, 2024
@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@zaowang-ms zaowang-ms force-pushed the zaowang/adding-2024-06-01-preview branch 2 times, most recently from 165255a to add4ff9 Compare July 18, 2024 18:52
@raosuhas raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jul 18, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 18, 2024
@zaowang-ms
Copy link
Contributor Author

Sorry for triggering extra things, rebase error. Now it's fixed.

@zaowang-ms zaowang-ms force-pushed the zaowang/adding-2024-06-01-preview branch from c083684 to 2d98f96 Compare July 23, 2024 17:43
@zaowang-ms
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@zaowang-ms
Copy link
Contributor Author

zaowang-ms commented Jul 31, 2024

@ms-bogdan-rotaru Would be great if we can revisit this PR and re-approve this as initial approval seems to be reverted due to rebase. Muchly appreciated!

@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Aug 26, 2024
@microsoft-github-policy-service
Copy link
Contributor

Hi, @zaowang-ms. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Sep 16, 2024
@microsoft-github-policy-service
Copy link
Contributor

Hi, @zaowang-ms. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review new-api-version no-recent-activity There has been no recent activity on this issue. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager RPaaS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants