Skip to content

Revert "Downgraded the version of ManagedInstances to generate .Net SDK for sql/resource manager" #30261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2024
Merged

Revert "Downgraded the version of ManagedInstances to generate .Net SDK for sql/resource manager" #30261

merged 1 commit into from
Aug 27, 2024

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented Aug 20, 2024 •
edited
Loading

For https://github.com/Azure/sdk-release-request/issues/5380

Context:
Revert this PR since it causes unexpected breakings for JS/Python/GO/Java SDK. And we already get approval from PR author in e-mail RE: Question about https://github.com/Azure/azure-rest-api-specs/pull/29316

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 20, 2024 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 20, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/sql/armsql https://apiview.dev/Assemblies/Review/ddcdbf3100fb45bbaafb400a9a70d425?revisionId=2f3d0198631a4096b9a86fef273d2865
JavaScript @azure/arm-sql https://apiview.dev/Assemblies/Review/129721cd69b541de821b5e7227b49902?revisionId=50fb1cd977854398a0cdd0b26d5fe335
.Net Azure.ResourceManager.Sql https://apiview.dev/Assemblies/Review/1e3ea1e2dc2c4679b3acd45b20b81a18?revisionId=2dac3d89990d4c248be2e61708907c20

@azure-sdk azure-sdk mentioned this pull request Aug 20, 2024
Closed
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 20, 2024
This was referenced Aug 20, 2024
Closed
Closed
Closed
@msyyc msyyc mentioned this pull request Aug 20, 2024
Closed
3 tasks
@msyyc msyyc added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Aug 20, 2024
@azure-sdk azure-sdk mentioned this pull request Aug 20, 2024
Closed
@mentat9 mentat9 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 20, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 20, 2024
@msyyc msyyc merged commit 2bd041f into main Aug 27, 2024
27 of 30 checks passed
@msyyc msyyc deleted the revert-29316-main branch August 27, 2024 07:13
cheukchuen pushed a commit that referenced this pull request Jan 24, 2025
@msyyc @cheukchuen
Revert "Downgraded the version of ManagedInstances to generate .Net S…
e432769 
…DK for s…" (#30261)

This reverts commit f45a76f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@jamestao jamestao Awaiting requested review from jamestao jamestao is a code owner

@ericshape ericshape Awaiting requested review from ericshape ericshape is a code owner

@jeremyfrosti jeremyfrosti Awaiting requested review from jeremyfrosti jeremyfrosti is a code owner

Assignees
No one assigned
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager SQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msyyc @weidongxu-microsoft @mentat9 @AzureRestAPISpecReview