-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Migrate PostgreSql to TypeSpec #36556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mcgallan
wants to merge
27
commits into
Azure:main
Choose a base branch
from
mcgallan:convert-dbforpostgressql
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PostgreSQL
resource-manager
TypeSpec
Authored with TypeSpec
VersioningReviewRequired
<valid label in PR review process>add this label when versioning review is required
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates your latest version (identified by the tag in your readme.md) of swagger to TypeSpec. We already tried our best to make sure the TypeSpec represents same as previous swagger. Since we lack the business knowledge, please validate this PR again to make sure it's functional equivalent as before. The local validation step is at Getting started | TypeSpec Azure
Besides, TypeSpec encourages to follow ARM guidelines. Therefore, some representations in your previous swagger needs to be fixed. Please handle all these issues properly and them contact Azure SDK Team:
1.You're identifying that the TuningOptions_ListRecommendations operation uses an enum named recommendationType, which has the same name as another existing enum, but they contain different values. TypeSpec will treat them as the same enum during generation, which causes errors.
2.supportedHaMode has the same issue as recommendationType - there are duplicate enum names with different values that TypeSpec treats as the same enum during generation, causing conflicts.
3.the original swagger used the "x-ms-visibility": "internal" syntax, which doesn't have a corresponding syntax in TypeSpec.
4.the secret property in BackupStoreDetails is incorrectly placed within the items property, which is not the correct syntax.
5.threatProtectionName is an enum type, and when it's used as a parameter in the path, it cannot have a pattern added to it.
6.In TypeSpec, we cannot add a default value of null for model properties.
Please reach out to TypeSpec Discussions Channel if there is any help needed.