-
Notifications
You must be signed in to change notification settings - Fork 5.5k
[widget] Update common-types to v6 #36564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
@mikekistler, @JeffreyRichter: This is just our sample (no actual service), so the breaking changes shouldn't matter. However, is it concerning that upgrading from v5 to v6 of common-types (as recommended by LintDiff) causes these breaking changes? When and how are real services supposed to upgrade their version of common-types? |
Yes it is concerning that v5->v6 results in these breaking change warnings, particularly that AddedRequiredProperty ones, which are only acceptable when the property was actually required and simply not marked as such, which I believe is the case here. It would be great if we could find a way to suppress these specific issues. |
@mikekistler: Do you believe the v6 common-types should be updated to not be breaking, or that the breaking changes tool should be updated to not consider these changes as breaking? I can help drive this, but I'm still not sure exactly what or where the problem is. |
Next Steps to MergeNext steps that must be taken to merge this PR:
Important checks have failed. As of today they are not blocking this PR, but in near future they may. Addressing the following failures is highly recommended:
Comment generated by summarize-checks workflow run. |
No description provided.