-
Notifications
You must be signed in to change notification settings - Fork 5.5k
[ContainerInstance] Release 2025-09-01 stable version based on previous released preview API's #36704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[ContainerInstance] Release 2025-09-01 stable version based on previous released preview API's #36704
Conversation
Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from preview/2024-05-01-preview to stable/2025-09-01.
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
Breaking changes previously reviewed and approved in #28964 |
…ishtipeshwani09/azure-rest-api-specs into dev/dpes/aci2025stableversion
…ishtipeshwani09/azure-rest-api-specs into dev/dpes/aci2025stableversion
Commenter does not have sufficient privileges for PR 36704 in repo Azure/azure-rest-api-specs |
@ramoka178 I have fixed the issue, the Swagger LintDiff check is no longer failing. Please re-review the PR. |
@drishtipeshwani09 For next time, the first commit should be an exact copy of the previous api version's files in the new folder made for the new apiversion. |
where are APIs related to ngroups ? like I see all of them removed. Refers to: specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2025-09-01/containerInstance.json:1 in 886b110. [](commit_id = 886b110, deletion_comment = False) |
Use of additionalProperties is not allowed for properties owned by the service. The only time its ok to use it is when the properties are pass thru (user defined) and not subject to any validations. Please make this an array or provide an explanation for why you need this. Refers to: specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2025-09-01/containerInstance.json:1322 in 886b110. [](commit_id = 886b110, deletion_comment = False) |
storageAccountKeyReference is being removed. existing customers will be affected right ? This is happening in other places too. Refers to: specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2025-09-01/containerInstance.json:1569 in 886b110. [](commit_id = 886b110, deletion_comment = False) |
ARM recommends enums over booleans for future proof APIs. Standard guidance is: replace boolean/switch properties with a more meaningful enum whenever possible. A boolean will forever have two valid values (true or false). A string enum type is always preferred. Also, properties should always provide better values just than True and False. For example two switches "isTypeA" and "isTypeB" should be replaced with one enum "type": [A, B, DefaultType]. Enums are always a more flexible and future proof option because they allow additional values to be added in the future in a non-breaking way, e.g. [Enabled, Disabled, Suspended, Deallocated]. Note: do NOT define a 'boolean enum' with two values 'True and False'. This might be easier to 'extend' in terms of types, but semantically its cofusing, and no better than a boolean. Refers to: specification/containerinstance/resource-manager/Microsoft.ContainerInstance/stable/2025-09-01/containerInstance.json:1944 in 886b110. [](commit_id = 886b110, deletion_comment = False) |
So, the current stable API that I want to release is based on the 2024-05-01-preview API version, and additionally just comprises one new property related to identityACLS which was released in 2024-11-01-preview API version, we do not want to take the changes related to NGroups for our stable version, they are still in preview. |
All of these properties SecretReferenceVolume, secretReference and storageAccountKeyReference are part of the 2024-11-01-preview API version, currently we do not want to take these as part of the stable API. This will be accessible to customers using the preview API's + SDKs. The current stable API being released is based on the 2024-05-01-preview API and add additional property which was released as part of the 2024-11-01-preview API version. |
This might be mistake from our end, for CG Profile Deletion we just return 200 and 204. This current stable API is based on the 2024-05-01-preview API and not the latest preview API version. |
The Key-Value pairs defined as part of the Config Map property are user defined, and are not subject to any validations at the RP level. |
I understand this, however as this feature has been already released, it is expected to behave in a certain way by the customers. The variables that I have defined as boolean like isCreatedFromStandbyPool or failContainerGroupCreateOnReuseFailure , are expected to have True or False as their corresponding values. So, the code cannot be modified to use enum variables instead. We were given this feedback during our preview API review that we should be working on the spec first before releasing the changes, we will be keeping this in mind for our new properties/parameters in the future. |
/azp run |
Commenter does not have sufficient privileges for PR 36704 in repo Azure/azure-rest-api-specs |
[ARMBlockingComment] Your new api-version should be based out of the previous latest api-version , in this case 2024-11-01-preview . |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.