Skip to content

Conversation

Tratcher
Copy link

@Tratcher Tratcher commented Oct 2, 2025

Remove the obsolete IngressConfiguration Scale parameter.
Update the requestIdleTimeout description.

@Tratcher Tratcher requested a review from Juliehzl as a code owner October 2, 2025 23:07
Copy link

github-actions bot commented Oct 2, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named TypeSpec Requirement has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 2, 2025
Copy link

github-actions bot commented Oct 2, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Go sdk/resourcemanager/appcontainers/armappcontainers
Java com.azure.resourcemanager:azure-resourcemanager-appcontainers
JavaScript @azure/arm-appcontainers

@ravimeda
Copy link

ravimeda commented Oct 3, 2025

Please address the TypeSpec check failure. Refer to https://aka.ms/ci-fix

@ravimeda ravimeda added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 3, 2025
@Tratcher
Copy link
Author

Tratcher commented Oct 6, 2025

@ravimeda this is a modification of an existing type, why is it requiring we use a new format?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants