-
Notifications
You must be signed in to change notification settings - Fork 5.5k
csharp clientName changes #37914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
csharp clientName changes #37914
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
4d651f2
to
dfcc33f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR makes C# SDK client name changes for the Storage Discovery Management service by adding @clientName
decorators for two additional types and updating dependency versions in the TypeSpec specification.
Key changes:
- Added
@useDependency
decorators for Azure Resource Manager versions in the API version enum - Added
@clientName
decorators forStorageDiscoveryResourceType
andStorageDiscoveryWorkspacePropertiesUpdate
types - Imported the new client.tsp file into main.tsp
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
specification/storagediscovery/Microsoft.StorageDiscovery.Management/versions.tsp | Added @useDependency decorators for Azure Resource Manager versions |
specification/storagediscovery/Microsoft.StorageDiscovery.Management/main.tsp | Added import for the new client.tsp file |
specification/storagediscovery/Microsoft.StorageDiscovery.Management/client.tsp | Added C# client name mappings and removed unnecessary main.tsp import |
SDK configuration pull request
Purpose of this PR
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
tspconfig.yaml
templates:Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.