Skip to content

Conversation

kamboj-prjwl
Copy link
Member

@kamboj-prjwl kamboj-prjwl commented Oct 5, 2025

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

Prajjwal Kamboj and others added 13 commits September 5, 2025 15:35
Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2024-10-01 to stable/2025-01-01.
* Added access mode for PrivateLinkService

---------

Co-authored-by: Lawrence Wang <[email protected]>
* Add support for certificate based authentication connection

* Add descriptions for connection type enums

* Add zones property to virtual network gateway
…into kamboj-prjwl/release-network-2025-01-01

Sync with main
* Update DefaultOutboundAccess property description on virtualNetwork and add Scope to loadBalancer

* Examples
…into kamboj-prjwl/release-network-2025-01-01

Sync branch with main
* update

* add default and enum item descriptions

* resolve prettiercheck

---------

Co-authored-by: Cameron Nichols <[email protected]>
Copy link

github-actions bot commented Oct 5, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named Swagger Avocado has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. ARMReview new-api-version resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 5, 2025
Copy link

github-actions bot commented Oct 5, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.Network
Go sdk/resourcemanager/network/armnetwork
Java com.azure.resourcemanager:azure-resourcemanager-network-generated
JavaScript @azure/arm-network
C# Azure.ResourceManager.Network

@kamboj-prjwl
Copy link
Member Author

Swagger Avocado violations for resources vmssNetworkInterface.json and vmssPublicIpAddress.json. These are the Microsoft.Compute resources and their version can't be updated to match Microsoft.Network version. Please provide Approved-Avocado tag for the PR.

@kamboj-prjwl kamboj-prjwl added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Oct 6, 2025
@mentat9
Copy link
Member

mentat9 commented Oct 6, 2025

      "type": "boolean",

ARM recommends string enums over boolean. Generally enums make better properties than booleans. They are more descriptive and flexible while being easier for customers to discover, understand and use. Ref: https://eng.ms/docs/products/arm/rp_onboarding/process/api_review_best_practices. They allow values other than just true/false and support description strings. Even if you only ever want two values, you can have a string enum with two values.

For this property, you could consider something along the lines of "probeType: { Bare, WithProxyProtocolHeader } (or better names you come up with).


Refers to: specification/network/resource-manager/Microsoft.Network/stable/2025-01-01/applicationGateway.json:1180 in 981cc1c. [](commit_id = 981cc1c, deletion_comment = False)

@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMChangesRequested ARMReview brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. Network new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants