-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Release Microsoft.Network 2025-01-01 #37918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2024-10-01 to stable/2025-01-01.
* Added access mode for PrivateLinkService --------- Co-authored-by: Lawrence Wang <[email protected]>
* Add support for certificate based authentication connection * Add descriptions for connection type enums * Add zones property to virtual network gateway
…into kamboj-prjwl/release-network-2025-01-01 Sync with main
Co-authored-by: Prajjwal Kamboj <[email protected]>
* Update DefaultOutboundAccess property description on virtualNetwork and add Scope to loadBalancer * Examples
…into kamboj-prjwl/release-network-2025-01-01 Sync branch with main
* update * add default and enum item descriptions * resolve prettiercheck --------- Co-authored-by: Cameron Nichols <[email protected]>
Co-authored-by: Prajjwal Kamboj <[email protected]>
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
Swagger Avocado violations for resources vmssNetworkInterface.json and vmssPublicIpAddress.json. These are the Microsoft.Compute resources and their version can't be updated to match Microsoft.Network version. Please provide Approved-Avocado tag for the PR. |
ARM recommends string enums over boolean. Generally enums make better properties than booleans. They are more descriptive and flexible while being easier for customers to discover, understand and use. Ref: https://eng.ms/docs/products/arm/rp_onboarding/process/api_review_best_practices. They allow values other than just true/false and support description strings. Even if you only ever want two values, you can have a string enum with two values. For this property, you could consider something along the lines of "probeType: { Bare, WithProxyProtocolHeader } (or better names you come up with). Refers to: specification/network/resource-manager/Microsoft.Network/stable/2025-01-01/applicationGateway.json:1180 in 981cc1c. [](commit_id = 981cc1c, deletion_comment = False) |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.