Skip to content

Conversation

@kamboj-prjwl
Copy link
Member

@kamboj-prjwl kamboj-prjwl commented Jan 6, 2026

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

Prajjwal Kamboj and others added 11 commits December 12, 2025 12:05
Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2025-03-01 to stable/2025-05-01.
* Sgw change

* ModelFix

* Model issue fix

* Fix

* Model fix

* Fixed comment

* Updated description for zone
* Update IDPS Profile names

* Add examples for IDPS profile

* Update Firewall Policy PUT example IDPS profile

* Update profile name and enum order

* Remove delete example

* Update profile names to emerging, extended and core

* Add Off as default profile

* Move changes to latest release

* Revert PUT example change on older version

* Move changes to release 2025-05-01

* Update examples release version

* Update profile order

* Update profiles description
* Add a new top level resource for VNA

* add suppression for a known issue.

* add 1 more suppression due to known issue

* added x-ms-parameter-location as per go sdk team suggestion

* one more place to add for x-ms-parameter-location attribute

---------

Co-authored-by: Prajjwal Kamboj <[email protected]>
)

* update the spec with CAPTCHA action and cookies expiary

* whitespace issue

* Fix description for CAPTCHA cookie expiration
…into kamboj-prjwl/release-network-2025-05-01

Sync branch with main
* Lint error fix

* Response Change
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. ARMReview new-api-version resource-manager SuppressionReviewRequired WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 6, 2026
@kamboj-prjwl kamboj-prjwl added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Jan 6, 2026
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.Network
Go sdk/resourcemanager/network/armnetwork
Java com.azure.resourcemanager:azure-resourcemanager-network-generated
JavaScript @azure/arm-network

@github-actions github-actions bot added BreakingChange-Go-Sdk BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview BreakingChange-JavaScript-Sdk and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 6, 2026
@mikekistler mikekistler added the BreakingChange-Approved-BranchPolicyException Changes violate the branch policy but exception has been granted. aka.ms/azsdk/pr-brch-deep label Jan 6, 2026
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Jan 6, 2026
@kamboj-prjwl
Copy link
Member Author

Swagger Avocado violations for resources vmssNetworkInterface.json and vmssPublicIpAddress.json. These are the Microsoft.Compute resources and their version can't be updated to match Microsoft.Network version.
Please provide approval for Swagger avocado.

@ajaygit158
Copy link
Member

Approved Avocado based on already approved in PR raised on release branch
#38556

@ajaygit158
Copy link
Member

Approving the PR as the commits are already approved on release branch (release branch PR #39391)

@ajaygit158 ajaygit158 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jan 6, 2026
@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 6, 2026
@ajaygit158
Copy link
Member

Approving suppression based on PR #39221

@kamboj-prjwl kamboj-prjwl merged commit b6d0dc8 into main Jan 7, 2026
162 of 174 checks passed
@kamboj-prjwl kamboj-prjwl deleted the kamboj-prjwl/release-network-2025-05-01 branch January 7, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Avocado Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-BranchPolicyException Changes violate the branch policy but exception has been granted. aka.ms/azsdk/pr-brch-deep BreakingChange-Go-Sdk BreakingChange-Go-Sdk-Approved BreakingChange-JavaScript-Sdk BreakingChange-JavaScript-Sdk-Approved BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. Network new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager SuppressionReviewRequired

Projects

None yet

Development

Successfully merging this pull request may close these issues.