-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Switching to consume new OpenAI TypeSpec package. #39479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Next Steps to MergeImportant checks have failed. As of today they are not blocking this PR, but in near future they may.Addressing the following failures is highly recommended:
Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
| "@azure-tools/typespec-client-generator-cli": "0.31.0", | ||
| "@azure-tools/typespec-client-generator-core": "0.63.3", | ||
| "@azure-tools/typespec-liftr-base": "0.10.0", | ||
| "@azure-tools/openai-typespec":"^0.1.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markcowl and @timotheeguerin what is our recommandation to share the common typespec? do we have limitation on where to put shared lib? what if typespec has breaking which impacted third party libs, who will be responsible for upgrading?
// import "../.external-readonly/openai.external.typespec/finetuning/custom.tsp";
import "@azure-tools/openai-typespec/models/fine-tuning";
No description provided.