[ReleasePR preview/monitor/mgmt/2019-11-01-preview/insights] [Hub Generated] Review request for Microsoft.Insights to add version stable/2018-01-01 #14810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![openapi-sdkautomation[bot]](https://avatars.githubusercontent.com/in/10463?s=60&v=4){kind=small}
[Hub Generated] Review request for Microsoft.Insights to add version stable/2018-01-01 (#14716) * Update metrics_API.json Fix lint errors, adopt the standard error response object, fix inconsistencies between swagger and real service flagged by S360 * Update GetMetricDefinitions.json Add error case to example * Update metricDefinitions_API.json Fix lint errors * Update readme.md Add lint suppression for errors in the common types file * Update metrics_API.json Update swagger to reflect what is actually being returned by the service as flagged by S360 * Create GetMetricError.json Add example of partial error case * Create GetMetricDefinitionsMetricClass.json Add example for metric definitions for metricClass * Update metricDefinitions_API.json Add metricClass field * Update metricDefinitions_API.json Switch back to the same error response format used by the rest of Azure Monitor * Update metrics_API.json Switch back to the same error response format used by the rest of Azure Monitor * Update readme.md Update suppressions * Update baseline_API.json Add type object to LocalizableString to match the LocalizableString in metrics * Update baseline_API.json Reverting change to baseline API, there are a number of other problems with this swagger that I can't fix. * Update readme.md Add suppression for MissingTypeObject on LocalizableString due to collision * Update metricDefinitions_API.json Removing the explicit type specification from LocalizableString so it continues to match other APIs * Update metrics_API.json Removing the explicit type specification from LocalizableString so it continues to match other APIs * Update GetMetricDefinitionsMetricClass.json Fix formatting problems
ghost
added
the
customer-reported
|
Thank you for your contribution openapi-sdkautomation[bot]! We will review the pull request and get back to you soon. |
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create to sync Azure/azure-rest-api-specs#14716
ReCreate this PR