[Release] sdk/resourcemanager/containerinstance/armcontainerinstance/2.0.0

[azure-sdk]

https://github.com/Azure/sdk-release-request/issues/3114

[tadelesh]

This release tries to fix customer issue. The breaking is from S360 fix. @JeffreyRichter , @jhendrixMSFT , @RickWinter Do we have conclusion that we could release such fix with minor version?

[JeffreyRichter]

Yes, a minor version upgrade is OK here.

[jhendrixMSFT]

@JeffreyRichter sorry I'm not quite on board with that POR just yet. Have we reached out to the community to get a pulse on how this will be received?

[JeffreyRichter]

We're just changing the field's tag value, right? Maybe I misread something?

[jhendrixMSFT]

IIRC, the breaking changes in this PR are introduced because the OpenAPI spec was wrong so the v1.0.0 version had some APIs that didn't work. Breaking changes were introduced in the spec to resolve the issue. I believe the question here is do we want to consider such changes as breaking when the API didn't previously work.

@tadelesh please correct me if I'm wrong on this.

[JeffreyRichter]

We allow teams to fix broken swaggers in place (without changing the api-version). This fixes the swagger but can break SDK users but, of course, they were already broken. So, the question is how to deal with SDKs: if we break them in-place (minor version change) then customers who get the latest version will get compiler errors ONLY IF they were using the stuff that was already broken and this alerts them to that fact so they can fix it. If we make these changes in a major update, then the broken stuff remains broken and only detectable at runtime at best or results in data corruption/loss at worst.

Either option is not ideal. But I tend to lean towards the former because data corruption/loss can be horrific.
But, before we decide, let's wait to see how @tadelesh responds.

[tadelesh]

This breaking is a little bit complicated. Swagger breakings approved by Jeff should be only the property change from DNSNameLabelReusePolicy to AutoGeneratedDomainNameLabelScope and enum name change from AutoGeneratedDomainNameLabelScope to DNSNameLabelReusePolicy. However, in that PR, author also changed some of the anonymous object to explicit definition. This causes some auto-generated naming change to user defined name, and also some inner anonymous object property's auto-generated naming changed. I may try to find out if it is possible to rename them by directive. Besides that, for the former breakings, should we release it with minor version?

[bmayfi3ld]

Any updates on this?